From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752295AbbLDRam (ORCPT ); Fri, 4 Dec 2015 12:30:42 -0500 Received: from mout.kundenserver.de ([212.227.126.130]:52690 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751348AbbLDRal (ORCPT ); Fri, 4 Dec 2015 12:30:41 -0500 From: Arnd Bergmann To: James Bottomley Cc: "Martin K. Petersen" , Nagalakshmi Nandigama , Praveen Krishnamoorthy , Sreekanth Reddy , Abhijit Mahajan , MPT-FusionLinux.pdl@avagotech.com, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Peter Zijlstra , Christoph Hellwig , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] mpt3sas: add PCI dependency for CONFIG_SCSI_MPT2SAS Date: Fri, 04 Dec 2015 18:29:40 +0100 Message-ID: <3653802.WUP6IeqRrU@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1449246531.27077.5.camel@HansenPartnership.com> References: <1953916.xaj9Y2FReq@wuerfel> <1449246531.27077.5.camel@HansenPartnership.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:+k2fgjZsdHuVL9VWtDPequhNrNFGlMGq3sPmfY7uTfi8jwE9ie1 iqCbOoUF3Nlte/VpdnHp6BaYIPtgSjIFz70UWw4q1Wh6Of3qkuuWR049TSEKxCB0CtYrn9R NyMXYVpl6kGBobZwaU/kdnmJMcby4vXcuRBKB4pvYhS8ScIZyJbL0ecjgr8NEk1GBMcppgH 6KsfkNLqCGU+vMjQkwW2Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:Pa1brLG5A1w=:r2COD1bPGlsF2pkXK/XoCY 4+4ionB042AAa50H1+A+ZKWWrOaGhxhHpm3Zvf0C3QvEFDDxn1hS8NEjlPq1f09w8kmjZT0GB F+Uqyl2ABhBQMNpKexsmJAA5JccmEVMlTmhLCeFlPHsiWEeIyyFruIfeRVWrOQDdQE6nIxPBI d/GV9X0SsMwVdGK7+s/Zahpd897c5tP1iFfhRhha4xyCjPJ7RxtgI1wdsyIPijVPor2KWH6Qn 11ifLJTm60IUWKS5QOpDM1C8gv8MM25HLZEaDW+1UJzRrH0lWrvWroP8C0S4+CdK/QKsNar4T Y1FH/3m3zkydU7kfDIQ1LOdL4HeBFL73b+lLtJX6xEzXmMuXQc3x0TqM5DjsvaExeALm5gEuH oDPeU32LN53vUiTNI8l83B1zRVFqc+VGiAidDKKYFiMVaZ8t64/Z0jQTFNddFejxPDgnJBLtw Qthu3oNDsDHQPXd3EFoUTWfJsapv4Kl2HEmNUnHP+pvr/BIQTi4QHb9e4zf39g0uO7L82TUeK /MkK7aAk0856i/dCnThaKcgur5je24kHt+LHNYYTyE2/Lgp7joJEgi5kwpUy1C0tsFjdMzn+Y 69KQJKnQsp6GVp2a/iRHeZeEkxZe6z4kzbFh0DopmLor7mEcFcdhEdArvBCl3wV/dPBx4lKKE +Heoh+EFSZpyflx/VTZTBwnx0NB/Md8hf7hK7wajkIaf0WBUBGjfYoTenauVStMYTH00XrE3I Y/w7CDSD2BD2u+RO Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 04 December 2015 08:28:51 James Bottomley wrote: > On Fri, 2015-12-04 at 15:27 +0100, Arnd Bergmann wrote: > > CONFIG_SCSI_MPT2SAS was added as a backwards-compatibility helper that > > selects the replacement SCSI_MPT3SAS symbol, but lacks the dependencies: > > > > warning: (SCSI_MPT2SAS) selects SCSI_MPT3SAS which has unmet direct dependencies (SCSI_LOWLEVEL && PCI && SCSI) > > 0x7E5F9A79 Fri Dec 4 12:36:08 CET 2015 failed > > drivers/scsi/mpt3sas/mpt3sas_base.c: In function 'mpt3sas_remove_dead_ioc_func': > > drivers/scsi/mpt3sas/mpt3sas_base.c:140:2: error: implicit declaration of function 'pci_stop_and_remove_bus_device_locked' [-Werror=implicit-function-declaration] > > drivers/scsi/mpt3sas/mpt3sas_base.c: In function '_base_disable_msix': > > drivers/scsi/mpt3sas/mpt3sas_base.c:1921:2: error: implicit declaration of function 'pci_disable_msix' [-Werror=implicit-function-declaration] > > > > This adds the same dependencies that SCSI_MPT3SAS has. > > OK, you're about the fifth person to complain about this and this patch > was posted a few days ago and is now here: > > http://git.kernel.org/cgit/linux/kernel/git/jejb/scsi.git/commit/?h=fixes&id=3ddda3e4c82dea58933bde8d0f6ef34470c360cb > > It's even been in for-next for nearly 24h I only found the bug on today on the latest linux-next, which should have contained it if you pushed out the branch in time, but it's not in there. 2015-12-03 16:33:05 6e3ac04845fb "Merge branch 'fixes' into for-next" 2015-12-03 21:44:54 de84dfc24842 "Merge remote-tracking branch 'scsi/for-next'" I'm sure it will be there in the next next. Arnd