mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mario Limonciello <superm1@kernel.org>
To: Alex Deucher <alexdeucher@gmail.com>
Cc: "Bjorn Helgaas" <helgaas@kernel.org>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	"Oz Tiram" <oz@shift-computing.de>,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	"Reza Nikzad Chaleshori" <rezanikzadch@gmail.com>
Subject: Re: [PATCH v6 0/3] Fix amdgpu detection of pci=realloc
Date: Thu, 19 Nov 2026 10:04:56 -0600	[thread overview]
Message-ID: <3657995d-b4f7-4a0d-9615-1c56a0127de1@kernel.org> (raw)
In-Reply-To: <CADnq5_PAarNZ24xOU3MqVfEra1hSOqgrKQxvLppyCWZQebr_yw@mail.gmail.com>



On 11/19/26 09:57, Alex Deucher wrote:
> On Thu, Nov 19, 2026 at 10:30 AM Mario Limonciello
> <mario.limonciello@amd.com> wrote:
>>
>>
>>
>> On 11/11/26 10:43, Mario Limonciello wrote:
>>> amdgpu needs to know the bus number the platform assigned a device to
>>> be able to match firmware images against the right device.
>>>
>>> This was previously adjusted to be a soft filter due to
>>> commit 11c141672045f ("drm/amdgpu: Fix VFCT bus number matching with
>>> soft filter") where if everything but the number matched to take a device.
>>>
>>> This however fails when there are two identical devices.  Instead save the
>>> initial bus number to the PCI device structure and then match that.
>>>
>>> Link: https://lore.kernel.org/linux-pci/20261015124843.203905-1-mario.limonciello@amd.com/
>>> Link: https://lore.kernel.org/amd-gfx/20261019194106.2796150-1-alexander.deucher@amd.com/
>>> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
>>> ---
>>> Changes in v6:
>>> - Capture the firmware secondary bus number when reading bridge windows and
>>>     ignore unconfigured values so rescans cannot replace it with runtime data
>>>     (Sashiko).
>>> - No change needed in the VFCT consumers; they continue to read the cached
>>>     value from the upstream bridge.
>>> - Link to v5: https://patch.msgid.link/20261110-vfct-regression-v5-0-f49fae981bf3@amd.com
>>>
>>> Changes in v5:
>>> - Record the firmware secondary bus number only on the bridge struct pci_dev,
>>>     guard it with a validity bit, and keep it across rescans (Bjorn, Lijo).
>>> - Drop pci_bus::number_initial and have amdgpu/radeon read the saved bridge
>>>     number when matching VFCT entries.
>>>
>>> Changes in v4:
>>> - Retain secondary bus bus number for a bridge across rescans, and the child bus is initialized
>>>     from it during allocation, before registration callbacks run. (Sashiko)
>>> - Rename variable to clarify it's for bridges (Lijo)
>>> - Link to v3: https://patch.msgid.link/20261026-vfct-regression-v3-0-fe9586ed6978@amd.com
>>>
>>> Changes in v3:
>>> - Preserve the firmware bus number across bridge renumbering, capturing the
>>>     secondary bus number before pci_scan_bridge_extend() clears it.
>>> - Adjust member name in all patches
>>> - Add tags
>>> - Link to v2: https://patch.msgid.link/20261020-vfct-regression-v2-0-d2394d11450a@amd.com
>>>
>>> Changes in v2:
>>> - pci_alloc_dev(NULL) remains safe.
>>> - For buses behind a reassigned bridge, the PCI core now saves the firmware secondary bus
>>>     number before clearing the bridge configuration and carries it into the newly allocated bus.
>>>     Devices discovered there inherit that original number.
>>> - Add changes for radeon too.
>>> - Link to v1: https://patch.msgid.link/20261019-vfct-regression-v1-0-5a63ddd378dd@amd.com
>>>
>>> ---
>>> Mario Limonciello (3):
>>>         PCI: Cache bridge firmware secondary bus number
>>>         drm/amdgpu: Match VFCT using initial PCI bus number
>>>         drm/radeon: Match VFCT using initial PCI bus number
>>>
>>>    drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c | 23 ++++++++++-------------
>>>    drivers/gpu/drm/radeon/radeon_bios.c     | 25 +++++++++++--------------
>>>    drivers/pci/probe.c                      | 16 ++++++++++++++--
>>>    include/linux/pci.h                      |  4 ++++
>>>    4 files changed, 39 insertions(+), 29 deletions(-)
>>> ---
>>> base-commit: c03c1a14507dfaf8b856c2608f9ac216021fc222
>>> change-id: 20261019-vfct-regression-2142fc52852a
>>>
>>> Best regards,
>>> --
>>> Mario Limonciello <mario.limonciello@amd.com>
>>
> 
> Is v6 preferred to v7?
> 
> Alex

My local linking between message IDs got messed up.  Yes comments on v7 
please, thanks for catching.


      reply	other threads:[~2026-11-19 16:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-11 16:43 Mario Limonciello
2026-11-11 16:43 ` [PATCH v6 1/3] PCI: Cache bridge firmware secondary bus number Mario Limonciello
2026-11-11 16:43 ` [PATCH v6 2/3] drm/amdgpu: Match VFCT using initial PCI " Mario Limonciello
2026-11-11 16:43 ` [PATCH v6 3/3] drm/radeon: " Mario Limonciello
2026-11-19 15:30 ` [PATCH v6 0/3] Fix amdgpu detection of pci=realloc Mario Limonciello
2026-11-19 15:57   ` Alex Deucher
2026-11-19 16:04     ` Mario Limonciello [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3657995d-b4f7-4a0d-9615-1c56a0127de1@kernel.org \
    --to=superm1@kernel.org \
    --cc=alexander.deucher@amd.com \
    --cc=alexdeucher@gmail.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=helgaas@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=oz@shift-computing.de \
    --cc=rezanikzadch@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®