From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754087AbcKRTgx (ORCPT <rfc822;w@1wt.eu>);
        Fri, 18 Nov 2016 14:36:53 -0500
Received: from mout.kundenserver.de ([212.227.126.131]:52786 "EHLO
        mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751989AbcKRTgv (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 18 Nov 2016 14:36:51 -0500
From: Arnd Bergmann <arnd@arndb.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
        Hans Verkuil <hans.verkuil@cisco.com>,
        Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
        Kieran Bingham <kieran+renesas@ksquared.org.uk>,
        Simon Horman <horms+renesas@verge.net.au>,
        Linux Media Mailing List <linux-media@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] [media] v4l: rcar_fdp1: add FCP dependency
Date: Fri, 18 Nov 2016 20:36:26 +0100
Message-ID: <3658477.0zLolAi2Y1@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <CAMuHMdWj9_X-kgbJ4FHXMR2hnUzwKCkjXbOfu0kY6bk5rcVzfQ@mail.gmail.com>
References: <20161118161621.798004-1-arnd@arndb.de> <20161118161621.798004-2-arnd@arndb.de> <CAMuHMdWj9_X-kgbJ4FHXMR2hnUzwKCkjXbOfu0kY6bk5rcVzfQ@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:jJmz5SDd9uJ8joRdIpX2sqUzb7UeXV14ZAoLZ0jjCFtcYCct735
 jRt104RyGx8c1paTvERM1TbzmNltW4lExO6GoVsWjKv4de5kEUPuGosZcLUWB2dIXgeeUEW
 GQzpuBBnPlYlbqO2ReVZkNRp+QMDcmsC17MWBeYCiGoKfWf02uC4qQJaJx7wbvz6qtYOY5w
 QeQ1QBTmovA3YB03z6tdg==
X-UI-Out-Filterresults: notjunk:1;V01:K0:P+cAePJaLc4=:322FWycQe9UZXqRgHFXgqN
 pRsFT/DJGwSFU+pqJcYYE11mERPN9c54EpTwdHdSWn0PZDm4edK1ZVccUcq58X+MrGX9BUYlj
 XGMt4K297cAyqGjK47+rYiCFsp0KqLNnpM1geyM92bPDm7dSzjKQRX20XMc0b5LwDDRHuVWNz
 TUmHAF4uop4OEy47eBMHybJ9p5mziJS+Nj+WNbzGKHTrpn4XUiFWkqLrUJdQ2WRdgeBocrUHE
 hL5ZxM7Nvog4EhDVRgwwvXW8fL0Oi503CgHYAzLE/4/sWTJPZI8viR5NAbI+dP3FCz+wyyr7r
 nbXqyw5T/VYwEyYhx12P5aB0aJrWebd7UbAbdDRExlYHzP6QesxtxJvqUJ3xKaPRG3imIGylD
 Y4AejupkLrlXmRTmt6GUrwJjkt2UKwPN+rs3F8frWHZmRQrHDrs11LVhZmMj5lD5ukvHxSAqH
 6zstjWVhbMB8TASsgJq7wM17rKMLh31TeLnvMQVHGmgq3CvsE+CIwTx3T9rcwJMN9Wolkgg1z
 ofpPOeSDDvn7HcK0Fho6IEe6MbOLC6FJkfPVRlC8IMsZ5U81pSITKK4lRDl82Rr270A+c9Ps+
 3oHjrfTdgahGnOwyqniMS7DAx2vRAFo6OGfd8TeAxOrC3N7cnm2wmL0aL+VvCFanxpzGcp0ec
 glnzINtzTHiz5kq8GC9bScOXb8KPiRiP6idM3U5HST9SxYB0BcmWcw+OGUS10so1An26OpbZJ
 z/UIft2bFXgkC5OI
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Friday, November 18, 2016 6:08:01 PM CET Geert Uytterhoeven wrote:
> > diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig
> > index 3c5a0b6b23a9..cd0cab6e0e31 100644
> > --- a/drivers/media/platform/Kconfig
> > +++ b/drivers/media/platform/Kconfig
> > @@ -311,6 +311,7 @@ config VIDEO_RENESAS_FDP1
> >         tristate "Renesas Fine Display Processor"
> >         depends on VIDEO_DEV && VIDEO_V4L2 && HAS_DMA
> >         depends on ARCH_SHMOBILE || COMPILE_TEST
> > +       depends on (!ARCH_RENESAS && !VIDEO_RENESAS_FCP) || VIDEO_RENESAS_FCP
> 
> Which tree and config is this? I don't have fdp1_pm_runtime_resume in my
> renesas-drivers tree.
> 
> Why are the dummies for !CONFIG_VIDEO_RENESAS_FCP in include/media/rcar-fcp.h
> not working?

Oops, I forgot to write a proper changelog.

Commit 4710b752e029 ("[media] v4l: Add Renesas R-Car FDP1 Driver") in the
v4l-dvb tree adds CONFIG_VIDEO_RENESAS_FDP1.

It calls into the FCP driver, but when there is no dependency, FCP might
be a module while FDP1 is built-in.

We have the same logic in VIDEO_RENESAS_VSP1, which also depends on
FCP not being a module when it is built-in itself.

	Arnd