From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933793AbdC3NSS (ORCPT ); Thu, 30 Mar 2017 09:18:18 -0400 Received: from mail-cys01nam02on0068.outbound.protection.outlook.com ([104.47.37.68]:48304 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933160AbdC3NSP (ORCPT ); Thu, 30 Mar 2017 09:18:15 -0400 From: "Jorgen S. Hansen" To: Colin King CC: "David S . Miller" , "Michael S . Tsirkin" , Adit Ranadive , George Zhang , Stefan Hajnoczi , Julia Lawall , "netdev@vger.kernel.org" , "kernel-janitors@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH][V2] VSOCK: remove unnecessary ternary operator on return value Thread-Topic: [PATCH][V2] VSOCK: remove unnecessary ternary operator on return value Thread-Index: AQHSqKHkIdPcOS/5IEGnZV2xJ2aFS6GtXuKA Date: Thu, 30 Mar 2017 13:18:10 +0000 Message-ID: <3658D20B-EBF9-48A2-95A7-026D36F18AF8@vmware.com> References: <20170329153355.17525-1-colin.king@canonical.com> In-Reply-To: <20170329153355.17525-1-colin.king@canonical.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: canonical.com; dkim=none (message not signed) header.d=none;canonical.com; dmarc=none action=none header.from=vmware.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [80.197.119.203] x-microsoft-exchange-diagnostics: 1;CY1PR05MB2521;7:9UGlTI4AWe2sSMHN75+KGWzmNrQ3LNoZxlsngNURxRZdxzw6GQzL5jZ+2jZ5hVanh11LwCwCqhk31Q8uEYZvvT5wMFjrUImvqy32DL3+kpQ+SS2n1SoTdc3ZyvY1GzKHnCTvu7opirqnRMTBlDzhqnWHw1iBTnZp2BNliuB90izCbDVOstwkXuFirSCzgTq0jCdTQWNTvPjJDS3ivEiWMjBi1nILGmjtOdtZ15ovGEpeS5p2iZGRid3dEspXvmgUDEWXeMOcjDkvg8GFFBqjex0yvAoog3c1fYoa4K5Vx8N7EVWRVgcwGKn1M9vqAayMSTIPBFRxV/oYpRIW6aqqHA==;20:G05e/LgFBJrdZog8G61nibpdd84qr4P69ZDtJV4f6K+IAp+C/EJBtQ1Q1STxA5dXnN9yhuvucCXWpJ1lT1iQm6jh9F6mCCcCJPBGGcKPWFNHvkX/d8Iok0sCcTO5qoMahJz/kbqKcgGdWcDuRqa3vdmAKJ6gJRT+YiNT9RYExJg= x-forefront-antispam-report: SFV:SKI;SCL:-1SFV:NSPM;SFS:(10009020)(6009001)(39410400002)(39840400002)(39450400003)(39400400002)(39850400002)(24454002)(377454003)(81166006)(102836003)(6116002)(3846002)(122556002)(8676002)(3280700002)(2906002)(7736002)(3660700001)(305945005)(83716003)(82746002)(575784001)(36756003)(25786009)(86362001)(189998001)(229853002)(8936002)(6486002)(6436002)(2950100002)(54906002)(99286003)(33656002)(50986999)(53936002)(77096006)(6512007)(6506006)(54356999)(6916009)(76176999)(5660300001)(6246003)(110136004)(38730400002)(4326008)(66066001)(2900100001);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR05MB2521;H:CY1PR05MB2217.namprd05.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; x-ms-office365-filtering-correlation-id: 883ec277-cede-4a21-700a-08d4776f3698 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254075)(201703131423075)(201703031133081);SRVR:CY1PR05MB2521; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(61668805478150)(198206253151910); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6041248)(20161123564025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(20161123555025)(20161123560025)(6072148);SRVR:CY1PR05MB2521;BCL:0;PCL:0;RULEID:;SRVR:CY1PR05MB2521; x-forefront-prvs: 02622CEF0A spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: MIME-Version: 1.0 X-OriginatorOrg: vmware.com X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Mar 2017 13:18:10.5105 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR05MB2521 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v2UDIoLv002429 > On Mar 29, 2017, at 5:33 PM, Colin King wrote: > > From: Colin Ian King > > Rather than assign the positive errno values to ret and then > checking if it is positive and flip the sign, just return the > errno value. > > Detected by CoverityScan, CID#986649 ("Logically Dead Code") > > Signed-off-by: Colin Ian King > --- > net/vmw_vsock/vmci_transport.c | 22 +++++++--------------- > 1 file changed, 7 insertions(+), 15 deletions(-) > > diff --git a/net/vmw_vsock/vmci_transport.c b/net/vmw_vsock/vmci_transport.c > index 4be4fbbc0b50..10ae7823a19d 100644 > --- a/net/vmw_vsock/vmci_transport.c > +++ b/net/vmw_vsock/vmci_transport.c > @@ -96,31 +96,23 @@ static int PROTOCOL_OVERRIDE = -1; > > static s32 vmci_transport_error_to_vsock_error(s32 vmci_error) > { > - int err; > - > switch (vmci_error) { > case VMCI_ERROR_NO_MEM: > - err = ENOMEM; > - break; > + return -ENOMEM; > case VMCI_ERROR_DUPLICATE_ENTRY: > case VMCI_ERROR_ALREADY_EXISTS: > - err = EADDRINUSE; > - break; > + return -EADDRINUSE; > case VMCI_ERROR_NO_ACCESS: > - err = EPERM; > - break; > + return -EPERM; > case VMCI_ERROR_NO_RESOURCES: > - err = ENOBUFS; > - break; > + return -ENOBUFS; > case VMCI_ERROR_INVALID_RESOURCE: > - err = EHOSTUNREACH; > - break; > + return -EHOSTUNREACH; > case VMCI_ERROR_INVALID_ARGS: > default: > - err = EINVAL; > + break; > } > - > - return err > 0 ? -err : err; > + return -EINVAL; > } > > static u32 vmci_transport_peer_rid(u32 peer_cid) > -- > 2.11.0 > Reviewed-by: Jorgen Hansen