Re: [PATCH v3 5/7] arm64: dts: axiado: Add initial support for AX3000 SoC and eval board

[Krzysztof Kozlowski <krzk@kernel.org>]

On 26/06/2025 03:31, Harshit Shah wrote:
> On 6/24/2025 11:05 PM, Krzysztof Kozlowski wrote:
>>>
>>>
>>>>> +                     compatible = "xlnx,zynqmp-uart", "cdns,uart-r1p12";
>>>> NAK, you do not have xlnx here. Look at your SoC: name of vendor is
>>>> axiado. Not xlnx. How is your SoC called? Also zynqmp? You cannot just
>>>> randomly pick any compatibles and stuff them around.
>>>>
>>>> Please carefully read writing bindings from DT directory.
>>>
>>> We are using the "cdns,uart-r1p12" for the UART. However, that alone
>>> can't be added alone in the compatible as per the DT bindings doc.
>> Exactly. See writing bindings... or any guides/talks.
> 
> We will add the "compatible = "axiado,ax-uart", "cdns,uart-r1p12". We 
> will append in the dt-bindings doc and driver.
> 
> Is this name look good?

No, all compatibles for SoC must be SoC specific. Take any recent
Qualcomm SM8650 or SM8750 as example.

I asked to read writing bindings. Did you read it? It covers exactly
this case.

Best regards,
Krzysztof