From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751873AbcHGMcr (ORCPT ); Sun, 7 Aug 2016 08:32:47 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:35695 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751613AbcHGMcq convert rfc822-to-8bit (ORCPT ); Sun, 7 Aug 2016 08:32:46 -0400 Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\)) Subject: Re: [PATCH 2/2] mm: compaction.c: Add/Modify direct compaction tracepoints From: Janani Ravichandran In-Reply-To: <7ab4a23a-1311-9579-2d58-263bbcdcd725@suse.cz> Date: Sun, 7 Aug 2016 18:02:41 +0530 Cc: Janani Ravichandran , linux-mm@kvack.org, linux-kernel@vger.kernel.org, riel@surriel.com, akpm@linux-foundation.org, hannes@compxchg.org, vdavydov@virtuozzo.com, mhocko@suse.com, mgorman@techsingularity.net, kirill.shutemov@linux.intel.com, bywxiaobai@163.com, rostedt@goodmis.org Content-Transfer-Encoding: 8BIT Message-Id: <36624B5E-12F3-437D-90B6-E3197D31A0F3@gmail.com> References: <7d2c2beef96e76cb01a21eee85ba5611bceb4307.1469629027.git.janani.rvchndrn@gmail.com> <7ab4a23a-1311-9579-2d58-263bbcdcd725@suse.cz> To: Vlastimil Babka X-Mailer: Apple Mail (2.2104) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Aug 1, 2016, at 6:55 PM, Vlastimil Babka wrote: > > > Yea, this tracepoint has been odd in not printing node/zone in a friendly way (it's possible to determine it from zone_start/zone_end though, so this is good in general. But instead of printing nid and zid like this, it would be nice to unify the output with the other tracepoints, e.g.: > > DECLARE_EVENT_CLASS(mm_compaction_suitable_template, > [...] > TP_printk("node=%d zone=%-8s order=%d ret=%s", > __entry->nid, > __print_symbolic(__entry->idx, ZONE_TYPE), Sure, I’ll do that in v2. Thanks! Also, I guess I should have mentioned that the tracepoint added at the end of the compaction code wasn’t just for deriving latency information. rc and *contended would give us the result of the compaction attempted, which I thought would be useful. I get that begin/end tracepoints aren’t required here, but how about having trace_mm_compaction_try_to_compact_pages moved to the end to include compaction status? Janani. > > Thanks, > Vlastimil