From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE6A04119F3 for ; Thu, 20 Aug 2026 10:18:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787221122; cv=none; b=dH7VpTMmqvsHDOCSamy7kv0AlklpJQFwTLtvdIaUC0I6aj2nRkkTPrIzM8Zkro80z/dtPaBSp6TbDBbAHBZd1VfzUh0lcS7hBMQMJKTM3AMRNJLJAZW3P+jPaauMSbSz4+rgxhV4/NlEYzrZDROXjuPkEClp/fCcHadZUwS5R8I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787221122; c=relaxed/simple; bh=oU8Q8cxZ9N9b+kZmjkv7HR2+ZdQQqp1Cz2rEVM7YSDc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=N2gQnbQBn13V1b7pmRWG9kVNbfCSnra/Vx3rmA7SPO1zB0VWRoxELSLD33nveug644Djugh3SQ5dhFh+46gT5CC7fMze0jjaGObf9PfU5jZEBgng577mlvzfRJSrNnzErZ6GUc0CLoab+Vtoow84/z+mcRrazg+FVwJc8Z0+JTA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=dj2HhQg0; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="dj2HhQg0" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-47fecbb7000so1085764f8f.2 for ; Thu, 20 Aug 2026 03:18:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1787221113; x=1787825913; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=jTRsDr3KJBScAQEjpdGgc1pnZRQT2r5s5VcOgpe4HIo=; b=dj2HhQg0Ugn/oZ0IO4A7m3B6+q3WUTqn2iVFeGDy5o6HM8tawbZ9BKIpZq/K4ex8md TGy0Uzt0rb/KterUNN61Hm6014ZcCJyNlSILbBOWyBHSPMDD6ER2tD3JIDtU4Wjpb1O9 zjkDikGeYfdZkuu2et8GdGPVJkW+nWJFQeWooYsSPaxocu1Wn5q23AUvVg1xIyu/32Bl qlXh/bt4jOBKr+T0DuE5QwofJrrfDTdEko9r62+dqmIfrDmvwZ/2VLoS2EqAr95prRNW CqB+JPUP3exlldqo3zfz60Un18pxjw79qCL8OSvmSLgPjsQrOWa/HUlISosLYRlH95H/ u+OQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787221113; x=1787825913; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=jTRsDr3KJBScAQEjpdGgc1pnZRQT2r5s5VcOgpe4HIo=; b=o4k+Z/xIjcFGRYcz7OFEH9ORg1Jcg6AfcGLCiXTspUbv4GjXpueRGrmiy2qFUZnqeN xcb7XAI+9VXctK0Ashg0OeT6c0Jd32yRRXCH8fCngXTH5+1oC8IjoZk2GhhcQaaDuDTy 3P+5CQ4VnP+qpVFQoVuIcsz64V6aWIiwWmMwCwI1hNqwQC5L4jX1Xvg7j+/2BkjRKrt7 iMTPBR5VDsIM/kMvvv1nBnvB3re60uHaDaV/RSyMZfm9ZY554J5QGfgTBbR0hZcAfaFC OKhXBINNj5nCSwKMFiFa1B9HtnOofdMMe51zpUO8qvvlrWmqKKmlvTo+8qSzNNg+7a4V tQ/g== X-Forwarded-Encrypted: i=1; AHgh+RpZKxjXQt3Mcb6hMeu7P27VCdhO1UA7OGmea1945JVaYD84vimQSY8qujhJNzI5QgMJVmto/oTM4+YWvFQ=@vger.kernel.org X-Gm-Message-State: AFuF++nwV8X48qIUZSlwNY6nvwSCLUkOUQfniFHhEY6heJChD7WAXCsO 58/CnaLVjA4hbdxHlbH+feFirXeSLHCGd1jmDk+jLbkSCnVqkPZwoqmbRv0glBzVxxo= X-Gm-Gg: AR+sD10ni3p+ScmRpsdTdG6/FO7qMNJ7Kamxs/eGzUu8UI7BzHK436J5/Vr5OpVF4RV Jl+l9OxS+k43Ea6jaFKxe+i3XXDcxbVxzWdUEBZcOnzFXCgFIaqFLNWJ5u2LJJCyc+u06qpPocm Tb5B4Zjnw+1D2E1gJsgYLrAgYf+TKZbD8wSr2M4rY9brfLtMecYu6B0qZoWlfgN5njsCWV9zZ8b FWDRWhdX++XGe8SAtV524iCqDE8LeP8ZjI19Wus1tGVOI4p5KCGLMXtQhPvijZUXChjFIPdzl3X fNe5bUhIMVjKKdQC+wHG0lCi0WPE/Spw6R1euPtt7fU4yFq26LkSMjVPs41RaIF1W8RyJ9m/M6y L0pmJd4GGc9WREoQnPWja2KmEVzITeyV/VhQ3NPOnGV5HdDiArFTidYoHnvXYQgmhTkCv5hpETl gpr9eeHgrEXhNZo6Cpqf9GllQ/jH/+n8gjmpc9AyT80Utx+Yo8xcuo+W5fXn0/j5wewfu4mNhL X-Received: by 2002:a05:6000:4918:b0:47f:8b9e:f44e with SMTP id ffacd0b85a97d-482b1fd48e7mr24038240f8f.12.1787221113240; Thu, 20 Aug 2026 03:18:33 -0700 (PDT) Received: from [192.168.0.163] ([109.76.167.53]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-482b14c33b3sm10947026f8f.27.2026.08.20.03.18.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Aug 2026 03:18:32 -0700 (PDT) Message-ID: <3662ce56-7471-491f-b2db-7a87a4379099@linaro.org> Date: Thu, 20 Aug 2026 11:18:31 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] usb: typec: qcom-pmic-typec: disable cc_debounce_dwork on stop To: Fan Wu , linux-usb@vger.kernel.org Cc: heikki.krogerus@linux.intel.com, gregkh@linuxfoundation.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260819161950.77858-1-fanwu01@zju.edu.cn> From: Bryan O'Donoghue Content-Language: en-GB In-Reply-To: <20260819161950.77858-1-fanwu01@zju.edu.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 19/08/2026 17:19, Fan Wu wrote: > cc_debounce_dwork lives on the system workqueue but is armed from > tcpm callbacks (set_cc/start_toggling). Those callbacks run on tcpm's > kthread worker which is only destroyed by tcpm_unregister_port(), after > port_stop() has already returned, opening a potential race window where > tcpm's worker flush re-arms the work. > > Use disable_delayed_work_sync() in port_stop() to cancel any pending > instance and prevent future schedule_delayed_work() calls from > succeeding. Also unwind a failed port_start() through port_stop(), > which otherwise jumps straight to tcpm_unregister_port() and leaves > the same window open after a failed probe. I'd prefer to see two patches broken at the "also" in the above statement. > > This issue was found by an in-house static analysis tool. > > Fixes: a4422ff22142 ("usb: typec: qcom: Add Qualcomm PMIC Type-C driver") > Cc: stable@vger.kernel.org # v6.10+ > Assisted-by: Codex:gpt-5.6 > Signed-off-by: Fan Wu > --- > drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c | 3 +-- > drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c | 2 ++ > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c > index 35320f89d..f42c9e65f 100644 > --- a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c > +++ b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c > @@ -101,7 +101,7 @@ static int qcom_pmic_typec_probe(struct platform_device *pdev) > > ret = tcpm->port_start(tcpm, tcpm->tcpm_port); > if (ret) > - goto port_unregister; > + goto port_stop; > > ret = tcpm->pdphy_start(tcpm, tcpm->tcpm_port); > if (ret) > @@ -117,7 +117,6 @@ static int qcom_pmic_typec_probe(struct platform_device *pdev) > tcpm->pdphy_stop(tcpm); > port_stop: > tcpm->port_stop(tcpm); > -port_unregister: > tcpm_unregister_port(tcpm->tcpm_port); > fwnode_remove: > fwnode_handle_put(tcpm->tcpc.fwnode); > diff --git a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c > index 429bd42a0..fdc379fc4 100644 > --- a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c > +++ b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c > @@ -694,6 +694,8 @@ static void qcom_pmic_typec_port_stop(struct pmic_typec *tcpm) > > for (i = 0; i < pmic_typec_port->nr_irqs; i++) > disable_irq(pmic_typec_port->irq_data[i].irq); > + > + disable_delayed_work_sync(&pmic_typec_port->cc_debounce_dwork); > } > > int qcom_pmic_typec_port_probe(struct platform_device *pdev, >