From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752610AbdFNNDe (ORCPT ); Wed, 14 Jun 2017 09:03:34 -0400 Received: from mga05.intel.com ([192.55.52.43]:15050 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752586AbdFNNDb (ORCPT ); Wed, 14 Jun 2017 09:03:31 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,340,1493708400"; d="scan'208";a="99383236" Subject: Re: [Intel-gfx] [PATCH][drm-next] drm/i915/cnl: make function cnl_ddi_dp_set_dpll_hw_state static To: Colin King , Daniel Vetter , Jani Nikula , David Airlie , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20170613134751.29196-1-colin.king@canonical.com> From: Tvrtko Ursulin Message-ID: <3662e55c-1507-3089-6d97-f96fad013a9c@linux.intel.com> Date: Wed, 14 Jun 2017 14:03:05 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170613134751.29196-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13/06/2017 14:47, Colin King wrote: > From: Colin Ian King > > The function cnl_ddi_dp_set_dpll_hw_state does not need to be in global > scope, so make it static. > > Cleans up sparse warning: > "symbol 'cnl_ddi_dp_set_dpll_hw_state' was not declared. Should it > be static?" > > Signed-off-by: Colin Ian King > --- > drivers/gpu/drm/i915/intel_dpll_mgr.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_dpll_mgr.c b/drivers/gpu/drm/i915/intel_dpll_mgr.c > index 8e669b6254ae..2f7b0e64f628 100644 > --- a/drivers/gpu/drm/i915/intel_dpll_mgr.c > +++ b/drivers/gpu/drm/i915/intel_dpll_mgr.c > @@ -2292,8 +2292,9 @@ static bool cnl_ddi_hdmi_pll_dividers(struct intel_crtc *crtc, > return true; > } > > -bool cnl_ddi_dp_set_dpll_hw_state(int clock, > - struct intel_dpll_hw_state *dpll_hw_state) > +static bool > +cnl_ddi_dp_set_dpll_hw_state(int clock, > + struct intel_dpll_hw_state *dpll_hw_state) > { > uint32_t cfgcr0; > > Reviewed-by: Tvrtko Ursulin Regards, Tvrtko