From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754715AbdEKCk1 (ORCPT ); Wed, 10 May 2017 22:40:27 -0400 Received: from mail.netline.ch ([148.251.143.178]:55425 "EHLO netline-mail3.netline.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751208AbdEKCk0 (ORCPT ); Wed, 10 May 2017 22:40:26 -0400 Subject: Re: [PATCH 0/3] GPU-DRM-Radeon: Fine-tuning for three function implementations To: =?UTF-8?Q?Christian_K=c3=b6nig?= , SF Markus Elfring , Alex Deucher , David Airlie Cc: kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, LKML References: <74d2df52-f509-e6d2-5b35-e25b7cbd1fbe@users.sourceforge.net> <799fb921-f620-9054-680d-90b14e4c517c@amd.com> <8c4e7dde-06d5-3f13-2322-f661e9d3dbf4@daenzer.net> <66a88c64-cc8f-45ed-81c6-f7e2947f1f18@amd.com> From: =?UTF-8?Q?Michel_D=c3=a4nzer?= Message-ID: <366447c1-003c-71fe-98e4-ce66890e17ea@daenzer.net> Date: Thu, 11 May 2017 11:40:15 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <66a88c64-cc8f-45ed-81c6-f7e2947f1f18@amd.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/05/17 08:30 PM, Christian König wrote: > Am 10.05.2017 um 02:23 schrieb Michel Dänzer: >> On 03/05/17 09:46 PM, Christian König wrote: >>> Am 02.05.2017 um 22:04 schrieb SF Markus Elfring: >>>> From: Markus Elfring >>>> Date: Tue, 2 May 2017 22:00:02 +0200 >>>> >>>> Three update suggestions were taken into account >>>> from static source code analysis. >>>> >>>> Markus Elfring (3): >>>> Use seq_putc() in radeon_sa_bo_dump_debug_info() >>>> Use seq_puts() in radeon_debugfs_pm_info() >>>> Use seq_puts() in r100_debugfs_cp_csq_fifo() >>> Reviewed-by: Christian König >> Based on >> https://lists.freedesktop.org/archives/dri-devel/2017-May/140837.html >> and followups, I'm afraid we'll have to make sure Markus' patches have >> been tested adequately before applying them. > > I can't judge the background of that decision, but at least those tree > patches for radeon looked trivial to me. Which is part of the issue, see also https://lists.freedesktop.org/archives/dri-devel/2017-May/140694.html and other posts in that thread. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer