From: Markus Elfring <Markus.Elfring@web.de>
To: Alexandru Ardelean <alexandru.ardelean@analog.com>,
devel@driverdev.osuosl.org, linux-iio@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Hartmut Knaack <knaack.h@gmx.de>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>
Subject: Re: [PATCH 2/3] iio: make use of iio_device_attach_kfifo_buffer() where straightforward
Date: Tue, 7 Apr 2020 11:26:03 +0200 [thread overview]
Message-ID: <36669e0f-c41c-5cc8-7218-be5cad5cf8a5@web.de> (raw)
How do you think about a patch subject like “iio: Increase use of iio_device_attach_kfifo_buffer()”?
> This change does that.
I suggest to improve also this commit message.
* Would you like to consider a wording like “Convert a specific function call
combination to a better programming interface.”?
* Do you imagine any more software fine-tuning because of related
collateral evolution?
Regards,
Markus
next reply other threads:[~2020-04-07 9:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-07 9:26 Markus Elfring [this message]
2020-04-07 9:28 ` Ardelean, Alexandru
-- strict thread matches above, loose matches on Subject: below --
2020-04-01 12:59 [PATCH 1/3] iio: kfifo: add iio_device_attach_kfifo_buffer() helper Alexandru Ardelean
2020-04-01 12:59 ` [PATCH 2/3] iio: make use of iio_device_attach_kfifo_buffer() where straightforward Alexandru Ardelean
2020-04-05 10:44 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36669e0f-c41c-5cc8-7218-be5cad5cf8a5@web.de \
--to=markus.elfring@web.de \
--cc=alexandru.ardelean@analog.com \
--cc=devel@driverdev.osuosl.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.bianconi83@gmail.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®