From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751608AbcFWAcm (ORCPT ); Wed, 22 Jun 2016 20:32:42 -0400 Received: from cloudserver094114.home.net.pl ([79.96.170.134]:56252 "HELO cloudserver094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1750787AbcFWAcl (ORCPT ); Wed, 22 Jun 2016 20:32:41 -0400 From: "Rafael J. Wysocki" To: Tejun Heo , Bhaktipriya Shridhar Cc: Zhang Rui , Len Brown , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] acpi: thermal: Remove create_workqueue Date: Thu, 23 Jun 2016 02:37 +0200 Message-ID: <36677760.GlRjyGeQ5Q@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/4.5.0-rc1+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20160607141351.GW31708@htj.duckdns.org> References: <20160607031540.GA15147@Karyakshetra> <20160607141351.GW31708@htj.duckdns.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, June 07, 2016 09:13:51 AM Tejun Heo wrote: > On Tue, Jun 07, 2016 at 08:45:40AM +0530, Bhaktipriya Shridhar wrote: > > alloc_workqueue replaces deprecated create_workqueue(). > > > > A dedicated workqueue has been used since the workqueue > > acpi_thermal_pm_queue with workitem &tz->thermal_check_work > > (maps to acpi_thermal_check_fn), is involved in thermal zone polling. > > Wallclock time is actually important and getting delayed in handling > > critical temperature event can actually lead to unnecessary hardware > > damage. So while this is not used during memory reclaim, we still want > > forward progress guarantee and be generally snappy in servicing it. > > Hence, WQ_MEM_RECLAIM and WQ_HIGHPRI have been used here. > > > > Since there are only a fixed number of work items, explicit concurrency > > limit is unnecessary here. > > > > Signed-off-by: Bhaktipriya Shridhar > > Acked-by: Tejun Heo Patch applied, thanks!