From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=185.246.84.56 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795366042; b=fIvdZRIovaTrQkTEWQcp31rw199jDihZArXAvK/BgwEIs5CPo3yQlFFe/eDouL0gwaRm lWWIW70m7D+WyWUcb2kLy+UOO3hukpo/nnsy/UaEq7924UphF17+Q2fZIQelkpzUY7iDI cKK0xx8inTj9vk5pa+Yp9S6jjVOE3YLZuBMq6UrErnpj7h9Hr9lyd4O35e6GKw7Dw/grs 0d13o7/WP2t4IOX6wMyMyAicYMsj1Zj4TQef3kf6tT+hlk0IWsUvTkyrxLjuvGyRzAgMa H0dtWp/GhiIFD7jOUT7mRZDz+Mdn3JlcN92t9Qj3MIlt11Ghgz3ZBTGaBxIbYV+Cs1w== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795366042; h=DMARC-Filter:Received:Received:Received:DKIM-Signature:Message-ID: Date:MIME-Version:User-Agent:Subject:To:Cc:References:From: Content-Language:In-Reply-To:Content-Type:Content-Transfer-Encoding: X-Last-TLS-Session-Version; bh=j6ElqDaZMsgeILsrFsQEoNXzC/7MuQ/oW+AvP106PHQ=; b=GwVP41crJKT35wk8svwRLRrmXnWn98t26ZxbDl3dzR4DNniQkP5ZftotsxipblyURRjc AO54fFFu0uPJXdM7Htscb4nuFuLacPAdAEPUgGZ6QUM6dSNxBCWLvJGi+P2munacWW1Tf 3tOFWoQW7BXP9P9lm0CFVXmCFik1H5/ws4muhg0mQRHcj7ylDtL7fJ4QNUv7Ua1CqTrPf x7Dg0m8tgFe52CHWH68UzixM+pMYfCRhNO6mWTb/kC27R+odljNNrhssK69CFV+0mO6Dj tvKFhMsuouKlb2vsSYykdTNKYeYNl9R0DWgKehremsxEMxMwZjeM4oyjz1kNnsWh/Hw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=dkim header.b=0TwXIxCZ; arc=none smtp.remote-ip=185.246.84.56 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B5D7606A32A for ; Sun, 22 Nov 2026 16:47:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 3B5D7606A32A Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=dkim header.b=0TwXIxCZ Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id A50B11A1786; Sun, 22 Nov 2026 16:47:19 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 6834460512; Sun, 22 Nov 2026 16:47:19 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 8B72611E6257F; Sun, 22 Nov 2026 17:47:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1795366038; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=j6ElqDaZMsgeILsrFsQEoNXzC/7MuQ/oW+AvP106PHQ=; b=0TwXIxCZpyJzluO4Otef5fhtskfek3eFZUrcY7zZkbxpkJlQOqLSIlU+bdnxEI4ZcE6k/Y qV9im3CO5OK3zdgCZaEdt6NA5BtHerVgTVW5gjQtj3kH2ih4GDsARlOZWIEso0wAlhUYHI lCGXvNiBOwG/9lyqpBWsMb55IJ4U6ZUeu5WMfrVztpNK9fs+7mEdPz6S0nHDvTIbKK9OnC oCUDsyagmtk47GYt27K+/BsfgVufIElepIBh1zSTXybHhc1BeazZunRmnNR96DWPyGICk5 UeSBlPFaLHJRQyaHvAeGK4MxazJxBWLo9oBPJ3mblZRE1qUl9HKaTfbJ1BpWWA== Message-ID: <366c33c9-6747-424f-8df8-71f94320a857@bootlin.com> Date: Sun, 22 Nov 2026 17:47:11 +0100 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v4 1/5] net: stmmac: dwmac-sun8i: Put the EPHY clock and reset after the MAC To: aiyengar1990@gmail.com, Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Philipp Zabel , Russell King Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, linux-kernel@vger.kernel.org References: <20261120-sun8i-emac-mux-uaf-v4-0-57eba8915f25@gmail.com> <20261120-sun8i-emac-mux-uaf-v4-1-57eba8915f25@gmail.com> From: Maxime Chevallier Content-Language: en-US In-Reply-To: <20261120-sun8i-emac-mux-uaf-v4-1-57eba8915f25@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 Hi, On 11/20/26 11:45, Arun Iyengar via B4 Relay wrote: > From: Arun Iyengar > > sun8i_dwmac_exit() unpowers the internal PHY through ephy_clk and > rst_ephy, but the probe error path and sun8i_dwmac_remove() put both > before stmmac_pltfr_remove() calls it. If mdio_mux_init() fails after > the scan of the internal bus has powered the PHY, this is a > use-after-free. > > Put them after stmmac_pltfr_remove(). The explicit unpower in remove() > is then redundant. > > Suggested-by: Chen-Yu Tsai > Signed-off-by: Arun Iyengar Reviewed-by: Maxime Chevallier Maxime > --- > drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 15 ++++++--------- > 1 file changed, 6 insertions(+), 9 deletions(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c > index 2ece7ba9dd73..9fb398f7cf9e 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c > @@ -1236,7 +1236,7 @@ static int sun8i_dwmac_probe(struct platform_device *pdev) > ret = sun8i_dwmac_register_mdio_mux(priv); > if (ret) { > dev_err(&pdev->dev, "Failed to register mux\n"); > - goto dwmac_mux; > + goto dwmac_remove; > } > } > > @@ -1244,12 +1244,11 @@ static int sun8i_dwmac_probe(struct platform_device *pdev) > > return 0; > > -dwmac_mux: > - reset_control_put(gmac->rst_ephy); > - clk_put(gmac->ephy_clk); > dwmac_remove: > pm_runtime_put_noidle(&pdev->dev); > stmmac_pltfr_remove(pdev); > + reset_control_put(gmac->rst_ephy); > + clk_put(gmac->ephy_clk); > dwmac_syscon: > sun8i_dwmac_unset_syscon(gmac); > > @@ -1262,14 +1261,12 @@ static void sun8i_dwmac_remove(struct platform_device *pdev) > struct stmmac_priv *priv = netdev_priv(ndev); > struct sunxi_priv_data *gmac = priv->plat->bsp_priv; > > - if (gmac->variant->soc_has_internal_phy) { > + if (gmac->variant->soc_has_internal_phy) > mdio_mux_uninit(gmac->mux_handle); > - sun8i_dwmac_unpower_internal_phy(gmac); > - reset_control_put(gmac->rst_ephy); > - clk_put(gmac->ephy_clk); > - } > > stmmac_pltfr_remove(pdev); > + reset_control_put(gmac->rst_ephy); > + clk_put(gmac->ephy_clk); > sun8i_dwmac_unset_syscon(gmac); > } > >