From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965041AbcKQSUf (ORCPT ); Thu, 17 Nov 2016 13:20:35 -0500 Received: from mout.kundenserver.de ([212.227.17.13]:57293 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932678AbcKQSUd (ORCPT ); Thu, 17 Nov 2016 13:20:33 -0500 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Sudeep Holla , linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, devicetree@vger.kernel.org, linux-sh@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Rob Herring , linuxppc-dev@lists.ozlabs.org Subject: Re: [RFC PATCH] of: base: add support to get machine model name Date: Thu, 17 Nov 2016 14:50:13 +0100 Message-ID: <3670336.mMHByOpDl4@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <1479383450-19183-1-git-send-email-sudeep.holla@arm.com> References: <1479383450-19183-1-git-send-email-sudeep.holla@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:vRqAJd4pS44qtntU9Xn92X2FfQ1GLSh7L23rgOo1J+9xYyQCLTI MCcjFrti8ovN//AlEj2zmtn/kOndvCld4RCm0/eqL8oLHFvXyXXm3yr43u+/sROTm3C9fck i0XxWdTeCZLIPSGuO677T3eyqQnmJHKUw3obiNO9mhpiAQ2Jnhx7uYrwXNRDm60qwVsHGEE qdW9LVYZo+5WPXDyP3zcw== X-UI-Out-Filterresults: notjunk:1;V01:K0:sZSJPg0YHl0=:ifd3zEcKU+rsebZzmlMOYm KfS9e3xhehf6sQSwFVzN3vzHfN2dpdG78igjUBI4KbsYg9EN0m+t7pQJ9P6hM4qX7jP0xlHCt lEDnai7MRbKKpocK8fox/CcKj0M5uhlgAG8RbCP2oNlshEZFySXQ029N06EpHbQW+9OE50FKK rbZJ2bXz2BSKD1oGvoBrmetfrH/zEIyR/6ibExOhYZTsl5Bgrl4QfK2+TH+St/0rEuzDn+9w8 b7LgZ7AgMJ1Ou5f7rWACwYsW/PRlFErtpuL0f7WIfL69YTEFf5UIwLBu7/hNjUKmkiim02LOC z7m/nrHzdj+MbZp6CsfiXeuAJlVBuWr7zoyi0JRxMu50RsoeRmgvZmPuLrd4xf2Iq2WTylvAt 7/W7mIcJovwM2v5Usgw/mPuh6R8Nu5arBUD3IALIMOVulE6jt/yKQYTD9zsCVkdup4/RHSczc Ch/E4btaH3eB26g27b3UFLNJpLQNWbKGrVRVaNCJUyNEhl7dc4PMvJ1PNOaMQXRAZEjtKGsS3 8OkJemC+9TvEDPErDQa2DoX/FfYDqzmn8erxvfrF7uMsYmVdCphgT6XSZ2dqxyxBgBYMwZ77T qPXGyvgvVSDQ2TiZCtnO1mrXGBr5OTUUdbm/ckLnWZSOjZpctKMt79aDbzuOpQwadVj6h50lz JBLvIGkh8pdFv2eWX+k2dYVallqohJTy86AtcumJtVvMM5gtvLw9hWs7M8J6RM4uR5PjnlEMD 7XGVATwJ1yYbYRfG Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, November 17, 2016 11:50:50 AM CET Sudeep Holla wrote: > Currently platforms/drivers needing to get the machine model name are > replicating the same snippet of code. In some case, the OF reference > counting is either missing or incorrect. > > This patch adds support to read the machine model name either using > the "model" or the "compatible" property in the device tree root node. > > Signed-off-by: Sudeep Holla I like the idea. One small comment: > +int of_machine_get_model_name(const char **model) > +{ > + int error; > + struct device_node *root; > + > + root = of_find_node_by_path("/"); > + if (!root) > + return -EINVAL; The global of_root variable points ot this already, and is defined in the same file, so I think we can just skip the lookup. Arnd