From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: "Ghannam, Yazen" <Yazen.Ghannam@amd.com>
Cc: "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"lenb@kernel.org" <lenb@kernel.org>
Subject: Re: [PATCH] ACPI / processor: Set P_LVL{2,3} idle state descriptions
Date: Tue, 19 Feb 2019 10:57:02 +0100 [thread overview]
Message-ID: <3670654.07UQUedC4A@aspire.rjw.lan> (raw)
In-Reply-To: <20190218013335.233265-1-Yazen.Ghannam@amd.com>
On Monday, February 18, 2019 2:33:49 AM CET Ghannam, Yazen wrote:
> From: Yazen Ghannam <yazen.ghannam@amd.com>
>
> The ACPI idle driver will fallback to using the legacy P_LVL* SystemIO
> method of entering C-states if the _CST method is disabled and P_BLK is
> defined. However, in this case the C2 and C3 states won't have a
> description set, so the user will see "<null>" when reading the
> description from sysfs.
>
> Give each of these states a description.
>
> Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com>
> ---
> drivers/acpi/processor_idle.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c
> index b2131c4ea124..98d4ec5bf450 100644
> --- a/drivers/acpi/processor_idle.c
> +++ b/drivers/acpi/processor_idle.c
> @@ -282,6 +282,13 @@ static int acpi_processor_get_power_info_fadt(struct acpi_processor *pr)
> pr->power.states[ACPI_STATE_C2].address,
> pr->power.states[ACPI_STATE_C3].address));
>
> + snprintf(pr->power.states[ACPI_STATE_C2].desc,
> + ACPI_CX_DESC_LEN, "ACPI P_LVL2 IOPORT 0x%x",
> + pr->power.states[ACPI_STATE_C2].address);
> + snprintf(pr->power.states[ACPI_STATE_C3].desc,
> + ACPI_CX_DESC_LEN, "ACPI P_LVL3 IOPORT 0x%x",
> + pr->power.states[ACPI_STATE_C3].address);
> +
> return 0;
> }
>
>
Applied, thanks!
prev parent reply other threads:[~2019-02-19 9:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-18 1:33 Ghannam, Yazen
2019-02-19 9:57 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3670654.07UQUedC4A@aspire.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=Yazen.Ghannam@amd.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®