From: Krzysztof Kozlowski <krzk@kernel.org>
To: Rodrigo Gobbi <rodrigo.gobbi.7@gmail.com>,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org
Cc: ~lkcamp/patches@lists.sr.ht, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: trivial-devices: Add Garmin lidar-lite-v3
Date: Fri, 4 Jul 2025 09:59:53 +0200 [thread overview]
Message-ID: <367e2429-bfd5-4c09-9d7a-194a0539091a@kernel.org> (raw)
In-Reply-To: <20250701223341.36835-1-rodrigo.gobbi.7@gmail.com>
On 02/07/2025 00:30, Rodrigo Gobbi wrote:
> The compatible grmn,lidar-lite-v3 is managed by the same
> driver of pulsedlight,lidar-lite-v2, which is a trivial device.
Nothing here explain the bug you are fixing. You need to be specific,
what is missing, what are you doing. Apparently you are documenting
existing ABI, but nothing in commit msg told me that.
As David pointed out, this is not a trivial device.
>
> Signed-off-by: Rodrigo Gobbi <rodrigo.gobbi.7@gmail.com>
> Fixes: b257c1a45e99 ("iio: pulsedlight-lidar-lite-v2: add lidar-lite-v3 property")
SoB goes the last.
Best regards,
Krzysztof
prev parent reply other threads:[~2025-07-04 7:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-01 22:30 Rodrigo Gobbi
2025-07-03 21:26 ` David Lechner
2025-07-17 22:24 ` Rodrigo Gobbi
2025-07-17 22:47 ` David Lechner
2025-07-04 7:59 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=367e2429-bfd5-4c09-9d7a-194a0539091a@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=rodrigo.gobbi.7@gmail.com \
--cc=~lkcamp/patches@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®