From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752730AbdK3M2E (ORCPT ); Thu, 30 Nov 2017 07:28:04 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57122 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750984AbdK3M2C (ORCPT ); Thu, 30 Nov 2017 07:28:02 -0500 Subject: Re: [PATCH v3 0/9] Intel Processor Trace virtulization enabling To: Luwei Kang , kvm@vger.kernel.org Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, rkrcmar@redhat.com, linux-kernel@vger.kernel.org, joro@8bytes.org References: <1511814242-12949-1-git-send-email-luwei.kang@intel.com> From: Paolo Bonzini Message-ID: <36810039-168b-9c1f-1be1-491b9b1b4271@redhat.com> Date: Thu, 30 Nov 2017 13:27:59 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1511814242-12949-1-git-send-email-luwei.kang@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Thu, 30 Nov 2017 12:28:02 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/11/2017 21:23, Luwei Kang wrote: > From v2: > - replace *_PT_SUPPRESS_PIP to *_PT_CONCEAL_PIP; > - clean SECONDARY_EXEC_PT_USE_GPA, VM_EXIT_CLEAR_IA32_RTIT_CTL and VM_ENTRY_LOAD_IA32_RTIT_CTL in SYSTEM mode. These bits must be all set or all clean; > - move processor tracing out of scattered features; > - add a new function to enable/disable intercept MSRs read/write; > - add all Intel PT MSRs read/write and disable intercept when PT is enabled in guest; > - disable Intel PT and enable intercept MSRs when L1 guest VMXON; > - performance optimization. > In Host only mode. we just need to save host RTIT_CTL before vm-entry and restore host RTIT_CTL after vm-exit; > In HOST_GUEST mode. we need to save and restore all MSRs only when PT has enabled in guest. > - use XSAVES/XRESTORES implement context switch. > Haven't implementation in this version and still in debuging. will make a separate patch work on this. That's okay. I have sent a few comments, v4 should be good. Thanks, Paolo