From: YueHaibing <yuehaibing@huawei.com>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: <simon@thekelleys.org.uk>, <linux-kernel@vger.kernel.org>,
<netdev@vger.kernel.org>, <linux-wireless@vger.kernel.org>,
<davem@davemloft.net>, <rdunlap@infradead.org>
Subject: Re: [PATCH 03/10] atmel: hide unused procfs helpers
Date: Fri, 27 Jul 2018 18:02:29 +0800 [thread overview]
Message-ID: <3684c95c-6df1-183e-8940-807dfb49e5bb@huawei.com> (raw)
In-Reply-To: <87va91vxnr.fsf@codeaurora.org>
On 2018/7/27 17:24, Kalle Valo wrote:
> (fixing top posting)
>
> YueHaibing <yuehaibing@huawei.com> writes:
>
>> On 2018/7/13 14:46, YueHaibing wrote:
>>> When CONFIG_PROC_FS isn't set, gcc warning this:
>>>
>>> drivers/net/wireless/atmel/atmel.c:1402:12: warning: ‘atmel_proc_show’ defined but not used [-Wunused-function]
>>> static int atmel_proc_show(struct seq_file *m, void *v)
>>> ^
>>> fix this by adding #ifdef around it.
>>>
>>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>>
>> pls ignore this,my bad.
>
> Why should I drop this? Does the patch have something wrong which I'm
> missing?
No,the patch is ok,just because I find this issue has a fix patch from Randy.
>
> I'm asking because I prefer this over Randy's version:
>
> https://patchwork.kernel.org/patch/10512913/
>
next prev parent reply other threads:[~2018-07-27 10:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-13 6:46 YueHaibing
2018-07-13 9:31 ` YueHaibing
2018-07-27 9:24 ` Kalle Valo
2018-07-27 10:02 ` YueHaibing [this message]
2018-07-27 15:44 ` Randy Dunlap
2018-07-31 7:21 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3684c95c-6df1-183e-8940-807dfb49e5bb@huawei.com \
--to=yuehaibing@huawei.com \
--cc=davem@davemloft.net \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=simon@thekelleys.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®