From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from SN4PR0501CU005.outbound.protection.outlook.com (mail-southcentralusazon11011069.outbound.protection.outlook.com [40.93.194.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 25231396588 for ; Mon, 23 Mar 2026 17:34:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.194.69 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774287281; cv=fail; b=uCdocU6oc0phBy+rIcRhh9Aa365pV8Ev60KnM4jDZij75BL3yejZoTaEbthyik2/+naCysvmbXn3NpsqKALPiRchum0k5Ev7h45TNqHxDB1LGnqNfsG5uwftU3Pkb7NTkcSxZM0GwGvcMEk+1KmIvRhg9taV8d86QVMfyrRz/Jk= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774287281; c=relaxed/simple; bh=gGhWk4X3aRF1KdsKxT6gcuErlI1sjQJ3/omA3ufWYi4=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=EWKRvAUNBb7XsohoBcVbZ70PcnB3oVMB4TRrEBDPwsMZfMdKszILEPmr74/fr6mnzQR/Q5z2IgfPKES8wfNM9n7VGBGPpWSDsPoC0GpLNlf70iQyem6s72IR6Erz1uspR7wH9qbbTxSxHWEf77RsgeSzT6c4qFsUCaVdHVgh00w= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=X3/AY5Fn; arc=fail smtp.client-ip=40.93.194.69 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="X3/AY5Fn" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xxgK49LXtCIXkUls/ASfPi1xb2nCr2/kcpxFersKdM8r1H5Eb183nj/jl84Oa4ctDEknruOiwpVZ/tGIIlUfb9Vd67BnvnFljU3wRBRKv50qGk54KIJM22MZod3dKQ1H+3V5DHePTtpRVgnXIgPZY1EWPf+SfnkmNLMZ6dBae6WI6HMrLnRRzniCC8E6Py7CydNindCZu8TIOQF0TLE78XgROk3SqGve1i/JBFBO1Yszoa31BDE+7ZwcOzNP+8ivYFGqmQiucj2D3+ywjTV8fW2IHYHm61S3v49iO/YsIXkKw73J8u8sD0X1TSV8o3nOPk9WZm7IdN01rdaCfgfQvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eR5SAknYEFdPYOJgZnOLJK4evTk6AvSPPiEf1fRfqIc=; b=Y/szOq7MkQEoB6xkLP2md47J1aZOBx/UoRf6fn0Md3WqBQW+LYMTy/EUN9loT5OWflNmOHZhHtHzLHAa5WsQAtA0/QXtL9RNHVTqaecW/JLHC6oZdcgPfbH552DdRaM2Qj2gGBhdz5GwhZ9ca3gTlN8cSQk9Xb9xXg6Eoly5uwPzLzA/yGxPgQm+d3lOWm2VguRiMmcNtXv6LxdwMn4jbCd4EN2Ly3wK+pmHgDdeSL92YxVM1udblQBvOm9ndKANWH8PhtnQkjPESu12rzUmepyXQffsPCJ3rRM5EiWcuxYhUkGOdQhOqLY2cvH4eIyD6IWNZ8SdpdQy2BLOCOxi3g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linux.ibm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eR5SAknYEFdPYOJgZnOLJK4evTk6AvSPPiEf1fRfqIc=; b=X3/AY5FnAVHXaSNsLLG66JwuudoFQwhzK8jrVcu7eW9p09vp7uJXEhR/2IH+KSIG9IhY3uia0kI0DIwkbbnlBozCs+68HWUTCjHuEdkgUOXvW9orUoKTOaNJbrwtIc8CdAY0Hw4Qpc6TUrbOQBFiHiEnjMWAetxuELC8iczK3fI= Received: from CH2PR07CA0053.namprd07.prod.outlook.com (2603:10b6:610:5b::27) by SA5PPF37951B1C9.namprd12.prod.outlook.com (2603:10b6:80f:fc04::8c6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9723.8; Mon, 23 Mar 2026 17:34:31 +0000 Received: from CH1PEPF0000A345.namprd04.prod.outlook.com (2603:10b6:610:5b:cafe::1f) by CH2PR07CA0053.outlook.office365.com (2603:10b6:610:5b::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9723.25 via Frontend Transport; Mon, 23 Mar 2026 17:34:31 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C Received: from satlexmb08.amd.com (165.204.84.17) by CH1PEPF0000A345.mail.protection.outlook.com (10.167.244.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9723.19 via Frontend Transport; Mon, 23 Mar 2026 17:34:31 +0000 Received: from satlexmb07.amd.com (10.181.42.216) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Mon, 23 Mar 2026 12:34:30 -0500 Received: from [172.31.184.125] (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server id 15.2.2562.17 via Frontend Transport; Mon, 23 Mar 2026 12:34:25 -0500 Message-ID: <36854600-b55b-47b8-a3ac-ad3885379fb9@amd.com> Date: Mon, 23 Mar 2026 23:04:24 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] sched/topology: Initialize sd_span after assignment to *sd To: Shrikanth Hegde CC: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Nathan Chancellor , "Valentin Schneider" , Dietmar Eggemann , Chen Yu , , Steven Rostedt , Ben Segall , Mel Gorman , "Gautham R. Shenoy" , References: <20260320235824.GA1176840@ax162> <20260321163852.11102-1-kprateek.nayak@amd.com> <2c5e1ed7-cd7c-49e3-8cb0-ebe7365ba315@linux.ibm.com> Content-Language: en-US From: K Prateek Nayak In-Reply-To: <2c5e1ed7-cd7c-49e3-8cb0-ebe7365ba315@linux.ibm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH1PEPF0000A345:EE_|SA5PPF37951B1C9:EE_ X-MS-Office365-Filtering-Correlation-Id: 637babc2-204e-4857-a6c3-08de89027121 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|7416014|376014|36860700016|82310400026|18002099003|22082099003|56012099003|7053199007; X-Microsoft-Antispam-Message-Info: IQ4dYVo8/NDnxpNFfErBrpVaxnJplWK/9lSAC4/Z9V0DHspecNrBzjEzBpSo1mjXRzh1vX7rDdHBzlpqNezH0yjmv6ozZO69Uu8L2moNrhkamAVJuC4Xr4c2ShGMUKSF9Dc2eCqH6pQypLQiBNEHUENXKhOmP3Hd+Hf1JIYYd129q7OvVKHVVpGs4gcrcQmE16Ryn7iqqxlfI593TSqY7FWvJ9v8DQCUadE2JYO/WR0U6GvtJVCzVAHfj+8o4oeVXQWk2VUrVAYboG8xnB9LqDmp1Ubko7F+nR9U5Pml9g40Dt6WZDT38fG/+b7sX7WTIAo1EaLquvboG6Bb3lxhC3s49SwnDQtiCe1BHlagFX0hrH6I+XioKfAqrFR+TpvLXXzc1t7eXvQPNk6pfRXIup0ZnXItXDKdI5G+mSNb2+CEmP217g9MKaD9b+GlmonXJG6SQRULYAMbd5X/EDd/AmcFJbgCL6vLuw4UvgW0JgjKmi4wttTX6uxgL19EHNa8qV/uB55qvn3sXWFSHDLQUygF5O6I8EOcC0j/TGbKFZjfbjlVDYf6VDV24c4PK2GaqT9nrqF+gWIJJtWj02+0QiAwyBXh42bMGKyrJSxOzfltkKU55eGmL8uiz4s8fwORisTc5UKoM4e+oXX6WdYzAIxqqZcqQ40/yT+u4AuBQIH3MUYGtSYnewkSmViZJH5dgqUKva6xVClNJw25FlOoYEclqMrEXE3wVCNG+znIb0R0vDS5/Sz3EmdIwZ0V4ThuoP50VD3TayhID/mDlkGw6A== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb08.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(7416014)(376014)(36860700016)(82310400026)(18002099003)(22082099003)(56012099003)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: zdDx2ByQCoFbPw0HT39FU3mAEHlw9BrFDFA6R/AYp0fkx/AQ7JnGk70MbPkrk11cUO3w5Us0rsJWnEoorAOKprDS3mmkv/aqnH1xO+j8znZAjpjUAx+AQ3/yH31n5z7EgZa9FV+gKR2/qznMzFcN7M/awhwJDjPgeVA35nUFYAb3XtrEtSxPZ/kBWnAsjrjk2MbayFpqcruoMMNcWcSJqqade+NfJotmRv1hHefHheilYw09BiXv2tHa1Kmk6KoePzp67ylt++r/KRMjYjBPwwMKHqoJIVZSkSH8N0TNGl2x/P50p7Jy0I6ZIQOgJHfVqJ3MoIBzLl8fJ1+lmYCWgAhM1eCuGXrOcn0u9wdcU0/IkfaiEMTvuesd0L0TK+hyA7nHV9uC/W2vLUCrEyG0EBKyqjJiT1YMv1h1dID8PcKJIQRUnshMIPsS5YM9O1OA X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2026 17:34:31.3630 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 637babc2-204e-4857-a6c3-08de89027121 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb08.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH1PEPF0000A345.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA5PPF37951B1C9 Hello Shrikanth, On 3/23/2026 2:38 PM, Shrikanth Hegde wrote: >> While at it, also initialize sd->span_weight in sd_init() since >> sd_weight now captures the cpu_map constraints. Fixup the >> sd->span_weight whenever sd_span is fixed up by the generic topology >> layer. >> > > > This description is a bit confusing. Fixup happens naturally since > cpu_map now reflects the changes right? That was for the hunk in build_sched_domain() where the the sd span is fixed up if it is found that the child isn't a subset of the parent in which case span_weight needs to be calculated again after the cpumask_or(). [..snip..] > Other than nits in changelog: > Reviewed-by: Shrikanth Hegde Thanks for the review but Peter has found an alternate approach to work around this with the current flow of computing span first. > PS: b4 am -Q was quite confused which patch to pick for 0001. > may since it was a reply to the thread. Not sure. So i pulled > each patch separate and applied. Sorry for the inconvenience. For single patch it should be still fine to grab the raw patch but for larger series I make sure to post out separately for convenience. Will be mindful next time. -- Thanks and Regards, Prateek