From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6374ECAAD8 for ; Mon, 19 Sep 2022 02:45:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229766AbiISCpA convert rfc822-to-8bit (ORCPT ); Sun, 18 Sep 2022 22:45:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35718 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229610AbiISCoz (ORCPT ); Sun, 18 Sep 2022 22:44:55 -0400 Received: from out30-56.freemail.mail.aliyun.com (out30-56.freemail.mail.aliyun.com [115.124.30.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 40FB6B483; Sun, 18 Sep 2022 19:44:53 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R991e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046059;MF=guanjun@linux.alibaba.com;NM=1;PH=DS;RN=7;SR=0;TI=SMTPD_---0VQ4Z7nR_1663555489; Received: from smtpclient.apple(mailfrom:guanjun@linux.alibaba.com fp:SMTPD_---0VQ4Z7nR_1663555489) by smtp.aliyun-inc.com; Mon, 19 Sep 2022 10:44:50 +0800 Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 15.0 \(3693.40.0.1.81\)) Subject: Re: [PATCH RESEND v1 1/9] crypto/ycc: Add YCC (Yitian Cryptography Complex) accelerator driver From: guanjun In-Reply-To: Date: Mon, 19 Sep 2022 10:44:48 +0800 Cc: "Elliott, Robert (Servers)" , "zelin.deng@linux.alibaba.com" , xuchun.shang@linux.alibaba.com, "artie.ding@linux.alibaba.com" , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8BIT Message-Id: <368EB6AC-85CB-4709-AE57-D1E3431FB415@linux.alibaba.com> References: <1662435353-114812-1-git-send-email-guanjun@linux.alibaba.com> <1662435353-114812-2-git-send-email-guanjun@linux.alibaba.com> To: Herbert Xu X-Mailer: Apple Mail (2.3693.40.0.1.81) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > 2022年9月16日 下午5:35，Herbert Xu 写道： > > On Tue, Sep 06, 2022 at 11:35:45AM +0800, 'Guanjun' wrote: > . >> +static const struct file_operations ycc_fops = { >> + .open = ycc_cdev_open, >> + .release = ycc_cdev_release, >> + .unlocked_ioctl = ycc_cdev_ioctl, >> +}; > > What is this device for? It doesn't seem to do anything so why > not jsut drop it? This device is reserved for future use. Now it does nothing actually. I will drop it in next version. Thank you very much! Regards, Guanjun > > Thanks, > -- > Email: Herbert Xu > Home Page: http://gondor.apana.org.au/~herbert/ > PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt