From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75E7A1A9FA4 for ; Mon, 23 Mar 2026 01:40:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774230053; cv=none; b=BUlKe7qaIWCgpTOyrk9RjfhvOWW0SAlAE3fBsLgaFIwzk1i6GMxb4wsuoobzacUB0urgCeoOFtx5PhLtSmlo9/bPS7e//r9SdBqeBOHaroJGUy7krqTJCRaVXxqZP2birDKHZcTPTv9SIZNRhekYbga4rRcu5vzSRRy84nuAp1I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774230053; c=relaxed/simple; bh=c4vg/yrkkoYodLTyK73OjzTRN+kuxvBTfJWAD/iCs7g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NMYNTRIr94u3NuC/+D7JU/DRjVHfaWB5gzI2pWrVPYQVKAOpuC9BMqQYL45bKLIAt5NDTjB2vyQhzX8snBNoDNHGZYhJJCzV+NgP7jtlJzhvXPoqMzVgQVxdPtalt1U6C5L4NExeIW3HBWqvRR3tz5kBAgP6JQLS5J9M519pThk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Yld0IW9N; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Yld0IW9N" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2b0484a6de4so15662555ad.3 for ; Sun, 22 Mar 2026 18:40:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774230052; x=1774834852; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=DLt09SP0vtOYo03XHu6SC4VMmvfGM5f6co6uv+DFIx8=; b=Yld0IW9N44V/PyCUaC1/ZTg/DDgyZ3CAQtRgpGXsDAfCehSGBx/2u5Pk/pWPNzBVqt eWUVscVkQF30CEOd87w/IGgKpuS7k1+F0vX+7ybTScAb27NDjuJe976xwRt0jqgjrQdO oowf170Gpo+sn/oSvMIllc9fJsoI3NqDB55sD96ZP5oIcz8qb6NFyLnQVVVGXm8ZclUN NBo/Ohh+DHaDLrPXG3YeIPz8S2218mF3bydBVLaz22n+fQDe593+Q4jK8tHrZ63W/RWy jhcZh0ALV50kNw0uK9aJMniaM5fiIxegffbYiSqzNp+yseRCUmiJfxAlOk4ieCX4we9O rxsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774230052; x=1774834852; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=DLt09SP0vtOYo03XHu6SC4VMmvfGM5f6co6uv+DFIx8=; b=MUnuAlM9tHGP9JVhZOF92Kmtnexi+J4GLiYCG/XUeOXPpY/r8DQmSEwklDs5LyZVIn okArh6zJ4exiitnf5KA/er4qjzDW7+Hd/BaOdxFy7xuaXgLhMK2i7SCRlZqDEnUUZuSf oHH8XXtB3w+GruO1y+hwVPg1B/y6M7CbqlhoCG5c3SIutFvb9M2gQ37dPwAIDxIfcPqE frZQVeoEYNUui1cE9ASlnPKffD1X9V1EiFh7IyzECY4ZWu7W3o9u5f2JvnHUD/i9/h7k St98sOpP1wg/uxK7swURdAk32oRMJnriRfNg+WcGTI3XAG6VLH2er1LO1wtQFH7Dn10G QCDQ== X-Forwarded-Encrypted: i=1; AJvYcCWquaRU12ZenEVgDKg+JZYgAkYQk8vwHlpKZdoTuLeVJn7gyQ55fk2zBRv10zgoJAPvI+1iXcblOcN+Fx0=@vger.kernel.org X-Gm-Message-State: AOJu0Yzf5FbIm88LpqZkLQY9c8jOrTc8WzTn8eDvH9grYWAPSbiId/5x s+u8EATNLGigUon2G05IlitNEWt+IlVnYBVFPF7HmR1Jy2pcnn+AlDhS X-Gm-Gg: ATEYQzxg3yLlzQYR0LLkaL+FVNGhIWZ3pp9Xp0enr/zgl2wLaAfCm/qzsyO7GIa/HrB 2QQpwMOlo3Qi9gkdm7S0tDloDT5BE5srJV2zd5YfZLGOaosvj4761YQwYLRHU1C3KDLZVd+1LeI k89j7cLyz4/P2yUg75N45II9zuv6lO2sbPmybiGODu/IN9NqzELdCP/i46p+NrpRdn9qu+2pOmd T9wsAcQ9r5fggD2iQFHL2U5buBXgRcA9iBuU+O3Zo2yjebuIwx7jS3quLXNXRPh6q7QCSwEnAvz kpYyi3/VS3OsAFmNzLUQjyc8CsKuXleSLqU5hOWkZonCvfTYQRypaZi3xvrazwLKClrNd3KVqek /+tvleeWQsKTxlEf8ppUnM1dNRFPWeCBBWpI/w6WE16BcnQiSkuF1SZNhHcDvlouQHWoO3t6PIc ei/36ZN2PTrDpVziSRZ92NZCOgxz7THSTCqWFz X-Received: by 2002:a17:902:e5ce:b0:2b0:4f82:74ca with SMTP id d9443c01a7336-2b082826cf1mr89062095ad.53.1774230051814; Sun, 22 Mar 2026 18:40:51 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b0836b6dc8sm94873195ad.82.2026.03.22.18.40.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Mar 2026 18:40:51 -0700 (PDT) Sender: Guenter Roeck Date: Sun, 22 Mar 2026 18:40:50 -0700 From: Guenter Roeck To: "Pradhan, Sanman" Cc: "linux-hwmon@vger.kernel.org" , "iwona.winiarska@intel.com" , "corbet@lwn.net" , "linux-kernel@vger.kernel.org" , Sanman Pradhan , "stable@vger.kernel.org" Subject: Re: [PATCH 2/2] hwmon: (peci/cputemp) Fix off-by-one in cputemp_is_visible() Message-ID: <36950a5e-476d-412e-8f3f-da74e6e5303b@roeck-us.net> References: <20260323002352.93417-1-sanman.pradhan@hpe.com> <20260323002352.93417-3-sanman.pradhan@hpe.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260323002352.93417-3-sanman.pradhan@hpe.com> On Mon, Mar 23, 2026 at 12:24:37AM +0000, Pradhan, Sanman wrote: > From: Sanman Pradhan > > cputemp_is_visible() validates the channel index against > CPUTEMP_CHANNEL_NUMS, but currently uses '>' instead of '>='. > As a result, channel == CPUTEMP_CHANNEL_NUMS is not rejected even though > valid indices are 0 .. CPUTEMP_CHANNEL_NUMS - 1. > > Fix the bounds check by using '>=' so invalid channel indices are > rejected before indexing the core bitmap. > > Fixes: bf3608f338e9 ("hwmon: peci: Add cputemp driver") > Cc: stable@vger.kernel.org > Signed-off-by: Sanman Pradhan Applied. Thanks, Guenter