From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-il1-f177.google.com (mail-il1-f177.google.com [209.85.166.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0EF0786328 for ; Thu, 24 Jul 2025 22:17:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753395431; cv=none; b=aFPohWdN3FUE9ci8VQPpDqMoRZ41ljDhK1hI+CpptviCG1i0Zb6SRkhP9qyFg+QiRG+SnoOxS/gQ6X0ZTe0xOzIxw7wkOEqp+KZKHEriEgqJyxXFPBtIueMcZ8c8sysaWUkX8ugTqWe8k04+W0Hv3w6pZGvGbHNbMaHEMfDeFW4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753395431; c=relaxed/simple; bh=772YePz7m9zjbtyHhHlhp4UYnNFKStTWbbper8PuJnw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bwDji2y02fb9+NmK271g7bhe2WZ/q+ixSdxf/I21iaMmxSmJSjm/z9tGuFqlY6SGKL5x76JmU3hSkhZMvLyEtjuetL+EvRKPRZk0aMu9h3hqk0cneyXAxcwyC5mWsrcy1bBIpzQYT7ghWMCSNEeDa8cVIntCYEs84glbUV5ikw4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Z3VU9Che; arc=none smtp.client-ip=209.85.166.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Z3VU9Che" Received: by mail-il1-f177.google.com with SMTP id e9e14a558f8ab-3dc9e7d10bdso6339475ab.2 for ; Thu, 24 Jul 2025 15:17:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1753395429; x=1754000229; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XSQs0NQVdoepyCBGfWzoyTl6I7sggL2Fq68RB3UkRVQ=; b=Z3VU9Che2QueCbhvGRre8MHJ5mpXPhTbza5i00wJ8kabxxwurqKG6EXbMM51XtLPpv /LWeN7QiXd5olLwWJj6gkRRoscnmB8MKKSrtWUmAmkkuXp+0hFuura0bwVvqm569S2wU Y4tc8NFW3e9CeBi38Izu1VPkY2BcukZoxclRE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753395429; x=1754000229; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XSQs0NQVdoepyCBGfWzoyTl6I7sggL2Fq68RB3UkRVQ=; b=dbm/y7yYxfAtd/l1F57GmmsNEWSfOTBG4ZPSwmVumdheOhbTDU33AysWzOUdzErjp9 B/FAYKm3dEFMp3aNFa6n0XAbz/EnVSK8HNS6g63i+USwsaqdlWG3cQ34rpxpVdCdvZKb CCepvJf97/z85nTgFF+QQz+WJSpfdvfGUhjFIwDk/xiOQsBeJBdAoncdyO6gbXhDnS4M qXoN9O7R0fpfobBX0v/4X64Qs656j8eriq6Nn2Z0O9mgSuPk6/x8B1RtUtPOoXbSv4hE TuZf96blV3Z1Q6xNBbH+bOxAAnl3izVq0HuacVA9XNr22GWSEOEztf7H2NfdAiDrlsuE eCiQ== X-Forwarded-Encrypted: i=1; AJvYcCUj1dac4uXqUPdza0eAkAPhiUk994GuvTRoP3Nh/Dm9mBTSxRpRDTuINDsm6tvH+LomEPU7CzHTpY4xdOI=@vger.kernel.org X-Gm-Message-State: AOJu0Ywevh9LNE8wGGdJjoBfR692k7zhGI5XSd44PQ7opi1B+3GLhVHX R8k8eYWjUEtUDcASBZzc990oBkVE9rxPI9VDwTXBy7KD01PWu+5ih8Du4Kxl/B4N/MM= X-Gm-Gg: ASbGncv8Mux4tiikabnl4UIzDQLyJdE7xxdbwgGAbBEcREbc6Fe8f8CPou8jWgV8YMz gobzgxwNHxWOOYi+s/dk/rQCpZ0obtfUQ5QJMoxU8Ivjt/0XDC1pYwisMdyI4NUhHcLxC1vLE6l HmiTyR+BiulrJLVKiFMk5gs2dSDCWK1v77PBSqSve9hyuk4POA3k31x5j7csZotPlGiFyxRd764 tCi5SWnjBBMqVbCopydf+YAklPWgtKWOBhakxklLcrn5qI/lMKkMWFf3Pl6i8jEwE9UfbpcNVGe OfFcJacBfCbrXN4UQcwo0pPAOyMgrNzzfc/auT+hQthFvfX989gtCnHSevsu/FoTgZ/TNm1TVue SkUJ87E23LQ+VCZefBbKePAev/+BQ7oYA1Q== X-Google-Smtp-Source: AGHT+IFo24lOuKx5SqHaaZc/IvMATHZtAjF4Omlj6JcUfoLce1g4A2LyGbQFQwfN80/Mky97Asu0dg== X-Received: by 2002:a92:cd8f:0:b0:3e2:9838:31ac with SMTP id e9e14a558f8ab-3e3355b0fa3mr157810685ab.18.1753395429159; Thu, 24 Jul 2025 15:17:09 -0700 (PDT) Received: from [192.168.1.14] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-3e3b7114181sm9154805ab.16.2025.07.24.15.17.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Jul 2025 15:17:08 -0700 (PDT) Message-ID: <369df3d1-8d6f-4f69-840c-46619f7cdaf4@linuxfoundation.org> Date: Thu, 24 Jul 2025 16:17:07 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] selftests/pidfd: Fix duplicate-symbol warnings for SCHED_ CPP symbols To: paulmck@kernel.org Cc: Christian Brauner , Shuah Khan , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Shuah Khan References: <5b53702c-0dab-46c4-9cb0-448b4da36c2e@paulmck-laptop> <90c793c3-91fd-4808-8fea-cbd07d2098e0@linuxfoundation.org> Content-Language: en-US From: Shuah Khan In-Reply-To: <90c793c3-91fd-4808-8fea-cbd07d2098e0@linuxfoundation.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 7/24/25 12:26, Shuah Khan wrote: > On 7/23/25 17:13, Paul E. McKenney wrote: >> The pidfd selftests run in userspace and include both userspace and kernel >> header files.  On some distros (for example, CentOS), this results in >> duplicate-symbol warnings in allmodconfig builds, while on other distros >> (for example, Ubuntu) it does not. >> >> Therefore, use #undef to get rid of the userspace definitions in favor >> of the kernel definitions. >> >> Other ways of handling this include splitting up the selftest code so >> that the userspace definitions go into one translation unit and the >> kernel definitions into another (which might or might not be feasible) >> or to adjust compiler command-line options to suppress the warnings >> (which might or might not be desirable). >> >> [ paulmck: Apply Shuah Khan feedback. ] > > Looks good to me. > I picked this up for Linux 6.17-rc1. thanks, -- Shuah