From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752707AbbIQSVs (ORCPT ); Thu, 17 Sep 2015 14:21:48 -0400 Received: from mga11.intel.com ([192.55.52.93]:47856 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752324AbbIQSVM convert rfc822-to-8bit (ORCPT ); Thu, 17 Sep 2015 14:21:12 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,548,1437462000"; d="scan'208";a="807480453" From: "Chen, Yu C" To: Pavel Machek CC: "rjw@rjwysocki.net" , "Brown, Len" , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Zhang, Rui" , "jlee@suse.com" , "joeyli.kernel@gmail.com" , "yinghai@kernel.org" , Ingo Molnar Subject: RE: [PATCH] [v4] PM / hibernate: Fix hibernation panic caused by inconsistent e820 map Thread-Topic: [PATCH] [v4] PM / hibernate: Fix hibernation panic caused by inconsistent e820 map Thread-Index: AQHQ8KanIoCbpdWkBUSHEc2lNYaq554/tuGAgAFRw/A= Date: Thu, 17 Sep 2015 18:21:00 +0000 Message-ID: <36DF59CE26D8EE47B0655C516E9CE64026584C96@SHSMSX101.ccr.corp.intel.com> References: <1442425343-8339-1-git-send-email-yu.c.chen@intel.com> <20150917060735.GF6665@amd> In-Reply-To: <20150917060735.GF6665@amd> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi ,Pavel > -----Original Message----- > From: Pavel Machek [mailto:pavel@ucw.cz] > Sent: Thursday, September 17, 2015 2:08 PM > To: Chen, Yu C > Cc: rjw@rjwysocki.net; Brown, Len; linux-pm@vger.kernel.org; linux- > kernel@vger.kernel.org; Zhang, Rui; jlee@suse.com; > joeyli.kernel@gmail.com; yinghai@kernel.org > Subject: Re: [PATCH] [v4] PM / hibernate: Fix hibernation panic caused by > inconsistent e820 map > > > With v3 patch applied, I did 30 cycles on my problematic platform, > > no panic triggered anymore(50% reproducible before patched, by > > plugging/unplugging memory peripheral during hibernation), and it > > just warns of invalid pages. > > NAK. Turning panic into data corruption is a bad idea. > Once an invalid page is found , the whole restoring process would be terminated (before restoring the data pages) I 'm not sure what does "data corruption" mean here? Thanks. Best Regards, Yu