From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755127AbbI1BvQ (ORCPT ); Sun, 27 Sep 2015 21:51:16 -0400 Received: from mga09.intel.com ([134.134.136.24]:2436 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752864AbbI1BvP (ORCPT ); Sun, 27 Sep 2015 21:51:15 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,600,1437462000"; d="scan'208";a="569529420" From: "Chen, Yu C" To: "Rafael J. Wysocki" CC: "Wysocki, Rafael J" , "jiang.liu@linux.intel.com" , "Zhang, Rui" , "Brown, Len" , "linux-kernel@vger.kernel.org" , "linux-pm@vger.kernel.org" Subject: RE: [PATCH][RFC] ACPI / PM: Fix incorrect wakeup irq setting before suspend-to-idle Thread-Topic: [PATCH][RFC] ACPI / PM: Fix incorrect wakeup irq setting before suspend-to-idle Thread-Index: AQHQ0xFmaJpZnOghfE+M3UXyZPqqKJ5MNWgAgADQUsCAAAIRAIACHYcggAD/uQCAAU/DMA== Date: Mon, 28 Sep 2015 01:51:09 +0000 Message-ID: <36DF59CE26D8EE47B0655C516E9CE64026587A89@SHSMSX101.ccr.corp.intel.com> References: <1439172686-16360-1-git-send-email-yu.c.chen@intel.com> <1660650.dn5zct2eoN@vostro.rjw.lan> <36DF59CE26D8EE47B0655C516E9CE64026587434@SHSMSX101.ccr.corp.intel.com> <14896395.L30bH9BMzP@vostro.rjw.lan> In-Reply-To: <14896395.L30bH9BMzP@vostro.rjw.lan> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id t8S1pehA008131 Hi, Rafael, > -----Original Message----- > From: linux-pm-owner@vger.kernel.org [mailto:linux-pm- > owner@vger.kernel.org] On Behalf Of Rafael J. Wysocki > Sent: Sunday, September 27, 2015 9:30 PM > To: Chen, Yu C > Cc: Wysocki, Rafael J; jiang.liu@linux.intel.com; Zhang, Rui; Brown, Len; linux- > kernel@vger.kernel.org; linux-pm@vger.kernel.org > Subject: Re: [PATCH][RFC] ACPI / PM: Fix incorrect wakeup irq setting before > suspend-to-idle > > On Saturday, September 26, 2015 02:37:19 PM Chen, Yu C wrote: > > Hi, Rafael, > > > > > -----Original Message----- > > > From: linux-pm-owner@vger.kernel.org [mailto:linux-pm- > > > owner@vger.kernel.org] On Behalf Of Rafael J. Wysocki > > > Sent: Friday, September 25, 2015 9:57 PM > > > To: Chen, Yu C > > > Cc: Wysocki, Rafael J; jiang.liu@linux.intel.com; Zhang, Rui; Brown, > > > Len; linux- kernel@vger.kernel.org; linux-pm@vger.kernel.org > > > Subject: Re: [PATCH][RFC] ACPI / PM: Fix incorrect wakeup irq > > > setting before suspend-to-idle > > > > > > On Friday, September 25, 2015 06:42:41 AM Chen, Yu C wrote: > > > > Hi,Rafael, thanks a lot for your review, will resend v2 version. > > > > > > > > > -----Original Message----- > > > > > From: Rafael J. Wysocki [mailto:rjw@rjwysocki.net] > > > > > Sent: Friday, September 25, 2015 9:24 AM > > > > > To: Chen, Yu C > > > > > Cc: Wysocki, Rafael J; jiang.liu@linux.intel.com; Zhang, Rui; > > > > > Brown, Len; linux- kernel@vger.kernel.org; > > > > > linux-pm@vger.kernel.org > > > > > Subject: Re: [PATCH][RFC] ACPI / PM: Fix incorrect wakeup irq > > > > > setting before suspend-to-idle > > > > > > > > > > On Monday, August 10, 2015 10:11:26 AM Chen Yu wrote: > > > > > > But I'd rather define a global acpi_irq variable, store irq in it > > > and access it directly from acpi_freeze_prepare(). And it doesn't > > > have to depend on CONFIG_SUSPEND as it is just the IRQ number > actually used by ACPI. > > > > > OK, I've convert it to a global variable acpi_inuse_irq. > > Why do you need the "inuse" part? Why is acpi_irq not sufficient? Because the name of acpi_irq is already used by acpi irq handler at drivers/acpi/osl.c: request_irq(irq, acpi_irq, IRQF_SHARED, "acpi", acpi_irq) Thanks Yu {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I