From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934523AbbI1Rag (ORCPT ); Mon, 28 Sep 2015 13:30:36 -0400 Received: from mga11.intel.com ([192.55.52.93]:18806 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933540AbbI1Rae (ORCPT ); Mon, 28 Sep 2015 13:30:34 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,603,1437462000"; d="scan'208";a="814831285" From: "Chen, Yu C" To: Javi Merino CC: "linux-pm@vger.kernel.org" , "edubezval@gmail.com" , "Zhang, Rui" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" Subject: RE: [PATCH 1/3] Thermal: initialize thermal zone device correctly Thread-Topic: [PATCH 1/3] Thermal: initialize thermal zone device correctly Thread-Index: AQHQ+OfnCGcI+kmQAU+X06HHMRSzs55Re+SAgAC3SaA= Date: Mon, 28 Sep 2015 17:30:30 +0000 Message-ID: <36DF59CE26D8EE47B0655C516E9CE64026F225EA@SHSMSX101.ccr.corp.intel.com> References: <1443332908-13948-1-git-send-email-yu.c.chen@intel.com> <20150928142812.GA8359@e104805> In-Reply-To: <20150928142812.GA8359@e104805> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id t8SHUf2c012308 Hi, Javi, > -----Original Message----- > From: Javi Merino [mailto:javi.merino@arm.com] > Sent: Monday, September 28, 2015 10:28 PM > To: Chen, Yu C > Cc: linux-pm@vger.kernel.org; edubezval@gmail.com; Zhang, Rui; linux- > kernel@vger.kernel.org; stable@vger.kernel.org > Subject: Re: [PATCH 1/3] Thermal: initialize thermal zone device correctly > > On Sun, Sep 27, 2015 at 06:48:28AM +0100, Chen Yu wrote: > > From: Zhang Rui > > > > After thermal zone device registered, as we have not read any > > temperature before, thus tz->temperature should not be 0, which > > actually means 0C, and thermal trend is not available. > > In this case, we need specially handling for the first > > thermal_zone_device_update(). > > > > Both thermal core framework and step_wise governor is enhanced to > > handle this. > > It may be worth pointing out that the step_wise governor is the only one > that uses trends, so it's the only thermal governor that needs to be updated. > OK, will add. > > > - if (old_target == instance->target) > > + if (instance->initialized && > > + old_target == instance->target) > > nit: it fits in one line, > > if (instance->initialized && old_target == instance->target) > > is 77 characters. > Not sure if the limit for one line is 75 in checkpatch.pl, I'll have a try. Thanks! Best Regards, Yu {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I