From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752171AbcD1HHP (ORCPT ); Thu, 28 Apr 2016 03:07:15 -0400 Received: from mga03.intel.com ([134.134.136.65]:36699 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750787AbcD1HHN (ORCPT ); Thu, 28 Apr 2016 03:07:13 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,545,1455004800"; d="scan'208";a="954579767" From: "Chen, Yu C" To: "Rafael J. Wysocki" CC: Linux Kernel Mailing List , Viresh Kumar , Linux PM list Subject: RE: [PATCH] cpufreq: governor: Change confusing struct field and variable names Thread-Topic: [PATCH] cpufreq: governor: Change confusing struct field and variable names Thread-Index: AQHRoNrI0HYh0TjrZkSoW7LZN+l4+5+e9uJw Date: Thu, 28 Apr 2016 07:07:09 +0000 Message-ID: <36DF59CE26D8EE47B0655C516E9CE64028748585@shsmsx102.ccr.corp.intel.com> References: <2024653.a0XKPA0FXA@vostro.rjw.lan> In-Reply-To: <2024653.a0XKPA0FXA@vostro.rjw.lan> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDBlMzBhODQtZDc4ZS00NjQyLTk4ODItZTkzYjU0OTM2Yjk0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IjVcL256UmdiNVdjbU5jWWhaT2t6UWRkWDF4UjRDdFhEUlwvMXpmU3R6YzBhQT0ifQ== x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u3S77Mb9023794 > -----Original Message----- > From: Rafael J. Wysocki [mailto:rjw@rjwysocki.net] > Sent: Thursday, April 28, 2016 7:19 AM > To: Linux PM list > Cc: Linux Kernel Mailing List; Viresh Kumar; Chen, Yu C > Subject: [PATCH] cpufreq: governor: Change confusing struct field and variable > names > > From: Rafael J. Wysocki > > The name of the prev_cpu_wall field in struct cpu_dbs_info is confusing, > because it doesn't represent wall time, but the previous update time as > returned by get_cpu_idle_time() (that may be the current value of jiffies_64 in > some cases, for example). > > Moreover, the names of some related variables in dbs_update() take that > confusion further. > > Rename all of those things to make their names reflect the purpose more > accurately. While at it, drop unnecessary parens from one of the updated > expressions. > > No functional changes. > > Signed-off-by: Rafael J. Wysocki > --- > drivers/cpufreq/cpufreq_governor.c | 22 +++++++++++----------- > drivers/cpufreq/cpufreq_governor.h | 2 +- > 2 files changed, 12 insertions(+), 12 deletions(-) Acked-by: Chen Yu