From: "Chen, Yu C" <yu.c.chen@intel.com>
To: "Wu, Fengguang" <fengguang.wu@intel.com>
Cc: "kbuild-all@01.org" <kbuild-all@01.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
"Lee, Chun-Yi" <joeyli.kernel@gmail.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
Pavel Machek <pavel@ucw.cz>, "Brown, Len" <len.brown@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH pm] PM / hibernate: swsusp_page_is_valid() can be static
Date: Tue, 14 Jul 2015 12:12:43 +0000 [thread overview]
Message-ID: <36DF59CE26D8EE47B0655C516E9CE6402F9CE9@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <20150714082338.GA66904@snb>
> -----Original Message-----
> From: Wu, Fengguang
> Sent: Tuesday, July 14, 2015 4:24 PM
> To: Chen, Yu C
> Cc: kbuild-all@01.org; Rafael J. Wysocki; Lee, Chun-Yi; linux-
> pm@vger.kernel.org; Pavel Machek; Brown, Len; linux-
> kernel@vger.kernel.org
> Subject: [PATCH pm] PM / hibernate: swsusp_page_is_valid() can be static
>
>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
> snapshot.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/power/snapshot.c b/kernel/power/snapshot.c index
> ebbb995..0e4112f4 100644
> --- a/kernel/power/snapshot.c
> +++ b/kernel/power/snapshot.c
> @@ -925,7 +925,7 @@ static void swsusp_unset_page_forbidden(struct
> page *page)
> memory_bm_clear_bit(forbidden_pages_map,
> page_to_pfn(page)); }
>
> -int swsusp_page_is_valid(struct page *page)
> +static int swsusp_page_is_valid(struct page *page)
> {
> return valid_pages_map ?
> memory_bm_test_bit(valid_pages_map,
> page_to_pfn(page)) : 0;
OK, thanks Fengguang
Best Regards,
Yu
prev parent reply other threads:[~2015-07-14 12:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-14 8:23 [pm:bleeding-edge 10/17] kernel/power/snapshot.c:928:5: sparse: symbol 'swsusp_page_is_valid' was not declared. Should it be static? kbuild test robot
2015-07-14 8:23 ` [PATCH pm] PM / hibernate: swsusp_page_is_valid() can be static kbuild test robot
2015-07-14 12:12 ` Chen, Yu C [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36DF59CE26D8EE47B0655C516E9CE6402F9CE9@SHSMSX101.ccr.corp.intel.com \
--to=yu.c.chen@intel.com \
--cc=fengguang.wu@intel.com \
--cc=joeyli.kernel@gmail.com \
--cc=kbuild-all@01.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®