From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: "linux@weissschuh.net >> Thomas Weißschuh" <linux@weissschuh.net>
Cc: dgilbert@interlog.com, jdelvare@suse.com,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, linux@roeck-us.net
Subject: Re: [PATCH v4] hwmon: add POWER-Z driver
Date: Sat, 2 Sep 2023 18:36:17 +0200 [thread overview]
Message-ID: <36a3daf7-d519-7669-13bf-4c59c11c2b97@wanadoo.fr> (raw)
In-Reply-To: <20230902-powerz-v4-1-7ec2c1440687@weissschuh.net>
Le 02/09/2023 à 09:47, Thomas Weißschuh a écrit :
> POWER-Z is a series of devices to monitor power characteristics of
> USB-C connections and display those on a on-device display.
> Some of the devices, notably KM002C and KM003C, contain an additional
> port which exposes the measurements via USB.
>
> This is a driver for this monitor port.
>
> It was developed and tested with the KM003C.
>
> Signed-off-by: Thomas Weißschuh <linux-9XfqOkM5JgxKQ7RDE2T8Pw@public.gmane.org>
> ---
...
> +static int powerz_probe(struct usb_interface *intf,
> + const struct usb_device_id *id)
> +{
> + struct powerz_priv *priv;
> + struct device *hwmon_dev;
> + struct device *parent;
> +
> + parent = &intf->dev;
> +
> + priv = devm_kzalloc(parent, sizeof(*priv), GFP_KERNEL);
> + if (!priv)
> + return -ENOMEM;
> +
> + priv->urb = usb_alloc_urb(0, GFP_KERNEL);
> + if (!priv->urb)
> + return -ENOMEM;
> + mutex_init(&priv->mutex);
> + priv->status = -ETIMEDOUT;
> + init_completion(&priv->completion);
> +
> + hwmon_dev =
> + devm_hwmon_device_register_with_info(parent, DRIVER_NAME, priv,
> + &powerz_chip_info, NULL);
> + usb_set_intfdata(intf, priv);
> +
> + return PTR_ERR_OR_ZERO(hwmon_dev);
Hi,
If 'hwmon_dev' is an PTR_ERR, priv->urb leaks.
CJ
> +}
> +
...
next prev parent reply other threads:[~2023-09-02 16:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-02 7:47 Thomas Weißschuh
2023-09-02 14:10 ` Guenter Roeck
2023-09-02 14:20 ` Thomas Weißschuh
2023-09-02 16:36 ` Christophe JAILLET [this message]
2023-09-02 22:29 ` Thomas Weißschuh
2023-09-02 22:56 ` Guenter Roeck
2023-09-03 5:54 ` Douglas Gilbert
2023-09-03 11:46 ` Guenter Roeck
2023-09-03 14:54 ` Douglas Gilbert
2023-09-03 15:08 ` Thomas Weißschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36a3daf7-d519-7669-13bf-4c59c11c2b97@wanadoo.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=dgilbert@interlog.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=linux@weissschuh.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®