From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9086BC12002 for ; Fri, 16 Jul 2021 15:33:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7BCFD613F6 for ; Fri, 16 Jul 2021 15:33:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240953AbhGPPgJ (ORCPT ); Fri, 16 Jul 2021 11:36:09 -0400 Received: from imap2.colo.codethink.co.uk ([78.40.148.184]:46242 "EHLO imap2.colo.codethink.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240972AbhGPPgI (ORCPT ); Fri, 16 Jul 2021 11:36:08 -0400 Received: from [167.98.27.226] (helo=[10.35.5.170]) by imap2.colo.codethink.co.uk with esmtpsa (Exim 4.92 #3 (Debian)) id 1m4Pps-0000Ha-Ke; Fri, 16 Jul 2021 16:33:08 +0100 Subject: Re: [PATCH] riscv: add correct as-options for assembly in modules To: Bin Meng Cc: linux-kernel@lists.codethink.co.uk, linux-kernel , linux-riscv , Paul Walmsley , Palmer Dabbelt , Albert Ou References: <20210712174849.2202287-1-ben.dooks@codethink.co.uk> From: Ben Dooks Organization: Codethink Limited. Message-ID: <36a5d9d8-67be-e128-2798-5bf1989ce06d@codethink.co.uk> Date: Fri, 16 Jul 2021 16:33:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/07/2021 11:44, Bin Meng wrote: > On Tue, Jul 13, 2021 at 2:28 AM Ben Dooks wrote: >> >> When trying to load modules built for riscv which include assembly > > nits: RISC-V > >> the kernel loader errors with "unexpected relocation type 'R_RISCV_ALIGN'" >> due to R_RISCV_ALIGN relocations being generated by the assembler. >> >> In commit 7a8e7da42250138 ("RISC-V: Fixes to module loading") >> the fix for gcc adds -mno-relax to the command line when building >> C files. However this was never applied to assembly flags, and gcc >> does no pass -mno-relax to gas when presented with a .S file. > > does not pass I'll see if I can make this simpler. Should this get done for a v2? > FYI > > The GCC bug was fixed recently via: > https://github.com/gcc-mirror/gcc/commit/3b0a7d624e64eeb81e4d5e8c62c46d86ef521857 thanks, I think it still useful to fix this in the kernel. >> >> The fix (other than making gcc always pass -mno-relax to gas) is >> to add -Wa,-mno-relax to gcc to make sure the as is invoked with >> the right options. >> >> Signed-off-by: Ben Dooks >> --- >> arch/riscv/Makefile | 1 + >> 1 file changed, 1 insertion(+) >> > > Otherwise, > Reviewed-by: Bin Meng > -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius https://www.codethink.co.uk/privacy.html