From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE4842F7EE7 for ; Thu, 4 Jun 2026 02:00:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780538441; cv=none; b=JJw3GW/UB2RD/uK2cFf6Cd3wl2fzdbPbw8Rf5aUvWrYCbJDHagDbIujTLtK3GM/2C+odrcoGhrmvt2vcMWRdVg6FK/FwDZaRFxetQQSER6/aQjW98cjbj0mp221cEpKELbhSl+6MDMwJj1n7KrC8DAAx4fNvHpqQ02TR9of/NJg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780538441; c=relaxed/simple; bh=dALv+GeRhOhibiyeNuGoTvi6I8lIZkQ6w/Pu9kYjP30=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=SBe1c7baZKYTXGBHGd04jIkMjvTLXpXA2q/8b9WB5KrYbPtxacdW9PVTPixH4+CHIBoWwyg6hDtWXe7p4fPHkUXf3+N35/Xnuvtzx6KsnuwSKj9M1Tmmg0AJkQwoUgFFxFcG5GgWaMIV17XZqmB4kBva1Es+djaT/Yl4R9JXXe0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=eGpmcRjt; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=YlAwA8Lw; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="eGpmcRjt"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="YlAwA8Lw" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65418ves140669 for ; Thu, 4 Jun 2026 02:00:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= PPHZ6wKMWABJqg0xN4h85xPsb4s35aG+DXhckI5kGo0=; b=eGpmcRjtaKnKNsJJ i8tZW/0ayMiJSaar3Y4Vg+A5A5F2K2nws2HjllBemobpDmy9SSYsRoPEr+8v65QS qu5W6wlG/zQZ/+J3QOutlUJQWPrDkvhk+AkJAkQTqMwRxGgQABNMnP2rrmEeb9iV 2JJeaKs3XHfDSwfqvFvCajOCQckrTc3+1OjXIUzgPiyPkgTGZLY56YeDbOdbtYLV QjDx5P9ooJn2WXcsWfcAX+Yz0PZyCQwd3Dy/rZyK6QH573VNrUAz6/JMacRS/JbK R3lkCZLpGjkiOOXAU1mzPXdqCCa4rFJnbfv6T8+c6QxfTaRWqPlBxB9+vZ4nJ1GV A9zvOw== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ejyen84df-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 04 Jun 2026 02:00:39 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2bf0b7425bbso4306445ad.0 for ; Wed, 03 Jun 2026 19:00:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780538439; x=1781143239; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=PPHZ6wKMWABJqg0xN4h85xPsb4s35aG+DXhckI5kGo0=; b=YlAwA8Lwnmo4awLZZMvrSefElPMn6aBRVQvsKd3Lv2je5a1G0ldfZjQqUq34wZaN48 lLp8zjAlWaA5r5EHlzaPanQ6nhDcfUk6m7mOs7OIhPWEsMXwRp75zqRyWxQBIEjgMUWt MHa4gmjb4tXGH+dT0/oGi3iWGmRzRnYqJCDQZ+9zv6qCdkSyOxX9Kbe9c0l6QQxmOSz+ GgMMM5wRrDefxGRpXjkVKTwzeiQqOJJgppAZOTOvaEw9jKs1L1FdwD7Ohktu672ugqWM /6toXRR/ZzL9fVwoHdRzupqIgwQzQUEgVOHaFrVNGHf6kHITo/APw2oiXvsFF8FWTDvD +m1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780538439; x=1781143239; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PPHZ6wKMWABJqg0xN4h85xPsb4s35aG+DXhckI5kGo0=; b=htPFfhPeef9v0jEbNQZRippi2egRL1o+/8vRz3THpSJuVH8HYvKZOjlM/0zrKdHzax PAza/MI/lm8RzL7JI+WfdlZrQ0H4nqUElE8OZDi4OjvOoQLg9Urgwh4Pt1ASVSoIjhdq KDpOQe6sYGlrfsjAW2DOVfEunBio3CJbhELIUoQesqeQrTONV1/HbTeh98f+E54TgaBV Z5Yy1PPILre9Zy0zttfleT7uaPBeza3Rrj8Ay0YsBNi6qs8Y8lffjhFDwl5x4TY5f/90 WHDHH2dRvDiiu5XGES3kNFVJjs7OlrhTG0kHiAPbilztkhf4VzPz/WX+/6S2OE4JBZxM StlQ== X-Forwarded-Encrypted: i=1; AFNElJ8MpcZpB+UxugbjgOrLEwKXKpr6UxYEL5lC5/xH2K9RYUvf+jrEEUs1YhFKOitgOMRxFDS8lYw5fnViivg=@vger.kernel.org X-Gm-Message-State: AOJu0YxTwD4x65auDzpj2zR10WDMLNOaOUkzN2RoWJW+QV3oQOqaXbta UDhCxtjERfS9NJxph7sem84fuy1OYnYBDhgVX26EWNzkBAaSkvZkinnzPUkY3rREJ2wT7J/CsRG PUQRecEeFZ9j//ya56N9ANUCXaHqcI+aTWoFYNcWoeYphYJtb4bSKFjVFBmkXLcQmf0o= X-Gm-Gg: Acq92OFk5xMfkDDOscPqcHsfok45EhaMOveImzzVwyzJPAoBSBtRJqfsAaGgE0QA49l j/aDDFG7AOugBLKSQm14pLWXpZHo1rjTVdgPD8B3HMLqcHFEtHvY9vq4gd44m/Sbz6R+11kYkwa SA32W7SHoidDgznrAg0GEUkjcvPTsaX6j/VA1FYX0C75m+CSZlvCS1+SGeYLq7ub1TY3h7M14j/ uL7pDu3t37J8Dis+YxwOyJN7Q+gwCDaVdB3fiRfSoe1qn6qMOvbU9e2vNf3KKDQ/tWWS4s1GSsD nkCpphVX4QMYL8WE2UdxmrnQ9bkfHwT1v2PqX9ziEjMMzkGjtGzrU62L30p8e43ZYYau8M0H0N2 XXWyGXv5DyOg1OiZCmkdEG+RvDmsPrhB66uyIg5HWHpOmBnMEWfx9kXFGXRuQOlRjc+4MojLsZb GXBaUL0bPp4udOV1MwwiAI X-Received: by 2002:a17:903:3810:b0:2be:39bd:8dd8 with SMTP id d9443c01a7336-2c1644add2fmr66968105ad.33.1780538438713; Wed, 03 Jun 2026 19:00:38 -0700 (PDT) X-Received: by 2002:a17:903:3810:b0:2be:39bd:8dd8 with SMTP id d9443c01a7336-2c1644add2fmr66963345ad.33.1780538434322; Wed, 03 Jun 2026 19:00:34 -0700 (PDT) Received: from [10.133.33.77] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c164f6cea3sm37901735ad.7.2026.06.03.19.00.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Jun 2026 19:00:33 -0700 (PDT) Message-ID: <36a64e47-9d61-4641-94fd-2568d86fd067@oss.qualcomm.com> Date: Thu, 4 Jun 2026 10:00:29 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] media: qcom: iris: fix runtime PM reference leaks To: Hungyu Lin , vikash.garodia@oss.qualcomm.com, dikshita.agarwal@oss.qualcomm.com, abhinav.kumar@linux.dev, bod@kernel.org, mchehab@kernel.org Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260604004404.34797-1-dennylin0707@gmail.com> Content-Language: en-US From: Jie Gan In-Reply-To: <20260604004404.34797-1-dennylin0707@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=JaSMa0KV c=1 sm=1 tr=0 ts=6a20dc47 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=pGLkceISAAAA:8 a=0rn2apig9_SYVe37ewgA:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-ORIG-GUID: JH3gVIM7n06hkL-V7llcyLYx2A6dqAJ5 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA0MDAxNyBTYWx0ZWRfX/8nL8qH0XUlN L4iYpEdOevcUB1aZVcZFyY4mRd5c3kS0YeX33OTPWG+J5Rc2JkHLwPcvCovAA0W9FwPG0Df4qK5 T9VwJPhpZ18ILPGAFeuUIXLllWswg2Lee6AwDw6iHl231TsmKBtpE7E4AwG9lRCUoSMRrCG3med VIK4czbVeIDNo+onplC1zwBKRDLpEyXAdT9HoisCspL/6CnAW6nxZyT+PZuO9tRpFRibWPq4B9c d8HTOMHMPO1UVjkavOrnM8/vyYQT96C0h3pn5p46L6E6pednNSdQNB6Xtgty+LLhk/2Qarq+Lp4 YXEABVgyhQSIozic2bN6f0DNdjleZHWcy+LrdVvyET3qUm+N7+aA8rKu+WBqEygsQqVxhE3ZaBm gtIorF+T6UTcTlJJ+v/DkM61cFrX6VnzrNf0BJpMwdZ+QDTwA1WaJbH/YWR8AADMeN/KItOS2uh fHTxm7hwujpT4hDspyg== X-Proofpoint-GUID: JH3gVIM7n06hkL-V7llcyLYx2A6dqAJ5 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-04_01,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 phishscore=0 bulkscore=0 adultscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 malwarescore=0 priorityscore=1501 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606040017 On 6/4/2026 8:44 AM, Hungyu Lin wrote: > Use pm_runtime_resume_and_get() in iris_enable_power_domains() > to avoid leaking a runtime PM usage count on failure. > > Also ensure pm_runtime_put_sync() is always called in > iris_disable_power_domains(), even when iris_opp_set_rate() > fails, so runtime PM references remain balanced. > Please add a fix tag for the fix patch. Fixes: bb8a95aa038e ("media: iris: implement power management") Thanks, Jie > Signed-off-by: Hungyu Lin > --- > drivers/media/platform/qcom/iris/iris_resources.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/drivers/media/platform/qcom/iris/iris_resources.c b/drivers/media/platform/qcom/iris/iris_resources.c > index 773f6548370a..f5e3341e1430 100644 > --- a/drivers/media/platform/qcom/iris/iris_resources.c > +++ b/drivers/media/platform/qcom/iris/iris_resources.c > @@ -78,11 +78,11 @@ int iris_enable_power_domains(struct iris_core *core, struct device *pd_dev) > if (ret) > return ret; > > - ret = pm_runtime_get_sync(pd_dev); > - if (ret < 0) > + ret = pm_runtime_resume_and_get(pd_dev); > + if (ret) > return ret; > > - return ret; > + return 0; > } > > int iris_disable_power_domains(struct iris_core *core, struct device *pd_dev) > @@ -90,12 +90,10 @@ int iris_disable_power_domains(struct iris_core *core, struct device *pd_dev) > int ret; > > ret = iris_opp_set_rate(core->dev, 0); > - if (ret) > - return ret; > > pm_runtime_put_sync(pd_dev); > > - return 0; > + return ret; > } > > static struct clk *iris_get_clk_by_type(struct iris_core *core, enum platform_clk_type clk_type)