From: Mark Brown <broonie@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: David Gow <davidgow@google.com>,
Brendan Higgins <brendanhiggins@google.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regmap: REGMAP_KUNIT must not select REGMAP
Date: Wed, 26 Apr 2023 13:42:45 +0100 [thread overview]
Message-ID: <36a8dc3b-50bb-4db8-a7eb-bb69517187da@sirena.org.uk> (raw)
In-Reply-To: <a89cb0eae953f534011d3a655fa70feb01fb2b73.1682510075.git.geert@linux-m68k.org>
[-- Attachment #1: Type: text/plain, Size: 815 bytes --]
On Wed, Apr 26, 2023 at 01:56:44PM +0200, Geert Uytterhoeven wrote:
> Enabling a (modular) test must not silently enable additional kernel
> functionality, as that may increase the attack vector of a product.
>
> Fix this by making REGMAP_KUNIT depend on REGMAP instead.
This doesn't work since regmap is a selected library so there's no way
to directly enable regmap other than by enabling something that uses it
and it is very likely that the virtual configurations people often use
with KUnit will not have any physical hardware and therefore will not
need regmap. It seems a lot more likely that someone would want to run
the tests on a platform that doesn't otherwise use regmap than that
someone would end up building in regmap on a production kernel that
wouldn't otherwise have enabled it.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-04-26 12:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-26 11:56 Geert Uytterhoeven
2023-04-26 12:42 ` Mark Brown [this message]
2023-04-26 13:34 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36a8dc3b-50bb-4db8-a7eb-bb69517187da@sirena.org.uk \
--to=broonie@kernel.org \
--cc=brendanhiggins@google.com \
--cc=davidgow@google.com \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®