From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E8371B424F for ; Wed, 18 Dec 2024 14:40:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734532824; cv=none; b=EDgpvEnl0+9JvEw0yXhr4sQ3HU8S+lXOL1dnBTraZY0L0itECvDeUZI7G0GVIX3C7/maIyeD4RlHkA/1+t9/VmfQkbJxnB3LN+jLgLxOhnQwPBWudyedVKoPxBIIVJwWZFowTwld4Ca+5lv0kmpcufZkB2oBOJAaQIP3CWI3lt8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734532824; c=relaxed/simple; bh=MYWyZqQicrU2HLWP/vikxeUSbuV4UvRsmPuh67h43Qg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EnkWpYbGs8caRgITHtaASh21vRZMATpFLhfoPlxmgTma/cFeRt20GzXiTmTqfuNf0rnty/CnnfRJo2fBHbGkKeNMETErH3LeZFpSoPIS1cgEWer86fM2C/oWsanX1UjxaLjIi+iKYr9wCcn+skf3d6PUzwX0Kwkho/g8FAPQSaE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Rax5FfHs; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Rax5FfHs" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734532821; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=J1JS5UgW5KEKPW82arLRkpB87zDMMpNUIULtXsMrMZU=; b=Rax5FfHsX4iMglvCwURW3YxspBTF/kRqty9feZmkStOIQxXWSClFgE6yz2KhC5rckG8qFV LCYfKjbIDPA421DCt3SKzm0yRhL3OB6Ep9OElzCOCPgcwQ9PA634gBVNWOh6WLrB627N9E tpcwlqwflvt1boCagB2jUJzs/QaML20= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-669-pf1sl4BFOT-bVxxEWXfuhQ-1; Wed, 18 Dec 2024 09:40:20 -0500 X-MC-Unique: pf1sl4BFOT-bVxxEWXfuhQ-1 X-Mimecast-MFC-AGG-ID: pf1sl4BFOT-bVxxEWXfuhQ Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-6d89154adabso121146706d6.0 for ; Wed, 18 Dec 2024 06:40:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734532820; x=1735137620; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=J1JS5UgW5KEKPW82arLRkpB87zDMMpNUIULtXsMrMZU=; b=fAyqa7jbvxPYr33p1gQ6FqJQpXNjZoQmF0yTMdZ5rQTFiboLA66vBJFwQ4B/em0zng fdCY3fyJivC5L/Am3vExfUDZA2WSnC+AvCvI+bNz8tq54uiz2lTgAH2Id3JU3BO1f6B5 fqLeGKneF6Vh82NfiV5Iql9BR8l79Mlx+DdED8htErB+XArAc1Bu3C1RHg4IihiWJZmR 2UTqEXexkecDSVSoHkbt9rWmYdySiPrp1nZgeKzkzOcdAXGnEgABFGtZMF4p471WK33M yDLhxWBkmaEdhC4lbPqWZnUU9c2wu8wQGiKV8DfGZHdqobsj5YUpotmWeUCf3Nbco0gr 3c4g== X-Forwarded-Encrypted: i=1; AJvYcCUyXkeO0EEaAvUGdWyFblKhMmcK0YG3SiDcR3aGsfrdZzssM/aFrfrfAt1L4CCdP33sACvnEHuvse/jTqk=@vger.kernel.org X-Gm-Message-State: AOJu0YxR+9tXWLvyce4B7tVwo1bRI4+5nwuDcjSB+d12p3AusYE/Jt40 vnwUw1Gh5TAlwsIREf8Unc7IkYX3ud6A4lnfvZAhwl5kgot8/aA6CkkyHN+yMpOCkTyRRgYXjh2 pdHn4RAq84Sc7KdI5KZQZMhvLYTAUsBKctSSedBD5SoC2sUuKc/+uEfaB6xCwuw== X-Gm-Gg: ASbGnct69bnhDqnYEjwnPlrNAYZxpSG2IV1G5XhHvtXitOpm/7hBhSlYgHD+zK4Lwl0 VtLYW+eCzhJZPmu5MCXDfJhkOGNIjH6cbpQIkQFCjEO054oYBXkgNoFt+Hp4HpedhxyXdsfRFk8 KXfIyr1RpFX4kCxtwPIVmnprDkPPfTaMCPEYJoDBMZ/vOGNpQed9Bb23/Kr6MbBynzKJXnKfU53 W7qTBvftTE8jS1gfvFT+5VdN26gMfb7Rc3hZr3W9EvhcHRPjpp33tawJBCEPafNYV19+d5nZJTO XLZmA0RzI8bTPqLGcMM5L7k= X-Received: by 2002:a05:6214:2a89:b0:6d8:8416:9c54 with SMTP id 6a1803df08f44-6dd091afdfemr59695136d6.16.1734532819761; Wed, 18 Dec 2024 06:40:19 -0800 (PST) X-Google-Smtp-Source: AGHT+IHaOUhW5lOdJ2FuzpZIYF4vXjrAM20LoQL28HLXSIyoyy9x4+1Fgy3rctig226BDr/QRvLUMA== X-Received: by 2002:a05:6214:2a89:b0:6d8:8416:9c54 with SMTP id 6a1803df08f44-6dd091afdfemr59694656d6.16.1734532819450; Wed, 18 Dec 2024 06:40:19 -0800 (PST) Received: from ?IPV6:2a01:e0a:59e:9d80:527b:9dff:feef:3874? ([2a01:e0a:59e:9d80:527b:9dff:feef:3874]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6dccd3a4c5esm49404806d6.131.2024.12.18.06.40.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Dec 2024 06:40:18 -0800 (PST) Message-ID: <36aba488-26d7-4dc9-9ca0-a14e3de028e9@redhat.com> Date: Wed, 18 Dec 2024 15:40:13 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V2 04/46] arm64/sysreg: Update register fields for TRBIDR_EL1 Content-Language: en-US To: Anshuman Khandual , linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, maz@kernel.org Cc: ryan.roberts@arm.com, Oliver Upton , James Morse , Suzuki K Poulose , Catalin Marinas , Will Deacon , Mark Brown References: <20241210055311.780688-1-anshuman.khandual@arm.com> <20241210055311.780688-5-anshuman.khandual@arm.com> From: Eric Auger In-Reply-To: <20241210055311.780688-5-anshuman.khandual@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Anshuman On 12/10/24 06:52, Anshuman Khandual wrote: > This adds register fields for TRBIDR_EL1 as per the definitions based > on DDI0601 2024-09. > > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Mark Brown > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Anshuman Khandual > --- > arch/arm64/tools/sysreg | 15 +++++++++++++-- > 1 file changed, 13 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg > index 59351931d907..10b1a0998d99 100644 > --- a/arch/arm64/tools/sysreg > +++ b/arch/arm64/tools/sysreg > @@ -3295,13 +3295,24 @@ Field 31:0 TRG > EndSysreg > > Sysreg TRBIDR_EL1 3 0 9 11 7 > -Res0 63:12 > +Res0 63:48 > +Field 47:32 MaxBuffSize > +Res0 31:16 > +UnsignedEnum 15:12 MPAM > + 0b0000 NI > + 0b0001 PMG Out of curiosity how did you choose the PMG terminology? I see "MPAM implemented by the Trace Buffer Unit, using default PARTID and PMG values in External mode". Wouldn't be TBU more meaningful? Eric > + 0b0010 IMP > +EndEnum > Enum 11:8 EA > 0b0000 NON_DESC > 0b0001 IGNORE > 0b0010 SERROR > EndEnum > -Res0 7:6 > +UnsignedEnum 7:6 AddrMode > + 0b00 VIRT_PHYS > + 0b01 VIRT_ONLY > + 0b10 PHYS_ONLY > +EndEnum > Field 5 F > Field 4 P > Field 3:0 Align