From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64FB33451A3 for ; Mon, 12 Jan 2026 08:56:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768208213; cv=none; b=cBRJhiEdnDy+E7OHRvuEFL2xH8fe53jjrMiuLM0dhPd9agf0H9PinP0aZjGmfDCPCQyBM0Wr7+Zi22xTKdxiiW9KmYJx3rS5zNlntMAs9GKaOrUr5cviShYXEYzHhsCc0Pvkjtc+OD6pURFAN35IRCA8oF8aGL1tBK/k/TdyGow= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768208213; c=relaxed/simple; bh=X/5hoL4vsyw+/OxggE/JrchTzVJaler35/dzY9dSvYI=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=IoZiKjFeFoJnTUs/E5hS6q5KXQokRAhQXSOXgAocYA/TevHDh9rrfngOURF8OpKcFfVtIcRV7tCEcjA8lVrBfImi/hE9N3YVEQ3G3isdg8NwA1CjPYH9PtmDE3lfMAHz67j4TtjFa4M3ONmTlQ5h8PWChm/10fM2VHWELdL7fe4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=g7icm/rL; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="g7icm/rL" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-47bdbc90dcaso43294535e9.1 for ; Mon, 12 Jan 2026 00:56:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1768208210; x=1768813010; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=xqnnGtIxNlVf6w1jM+yfYZ9zVPTNLypP9dGXnku780c=; b=g7icm/rL1YmjBK+8y01DEZtLfEPs2uXEWNe4yOnEV6CKCwjQOwxmhNB3Bukei4Sn7J G/3SdVwnulEojNSOPZZCuoX4+vS2no67IqOr3MSYh9UXQnUmY6jDUcAd5Mhs+Mswf4ke LWmOR8YzKU2YjA4+c6sW+m5i4vOLk2uXgc0lSiWAK8BJwUmq5UiPYCLtX+tDYLkntwiW JnG5L4t3w46SGjKZwAMh4qyEk+a5xnxlEVGji1G0JVs/yUcpCjKhuyDVrQ6fhMqhyaIv JZWB1DOAaM0+xgDdC1eAPJcGtU8rcqgz6FyxpFm8ExN6zQdBJnirWdydk+UAmmH69ae4 LUng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768208210; x=1768813010; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xqnnGtIxNlVf6w1jM+yfYZ9zVPTNLypP9dGXnku780c=; b=XVC52OnrvGD1OhMT4CvCXa0KVN2oDRyiyW0d11MBOmLM3pO1Ic8neub0IyqAjD9xx9 OvRmn6slN7/5WIwoVvxTyBSZaR4e4UH7cxQQIOt2pkRv/6c9UwX2BsIR087GD2BMfge0 dds/7P084fOdsxEYAi5jOmFXqLsBeDV/qbNI6id9UqerUwbEO2lJHEKwqse56+BlCSiS 4Bq0TDtwNgReWdNdjAGrmo0XHODbGMxnr1WyIcEcZM4rhNjD7W0AvlzoOfaG1w2CGsO9 8cXr3a8+BeQpLOsoVyDYN5ITT0/HiWi7JjHC5wf41u1Qep1a4StC15RQpWBNyRlKOjrc YkMQ== X-Forwarded-Encrypted: i=1; AJvYcCVUfTkuOkoz6DB+hIeSReKZ18kj+/NjzDGv+0EdlMwzJQAyFxmZOQf14R3j2L14VBOGPZO2aMNUJhHDzD8=@vger.kernel.org X-Gm-Message-State: AOJu0YwC1iOaGsE2bQpTnQ24McFsbiYiY563bhbPzqo4thYDvlZ5qKbj XU6x9L2r26Jwqf+SEnVrePKn2U5+VSmZUi7p86e5D5EepWklcM+IM1KfZ2+ttDFU1YM= X-Gm-Gg: AY/fxX7RZ7vfJ3WOv+J0F0p/mptOerJ0P4g8gNC9uC7DFz+8+aLtZQ41MOX0KhyAjf2 zRqotLoTdOlIUMV/mZNefv5q/TTI9m7OsOO+53HiiQwqEOPDv9dNzcRXrbPjEefJfS+C/su8OE9 XOBAHxJ8sC2/ot+Dydvss0eDgWFmszkLfitO1gmpJQNR3eJkA/cCSUOSrYWG2KbHWRwtXNvOySq Df9w7J9zl/u6aIvP15eg6GqIlXI+1buL4ZljyTQ0CK65t9DAFhhBTQlMvbLbt0kJIxqL2U4PEUL OPSu2w69zWsMh+yfBbqL4hiJ3fOYzrqGHRenbi0iXGlo4S2jQpQ/JFhr+D+AozgQIWhRG8Aey6w 0gaW6jCQQRlKhVkmdz68Mjz03O2taebNUjvrYPx0etS/J5IfslkPcREhVD/ll+R4Z8N+EEFNgea Vgk5BpPphMcm2mdY4IbrNb32oxt3CqxmnUSNYB X-Google-Smtp-Source: AGHT+IFuCnspaCv8g+IBSAWuq2o5Dpv1jawmEhlUdS77n/0/v6F6FTauE4NJ/C7ohaLR8Hktf9Y25Q== X-Received: by 2002:a05:600c:3493:b0:477:333a:f71f with SMTP id 5b1f17b1804b1-47d84b3471fmr189644505e9.17.1768208209792; Mon, 12 Jan 2026 00:56:49 -0800 (PST) Received: from [192.168.0.20] (nborisov.ddns.nbis.net. [85.187.217.240]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d7f68f69dsm340713765e9.1.2026.01.12.00.56.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Jan 2026 00:56:49 -0800 (PST) Message-ID: <36b42ced-f1e8-4eb0-b6f8-2a9434d5d26c@suse.com> Date: Mon, 12 Jan 2026 10:56:47 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] x86/mce: Fix timer interval adjustment after logging a MCE event To: lirongqing , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Tony Luck , Yazen Ghannam , Qiuxu Zhuo , Avadhut Naik , linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org References: <20260112082747.2842-1-lirongqing@baidu.com> Content-Language: en-US From: Nikolay Borisov Autocrypt: addr=nik.borisov@suse.com; keydata= xsFNBGcrpvIBEAD5cAR5+qu30GnmPrK9veWX5RVzzbgtkk9C/EESHy9Yz0+HWgCVRoNyRQsZ 7DW7vE1KhioDLXjDmeu8/0A8u5nFMqv6d1Gt1lb7XzSAYw7uSWXLPEjFBtz9+fBJJLgbYU7G OpTKy6gRr6GaItZze+r04PGWjeyVUuHZuncTO7B2huxcwIk9tFtRX21gVSOOC96HcxSVVA7X N/LLM2EOL7kg4/yDWEhAdLQDChswhmdpHkp5g6ytj9TM8bNlq9I41hl/3cBEeAkxtb/eS5YR 88LBb/2FkcGnhxkGJPNB+4Siku7K8Mk2Y6elnkOctJcDvk29DajYbQnnW4nhfelZuLNupb1O M0912EvzOVI0dIVgR+xtosp66bYTOpX4Xb0fylED9kYGiuEAeoQZaDQ2eICDcHPiaLzh+6cc pkVTB0sXkWHUsPamtPum6/PgWLE9vGI5s+FaqBaqBYDKyvtJfLK4BdZng0Uc3ijycPs3bpbQ bOnK9LD8TYmYaeTenoNILQ7Ut54CCEXkP446skUMKrEo/HabvkykyWqWiIE/UlAYAx9+Ckho TT1d2QsmsAiYYWwjU8igXBecIbC0uRtF/cTfelNGrQwbICUT6kJjcOTpQDaVyIgRSlUMrlNZ XPVEQ6Zq3/aENA8ObhFxE5PLJPizJH6SC89BMKF3zg6SKx0qzQARAQABzSZOaWtvbGF5IEJv cmlzb3YgPG5pay5ib3Jpc292QHN1c2UuY29tPsLBkQQTAQoAOxYhBDuWB8EJLBUZCPjT3SRn XZEnyhfsBQJnK6byAhsDBQsJCAcCAiICBhUKCQgLAgQWAgMBAh4HAheAAAoJECRnXZEnyhfs XbIQAJxuUnelGdXbSbtovBNm+HF3LtT0XnZ0+DoR0DemUGuA1bZAlaOXGr5mvVbTgaoGUQIJ 3Ejx3UBEG7ZSJcfJobB34w1qHEDO0pN9orGIFT9Bic3lqhawD2r85QMcWwjsZH5FhyRx7P2o DTuUClLMO95GuHYQngBF2rHHl8QMJPVKsR18w4IWAhALpEApxa3luyV7pAAqKllfCNt7tmed uKmclf/Sz6qoP75CvEtRbfAOqYgG1Uk9A62C51iAPe35neMre3WGLsdgyMj4/15jPYi+tOUX Tc7AAWgc95LXyPJo8069MOU73htZmgH4OYy+S7f+ArXD7h8lTLT1niff2bCPi6eiAQq6b5CJ Ka4/27IiZo8tm1XjLYmoBmaCovqx5y5Xt2koibIWG3ZGD2I+qRwZ0UohKRH6kKVHGcrmCv0J YO8yIprxgoYmA7gq21BpTqw3D4+8xujn/6LgndLKmGESM1FuY3ymXgj5983eqaxicKpT9iq8 /a1j31tms4azR7+6Dt8H4SagfN6VbJ0luPzobrrNFxUgpjR4ZyQQ++G7oSRdwjfIh1wuCF6/ mDUNcb6/kA0JS9otiC3omfht47yQnvod+MxFk1lTNUu3hePJUwg1vT1te3vO5oln8lkUo9BU knlYpQ7QA2rDEKs+YWqUstr4pDtHzwQ6mo0rqP+zzsFNBGcrpvIBEADGYTFkNVttZkt6e7yA LNkv3Q39zQCt8qe7qkPdlj3CqygVXfw+h7GlcT9fuc4kd7YxFys4/Wd9icj9ZatGMwffONmi LnUotIq2N7+xvc4Xu76wv+QJpiuGEfCDB+VdZOmOzUPlmMkcJc/EDSH4qGogIYRu72uweKEq VfBI43PZIGpGJ7TjS3THX5WVI2YNSmuwqxnQF/iVqDtD2N72ObkBwIf9GnrOgxEyJ/SQq2R0 g7hd6IYk7SOKt1a8ZGCN6hXXKzmM6gHRC8fyWeTqJcK4BKSdX8PzEuYmAJjSfx4w6DoxdK5/ 9sVrNzaVgDHS0ThH/5kNkZ65KNR7K2nk45LT5Crjbg7w5/kKDY6/XiXDx7v/BOR/a+Ryo+lM MffN3XSnAex8cmIhNINl5Z8CAvDLUtItLcbDOv7hdXt6DSyb65CdyY8JwOt6CWno1tdjyDEG 5ANwVPYY878IFkOJLRTJuUd5ltybaSWjKIwjYJfIXuoyzE7OL63856MC/Os8PcLfY7vYY2LB cvKH1qOcs+an86DWX17+dkcKD/YLrpzwvRMur5+kTgVfXcC0TAl39N4YtaCKM/3ugAaVS1Mw MrbyGnGqVMqlCpjnpYREzapSk8XxbO2kYRsZQd8J9ei98OSqgPf8xM7NCULd/xaZLJUydql1 JdSREId2C15jut21aQARAQABwsF2BBgBCgAgFiEEO5YHwQksFRkI+NPdJGddkSfKF+wFAmcr pvICGwwACgkQJGddkSfKF+xuuxAA4F9iQc61wvAOAidktv4Rztn4QKy8TAyGN3M8zYf/A5Zx VcGgX4J4MhRUoPQNrzmVlrrtE2KILHxQZx5eQyPgixPXri42oG5ePEXZoLU5GFRYSPjjTYmP ypyTPN7uoWLfw4TxJqWCGRLsjnkwvyN3R4161Dty4Uhzqp1IkNhl3ifTDYEvbnmHaNvlvvna 7+9jjEBDEFYDMuO/CA8UtoVQXjy5gtOhZZkEsptfwQYc+E9U99yxGofDul7xH41VdXGpIhUj 4wjd3IbgaCiHxxj/M9eM99ybu5asvHyMo3EFPkyWxZsBlUN/riFXGspG4sT0cwOUhG2ZnExv XXhOGKs/y3VGhjZeCDWZ+0ZQHPCL3HUebLxW49wwLxvXU6sLNfYnTJxdqn58Aq4sBXW5Un0Q vfbd9VFV/bKFfvUscYk2UKPi9vgn1hY38IfmsnoS8b0uwDq75IBvup9pYFyNyPf5SutxhFfP JDjakbdjBoYDWVoaPbp5KAQ2VQRiR54lir/inyqGX+dwzPX/F4OHfB5RTiAFLJliCxniKFsM d8eHe88jWjm6/ilx4IlLl9/MdVUGjLpBi18X7ejLz3U2quYD8DBAGzCjy49wJ4Di4qQjblb2 pTXoEyM2L6E604NbDu0VDvHg7EXh1WwmijEu28c/hEB6DwtzslLpBSsJV0s1/jE= In-Reply-To: <20260112082747.2842-1-lirongqing@baidu.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 12.01.26 г. 10:27 ч., lirongqing wrote: > From: Li RongQing > > Since commit 011d82611172 ("RAS: Add a Corrected Errors Collector"), > mce_notify_irq() in should_enable_timer() always returns false even should_enable_timer doesn't call mce_notify_irq > when an MCE event is logged, because bit 0 of mce_need_notify is not > set in mce_log. This prevents the timer interval from being properly > adjusted. > > Fix this by modifying machine_check_poll() to return a boolean indicating > whether an MCE was logged, and update mc_poll_banks() to propagate this > return value. The timer interval logic in mce_timer_fn() now uses this > return value directly instead of relying on mce_notify_irq(). This warrants a bit more explanation why it's correct. Because mce_notify_irq is really a misnomer, it will ideally be named mce_notify_user(). That function is called from 2 places: 1. Early notifier block, but there it's guaranteed to do the right thing as mce_need_notify is explicitly set. 2. From the timer function, where as you have pointed out mce_need_notify is never set by the polling code, hence the function is a noop. But actually calling mce_log() processes all logged errors in the gen pool and that is processed by calling the x86_mce_decoder_chain which will DTRT w.r.t to mce_notify_irq since the early notifier will be called from there.