From: Tianyu Lan <ltykernel@gmail.com>
To: "Michael Kelley (LINUX)" <mikelley@microsoft.com>,
KY Srinivasan <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
"wei.liu@kernel.org" <wei.liu@kernel.org>,
Dexuan Cui <decui@microsoft.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"bp@alien8.de" <bp@alien8.de>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"x86@kernel.org" <x86@kernel.org>,
"hpa@zytor.com" <hpa@zytor.com>,
"daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>,
"arnd@arndb.de" <arnd@arndb.de>
Cc: Tianyu Lan <Tianyu.Lan@microsoft.com>,
"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"vkuznets@redhat.com" <vkuznets@redhat.com>
Subject: Re: [PATCH V3 5/9] x86/hyperv: Use vmmcall to implement Hyper-V hypercall in sev-snp enlightened guest
Date: Fri, 28 Jul 2023 18:45:54 +0800 [thread overview]
Message-ID: <36b73cf6-4594-c9b2-2896-cd0dd49f8974@gmail.com> (raw)
In-Reply-To: <BYAPR21MB16880B1657BA4C907D002730D700A@BYAPR21MB1688.namprd21.prod.outlook.com>
On 7/26/2023 10:29 PM, Michael Kelley (LINUX) wrote:
>> Hi Michael:
>> Thanks for your review. The patch mentioned by Boris has not been
>> merged and so still use X86_FEATURE_SEV_ES here. We may replace the
>> feature flag with X86_FEATURE_SEV_SNP after it's upstreamed.
>>
> Just so I'm clear, is it true that in an SEV-SNP VM, the CPUID flags for
> SEV-ES*and* SEV-SNP are set? That would seem to be necessary for
> your approach to work.
Yes, SEV and SEV-ES flags are set in the SEV-SNP guest and they are
necessary.
>
> I wonder if it would be better to take the patch from Brijesh Singh
> that adds X86_FEATURE_SEV_SNP and add it to your patch set (with
> Brijesh's agreement, of course). That patch is small and straightforward.
>
I will sync with Brijesh. Thanks for suggestion.
next prev parent reply other threads:[~2023-07-28 10:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-18 3:22 [PATCH V3 0/9] x86/hyperv: Add AMD sev-snp enlightened guest support on hyperv Tianyu Lan
2023-07-18 3:22 ` [PATCH V3 1/9] x86/hyperv: Add sev-snp enlightened guest static key Tianyu Lan
2023-07-26 3:26 ` Michael Kelley (LINUX)
2023-07-18 3:22 ` [PATCH V3 2/9] x86/hyperv: Set Virtual Trust Level in VMBus init message Tianyu Lan
2023-07-26 3:28 ` Michael Kelley (LINUX)
2023-07-18 3:22 ` [PATCH V3 3/9] x86/hyperv: Mark Hyper-V vp assist page unencrypted in SEV-SNP enlightened guest Tianyu Lan
2023-07-18 3:22 ` [PATCH V3 4/9] drivers: hv: Mark percpu hvcall input arg " Tianyu Lan
2023-07-18 3:22 ` [PATCH V3 5/9] x86/hyperv: Use vmmcall to implement Hyper-V hypercall in sev-snp " Tianyu Lan
2023-07-26 3:44 ` Michael Kelley (LINUX)
2023-07-26 13:47 ` Tianyu Lan
2023-07-26 14:29 ` Michael Kelley (LINUX)
2023-07-28 10:45 ` Tianyu Lan [this message]
2023-07-18 3:23 ` [PATCH V3 6/9] clocksource: hyper-v: Mark hyperv tsc page unencrypted " Tianyu Lan
2023-07-18 3:23 ` [PATCH V3 7/9] x86/hyperv: Initialize cpu and memory for SEV-SNP " Tianyu Lan
2023-07-26 4:26 ` Jinank Jain
2023-07-26 14:15 ` Tianyu Lan
2023-07-18 3:23 ` [PATCH V3 8/9] x86/hyperv: Add smp support for SEV-SNP guest Tianyu Lan
2023-07-18 3:23 ` [PATCH V3 9/9] x86/hyperv: Add hyperv-specific handling for VMMCALL under SEV-ES Tianyu Lan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36b73cf6-4594-c9b2-2896-cd0dd49f8974@gmail.com \
--to=ltykernel@gmail.com \
--cc=Tianyu.Lan@microsoft.com \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=daniel.lezcano@linaro.org \
--cc=dave.hansen@linux.intel.com \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=hpa@zytor.com \
--cc=kys@microsoft.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikelley@microsoft.com \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=wei.liu@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome