From: "Asbjørn Sloth Tønnesen" <ast@fiberby.net>
To: Davide Caratti <dcaratti@redhat.com>
Cc: netdev@vger.kernel.org, Ilya Maximets <i.maximets@ovn.org>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
David Ahern <dsahern@kernel.org>, Simon Horman <horms@kernel.org>,
Ratheesh Kannoth <rkannoth@marvell.com>,
Florian Westphal <fw@strlen.de>,
Alexander Lobakin <aleksander.lobakin@intel.com>,
linux-kernel@vger.kernel.org,
Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH net-next v2 01/10] net/sched: flower: refactor tunnel flag definitions
Date: Mon, 8 Jul 2024 12:38:12 +0000 [thread overview]
Message-ID: <36b8ba99-0a8d-4b06-89cc-c1cc1cceeb8b@fiberby.net> (raw)
In-Reply-To: <CAKa-r6u85yD=Ct4nq2xZLXLT+3vWsz+WoDZ__xS4tkpge=yf-Q@mail.gmail.com>
Hi Davide,
On 7/8/24 12:07 PM, Davide Caratti wrote:
> On Mon, Jul 8, 2024 at 1:12 PM Asbjørn Sloth Tønnesen<ast@fiberby.net> wrote:
> [...]
>
>> Davide, I think David Ahern would be happy [1] if you could post a new iproute2 patch,
>> since the kernel patches should preferably hit net-next this week (due to uAPI breakage).
> I will send an updated patch (don't use "matches" + add missing man
> page + rename keywords [1]) in the next hours.
Great.
>> Nit: I would prefix all of these with "tun_".
> "tun_" or just "tun" ? please note that each flag can have a "no"
> prefix, so is it better
>
> notuncsum
> notundf
> notunoam
> notuncrit
>
> or
>
> notun_csum
> notun_df
> notun_oam
> notun_crit
>
> ?
>
> (I'm for not using the underscore - but I'm open to ideas: please let me know)
I'm fine with no underscores, alternatively recognizing both "no" and "no_" prefixes.
--
Best regards
Asbjørn Sloth Tønnesen
Network Engineer
Fiberby - AS42541
next prev parent reply other threads:[~2024-07-08 12:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-05 13:33 [PATCH net-next v2 00/10] flower: rework TCA_FLOWER_KEY_ENC_FLAGS usage Asbjørn Sloth Tønnesen
2024-07-05 13:33 ` [PATCH net-next v2 01/10] net/sched: flower: refactor tunnel flag definitions Asbjørn Sloth Tønnesen
2024-07-08 11:11 ` Asbjørn Sloth Tønnesen
2024-07-08 12:07 ` Davide Caratti
2024-07-08 12:38 ` Asbjørn Sloth Tønnesen [this message]
2024-07-05 13:33 ` [PATCH net-next v2 02/10] net/sched: flower: define new tunnel flags Asbjørn Sloth Tønnesen
2024-07-05 13:33 ` [PATCH net-next v2 03/10] net/sched: cls_flower: prepare fl_{set,dump}_key_flags() for ENC_FLAGS Asbjørn Sloth Tønnesen
2024-07-05 13:33 ` [PATCH net-next v2 04/10] net/sched: cls_flower: add policy for TCA_FLOWER_KEY_FLAGS Asbjørn Sloth Tønnesen
2024-07-05 13:33 ` [PATCH net-next v2 05/10] flow_dissector: prepare for encapsulated control flags Asbjørn Sloth Tønnesen
2024-07-05 13:33 ` [PATCH net-next v2 06/10] flow_dissector: set encapsulated control flags from tun_flags Asbjørn Sloth Tønnesen
2024-07-05 13:33 ` [PATCH net-next v2 07/10] net/sched: cls_flower: add tunnel flags to fl_{set,dump}_key_flags() Asbjørn Sloth Tønnesen
2024-07-05 13:33 ` [PATCH net-next v2 08/10] net/sched: cls_flower: rework TCA_FLOWER_KEY_ENC_FLAGS usage Asbjørn Sloth Tønnesen
2024-07-05 13:33 ` [PATCH net-next v2 09/10] flow_dissector: cleanup FLOW_DISSECTOR_KEY_ENC_FLAGS Asbjørn Sloth Tønnesen
2024-07-05 13:33 ` [PATCH net-next v2 10/10] flow_dissector: set encapsulation control flags for non-IP Asbjørn Sloth Tønnesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36b8ba99-0a8d-4b06-89cc-c1cc1cceeb8b@fiberby.net \
--to=ast@fiberby.net \
--cc=aleksander.lobakin@intel.com \
--cc=davem@davemloft.net \
--cc=dcaratti@redhat.com \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=horms@kernel.org \
--cc=i.maximets@ovn.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rkannoth@marvell.com \
--cc=stephen@networkplumber.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®