From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 461F3C7618D for ; Thu, 6 Apr 2023 15:54:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239439AbjDFPyX (ORCPT ); Thu, 6 Apr 2023 11:54:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58076 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239417AbjDFPyU (ORCPT ); Thu, 6 Apr 2023 11:54:20 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0200C9750 for ; Thu, 6 Apr 2023 08:53:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680796414; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DfBJz2JCY2tXUX/6IQuIUiWHj7GX2hI633TNpoPdRVg=; b=C3x8Bvz6t59Z3OT3pV0GgaWxB8X/rpHD63tVFjCsHEMWuh3l7krH2ZzNw2bM9jKskDz+Xu Ca0NjNtmHiXOZeqo5AeTd2eUa+COMTL1bWLTYmxcKS+/rmKdWbFtGhvVgQImTYiZzhQgu2 j3mXTSVmOe0ss5K641fR4tIBZiXuUp8= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-568-1KkVPaiCOyyfOjc6vZNExA-1; Thu, 06 Apr 2023 11:53:28 -0400 X-MC-Unique: 1KkVPaiCOyyfOjc6vZNExA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 55660101A551; Thu, 6 Apr 2023 15:53:28 +0000 (UTC) Received: from [10.22.9.26] (unknown [10.22.9.26]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1BF472166B26; Thu, 6 Apr 2023 15:53:27 +0000 (UTC) Message-ID: <36b96b9c-d08a-e97c-05ff-152d671880e6@redhat.com> Date: Thu, 6 Apr 2023 11:53:27 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2] mm: oom: introduce cpuset oom Content-Language: en-US To: Gang Li Cc: rientjes@google.com, linux-kernel@vger.kernel.org, Zefan Li , cgroups@vger.kernel.org References: <20230404115509.14299-1-ligang.bdlg@bytedance.com> <342c1967-8a68-275c-042e-765d5993157c@redhat.com> From: Waiman Long In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/6/23 09:02, Gang Li wrote: > On 2023/4/5 01:24, Waiman Long wrote: >> >> You will also need to take cpuset_rwsem to make sure that cpusets are >> stable. BTW, the cpuset_cgroup_scan_tasks() name is kind of >> redundant. I will suggest you just name it as cpuset_scan_tasks(). >> Please also add a > > mem cgroup oom use `mem_cgroup_scan_tasks`. > How about keep `cpuset_cgroup_scan_tasks` for naming consistency? The "memory cgroup" term is used to identify the code related to memory cgroup controller. Cpuset, on the other hand, is a well known cgroup controller. Cpuset cgroup is not a term that people will normally use.  That is why this name is awkward. Cheers, Longman