From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3CEB63FCB24 for ; Tue, 24 Mar 2026 13:50:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774360242; cv=none; b=U6OFYvuddDLXukAwjepk4b0NmBFctqZxxAzMj9rQ7TTyJ2jCP0umS3qXj7YjQnHgZ0T42nV9yzEY8Ub3N8L63eCGY+/UZ9tyuVY6CdQnmgVpCLGah69Jru91lTLYsSo2wjykCUzqkcZFiyUrp5Ai+NIsc4nSukK5qh648iia7kM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774360242; c=relaxed/simple; bh=pRpXqKX3DGcpGHW4S1fO6rEvBtyVW5LqY/TcQkUDdAc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Yjxf2GjHfZhjzAOZfQbZTPUzD5BI8vKwu6hhZVOHrKHZFJ81QwjR+vpzKi+5VmN59jBqI4DbuzM803zCiE6jG1tnjbKsEco6iynX0LGwCRoliWlTNvn9MIzadZ5EnU4mhwu7ztyhPIw3iveal1siwt8CY7fgvdYz9/6Z/w/of8g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=J7TInatF; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=D76dGWBe; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="J7TInatF"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="D76dGWBe" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62O9RUgN3934853 for ; Tue, 24 Mar 2026 13:50:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 1DKfsPVlgxtOA6J/xo55HFoYXQ/cUtB7i3T3emkwyDg=; b=J7TInatFj9ehsEo/ jB3397IxH024in81il1Vx2I4kXtr1YPpiB8RuM2zIQtGWqMIdledSobbNBS4HnDX SLcY0RF2DtK7SxPHO5ktHKvbs2DDO5J/oh1o9UpERaiyjxr/EL9MrciUCfRN8foC z2fflsDhXOxgNsRuX85XQbfeeNJuLudrjq38AQ8Kgu886pCU7Jr5+DCrFngXHTTx xazU5khmMTGYzGgUgrWdhvCHLepXp+oZh43zb5A8l94xD+x+dNbX/I/7Jts30SIU TLtIiaCKflPavgzK3uM31W87F2uwGw7X2p71R9Cbt7SN290PVGLP9TiRQO0dj8Kn 1RnkUA== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d37a0mprw-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 24 Mar 2026 13:50:39 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-50b2a1f123fso36277881cf.0 for ; Tue, 24 Mar 2026 06:50:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774360238; x=1774965038; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=1DKfsPVlgxtOA6J/xo55HFoYXQ/cUtB7i3T3emkwyDg=; b=D76dGWBexDf5Mow3jFsCIY3P+hCdeDeW74aSwLJcFh9wc5bGatPrZdBwzy0UDGSD8x gK1BgLY0JpximFVcNQWmq2RPlhrrwicWGt8Z8IbLTrMW0tjSx5cjaacAe60cUe3hhP7h jXSi6yNn4OSbdcpZ5Ix26o39LeNkmruarxHkuB7Lb5TbWz4NHXifWUzDcCy/tyQuVkdN 0cODBQFWl+Mw03gSeCo+G8MUZTqqagkjGv7d631b5wiV+um1PevI6Cd3mXIM8kdKmHjd YF9V/6YLGWG1dDu/rUMmSTez+Zc79WCGQKqQeZzq09ZEzvSlGpQ6nWjmihxLM/0cC5eP hZAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774360238; x=1774965038; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1DKfsPVlgxtOA6J/xo55HFoYXQ/cUtB7i3T3emkwyDg=; b=UdNCXH734LeELkEowHXEYA6GME5KZ6By6rKBartyekea8cSNEmKoV3pdX8fsuo7cUq YeUn5Ek8mrlsWnUXXhgtGJCOfrv3JKqtfsCup2jwoJ5KDu9C9mV240dWFg2lopfbO8F4 oxk6v9wiInt/SzzFwT5sh3IQFRoCLWX8Gr4754UenFLCAlJc8WIrR2dqzo5R6t1WGDsk vtLGcH3pMqo3B7UFi2ADAafppq4SH1RN/RBxAIJprurtMbHeiv7HINjVCuntPY/zXBve fZscSP3JvWH0gOM7czGN0Ncs5BjgEGFeUIPlDUJJRIAtYVry60kV+MKo6VJpS56z1Pwl M7mg== X-Forwarded-Encrypted: i=1; AJvYcCV9oQs5TjKh30z9DE/5rKAVv0WwZYbBDhYgaPOmfH5YD9zTRYHh9+e8lqlUZkM3J4IwofO23xLjUgrjZfs=@vger.kernel.org X-Gm-Message-State: AOJu0Yyc9ZC+iPIcGPw3gIqm84FcTl2sFzk3l+IGGldOAThST6aF8w1H PPddEr6e9298bx7dG0yAmtnQIqL4MRBr9yjyJXt+UJ0+ir42q0Ao61UgfyD7ltCzzbL7O7SnlLo 1ccyg7C8hWG9hlhhCRq2R8+i0TjaX23y4W/cEtBDGg1q4XZ0y5UG24jGCLtRTNHPbZm4= X-Gm-Gg: ATEYQzyFpZ3zcuFoLnXDVMLF+fhskRvAklz27I4AukRRZyukGJkxOhUVNnpXhHh4H+B GgMnLoVN9d47a9K32wShBi7LuAIHEWsmGSIInaUu/C2XXeJDdTS0xZVlHbJFYCTUQhMGaf4eyf6 9/OUhhPtefkEgeqYW/qXVQ9FwD76HHB95Y6qPlnxegiOkhswX1Wdc4B+W1wyPztp/kP4x1SUHnP sV6xfS9XHBDxszfv2OnLMhbdjnxiT1pGnSur6ShPjrJWH2KdLzbEZf3/8tioaTJiIrXYrBhtwQ4 uY9KrN9EcNQF5P8ByRKUdT9DAH6r5xIxopCRLbhfMVbEfV7eRsI2ipn3Q7mfENrrCEhrXf1UNDk Pnw0ucJhQQyfl0w6xYgci2Q2x1a1oPT1N7FcMOwFbzeWszyMgp00bc8tRXiG0RdMPm07vywW3hr DOFC0= X-Received: by 2002:a05:622a:a18:b0:509:882:9e7b with SMTP id d75a77b69052e-50b37606f0cmr190864011cf.8.1774360238399; Tue, 24 Mar 2026 06:50:38 -0700 (PDT) X-Received: by 2002:a05:622a:a18:b0:509:882:9e7b with SMTP id d75a77b69052e-50b37606f0cmr190863581cf.8.1774360237885; Tue, 24 Mar 2026 06:50:37 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-668cf4f89fesm4782268a12.4.2026.03.24.06.50.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Mar 2026 06:50:36 -0700 (PDT) Message-ID: <36bbe3c6-e83d-48be-8a9c-9cbc5b26e064@oss.qualcomm.com> Date: Tue, 24 Mar 2026 14:50:34 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] clk: qcom: gcc-x1e80100: Keep GCC USB QTB clock always ON To: Bjorn Andersson , Jagadeesh Kona Cc: Dmitry Baryshkov , Michael Turquette , Stephen Boyd , Ajit Pandey , Imran Shaik , Taniya Das , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260316-hamoa-usb-qtb-clk-always-on-v1-1-a29ac94f20f5@oss.qualcomm.com> <388c4c45-2338-4520-abf6-6a15aeb5db42@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=GIIF0+NK c=1 sm=1 tr=0 ts=69c296af cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=NIEm_JVVVNGBJfZDzK4A:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI0MDEwOSBTYWx0ZWRfX/Rvbvvpvc6AC H2uviKjvSZSDd2Gn84+Y5eVqg7A0zxkyDo7FUnrPEz7gbfuy0BoB9Z9d0F8PD9ZhqrmRzayXeQB piAHgeSukuF279q43hvWZR0CeTiTV6dlZTK6am7h5e+L6e6uUehUvg+J4+saTI67ar6b0EPiEWD 18aNt2WLfvSsEOxO8pa2iSPeFAD76Ott65VXevutz/jhMIoC6bJnlyuwuOVT3RUpO6mieVsJDgb cv149D9rYoTGelANlnc8UyDHz34gF8Y1xBwHPKcZGDuSXUae+RKplJ35r6x8KH6IUEO7RyWBbf3 V1rkOTl56BSZ0ed1IFMQz+eoxlIcI0wNPAuwltO51D2RgcnsMtzj3oEFZ5kJVvC+6+eMoCFC4Nj rINLjsRLR8Wehl49s4ruQcVPO0zdiTX5//UfmVhJxHTBrDpWdAtXHFdw2zuOu8fLcgmGsK+WFAq JFxh49jDBfC5O0yDVSg== X-Proofpoint-GUID: AXFW_I7gE1ZjCkw8GCIAkmcxJ_O_elsO X-Proofpoint-ORIG-GUID: AXFW_I7gE1ZjCkw8GCIAkmcxJ_O_elsO X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-24_03,2026-03-23_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 malwarescore=0 priorityscore=1501 phishscore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 suspectscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603240109 On 3/24/26 3:33 AM, Bjorn Andersson wrote: > On Mon, Mar 23, 2026 at 10:26:53AM +0530, Jagadeesh Kona wrote: >> >> >> On 3/16/2026 6:26 PM, Dmitry Baryshkov wrote: >>> On Mon, Mar 16, 2026 at 04:38:21PM +0530, Jagadeesh Kona wrote: >>>> Keep GCC USB QTB clock always ON which is required for SMMU >>>> invalidation on X1E80100 platform. >>>> >>>> Signed-off-by: Jagadeesh Kona >>>> --- >>>> drivers/clk/qcom/gcc-x1e80100.c | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/drivers/clk/qcom/gcc-x1e80100.c b/drivers/clk/qcom/gcc-x1e80100.c >>>> index 74afd12c158c01c121d9aecd56e65c0c302d7cd0..73a2a5112623e5190f41129af7fd76a86603557b 100644 >>>> --- a/drivers/clk/qcom/gcc-x1e80100.c >>>> +++ b/drivers/clk/qcom/gcc-x1e80100.c >>>> @@ -7480,6 +7480,7 @@ static int gcc_x1e80100_probe(struct platform_device *pdev) >>>> qcom_branch_set_clk_en(regmap, 0x32004); /* GCC_VIDEO_AHB_CLK */ >>>> qcom_branch_set_clk_en(regmap, 0x32030); /* GCC_VIDEO_XO_CLK */ >>>> qcom_branch_set_clk_en(regmap, 0x71004); /* GCC_GPU_CFG_AHB_CLK */ >>>> + qcom_branch_set_clk_en(regmap, 0x7d01c); /* GCC_HLOS1_VOTE_AGGRE_NOC_MMU_USB_QTB_CLK */ >>> >>> Is it used during all SMMU invalidations or only for those related to >>> the USB controller? >>> >> >> Yes, it is required for all SMMU invalidations. > > What happens if it's not enabled? Board goes kaboom if you suspend the system with the flattened USB node (why only with the flattened one? I would assume that moving the iommus property makes a difference) > Why isn't problem described in the > commit message? That would be good.. > > If it is _required_, wouldn't that imply that this fixes a problem, and > if so, why isn't there a Fixes: tag? Certainly Konrad