From: Florian Fainelli <florian.fainelli@broadcom.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Andrew Lunn" <andrew@lunn.ch>,
"Heiner Kallweit" <hkallweit1@gmail.com>
Cc: Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 02/19] net: mdio: bcm-iproc: Convert to platform remove callback returning void
Date: Mon, 18 Sep 2023 13:09:26 -0700 [thread overview]
Message-ID: <36bbe6a0-be3b-c36f-c292-249ca017fe69@broadcom.com> (raw)
In-Reply-To: <20230918195102.1302746-3-u.kleine-koenig@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 870 bytes --]
On 9/18/23 12:50, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new() which already returns void. Eventually after all drivers
> are converted, .remove_new() is renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
--
Florian
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4221 bytes --]
next prev parent reply other threads:[~2023-09-18 20:09 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-18 19:50 [PATCH net-next 00/19] net: mdio: " Uwe Kleine-König
2023-09-18 19:50 ` [PATCH net-next 01/19] net: mdio: aspeed: " Uwe Kleine-König
2023-09-18 19:50 ` [PATCH net-next 02/19] net: mdio: bcm-iproc: " Uwe Kleine-König
2023-09-18 20:09 ` Florian Fainelli [this message]
2023-09-18 19:50 ` [PATCH net-next 03/19] net: mdio: bcm-unimac: " Uwe Kleine-König
2023-09-18 20:09 ` Florian Fainelli
2023-09-18 19:50 ` [PATCH net-next 04/19] net: mdio: gpio: " Uwe Kleine-König
2023-09-18 19:50 ` [PATCH net-next 05/19] net: mdio: hisi-femac: " Uwe Kleine-König
2023-09-18 19:50 ` [PATCH net-next 06/19] net: mdio: ipq4019: " Uwe Kleine-König
2023-09-18 19:50 ` [PATCH net-next 07/19] net: mdio: ipq8064: " Uwe Kleine-König
2023-09-18 19:50 ` [PATCH net-next 08/19] net: mdio: moxart: " Uwe Kleine-König
2023-09-18 19:50 ` [PATCH net-next 09/19] net: mdio: mscc-miim: " Uwe Kleine-König
2023-09-18 19:50 ` [PATCH net-next 10/19] net: mdio: mux-bcm-iproc: " Uwe Kleine-König
2023-09-18 20:09 ` Florian Fainelli
2023-09-18 19:50 ` [PATCH net-next 11/19] net: mdio: mux-bcm6368: " Uwe Kleine-König
2023-09-18 19:50 ` [PATCH net-next 12/19] net: mdio: mux-gpio: " Uwe Kleine-König
2023-09-18 19:50 ` [PATCH net-next 13/19] net: mdio: mux-meson-g12a: " Uwe Kleine-König
2023-09-18 19:50 ` [PATCH net-next 14/19] net: mdio: mux-meson-gxl: " Uwe Kleine-König
2023-09-18 19:50 ` [PATCH net-next 15/19] net: mdio: mux-mmioreg: " Uwe Kleine-König
2023-09-18 19:50 ` [PATCH net-next 16/19] net: mdio: mux-multiplexer: " Uwe Kleine-König
2023-09-18 19:51 ` [PATCH net-next 17/19] net: mdio: octeon: " Uwe Kleine-König
2023-09-18 19:51 ` [PATCH net-next 18/19] net: mdio: sun4i: " Uwe Kleine-König
2023-09-19 17:22 ` Jernej Škrabec
2023-09-18 19:51 ` [PATCH net-next 19/19] net: mdio: xgene: " Uwe Kleine-König
2023-09-21 15:04 ` [PATCH net-next 00/19] net: mdio: " Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36bbe6a0-be3b-c36f-c292-249ca017fe69@broadcom.com \
--to=florian.fainelli@broadcom.com \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome