mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tuo Li <islituo@gmail.com>
To: aelior@marvell.com, GR-everest-linux-l2@marvell.com,
	davem@davemloft.net, kuba@kernel.org
Cc: netdev@vger.kernel.org,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	"baijiaju1990@gmail.com" <baijiaju1990@gmail.com>
Subject: [BUG] net: qed: possible null-pointer dereference in qed_rdma_create_qp()
Date: Wed, 11 Aug 2021 11:29:47 +0800	[thread overview]
Message-ID: <36bc2872-5b1f-ca1f-86c3-1a13cadcad2c@gmail.com> (raw)

Hello,

Our static analysis tool finds a possible null-pointer dereference in 
qed_rdma.c in Linux 5.14.0-rc3:

The variable rdma_cxt is assigned to p_hwfn, and rdma_cxt is checked in:
1286:    if (!rdma_cxt || !in_params || !out_params || 
!p_hwfn->p_rdma_info->active)

This indicates that both rdma_cxt and p_hwfn can be NULL. If so, a 
null-pointer dereference will occur:
1288:    DP_ERR(p_hwfn->cdev, ...);

I am not quite sure whether this possible null-pointer dereference is 
real and how to fix it if it is real.
Any feedback would be appreciated, thanks!

Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>

Best wishes,
Tuo Li

             reply	other threads:[~2021-08-11  3:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-11  3:29 Tuo Li [this message]
2021-08-11  9:44 Shai Malin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=36bc2872-5b1f-ca1f-86c3-1a13cadcad2c@gmail.com \
    --to=islituo@gmail.com \
    --cc=GR-everest-linux-l2@marvell.com \
    --cc=aelior@marvell.com \
    --cc=baijiaju1990@gmail.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®