From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 314A62F56 for ; Wed, 6 Aug 2025 02:31:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.187 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754447518; cv=none; b=X0jSa92onZcGCfQJE0G1OlOWPBZHYY9BlY8fBJTfrXz8J3pfcfS/UwD3/e09SGifLbT0+rnKBfxy3BlWUWzUu8DoLq4XiaUyeeXKD2T+x2qPTw4sI3K013RjOEVtuqfzPlum42ur9FR0Eaq/Dr4e41/krHHqHGOOqfa22nEVEDk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754447518; c=relaxed/simple; bh=2RTUAeTKmcQfuCegpbfhDHWI/muhKo8tFLXj212Bs4g=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=fwAPy2i4gA72ZHUx/5Pkytw+VNbNd/vzBAimg5saNeufZBDx4RlqEFoDdr4QLokkyTIG3veNpiA/DE8+7hGeX3kOhN8aCel88OZCf8TUudipHAMcBZjpfrR7eJvNMyqPVoUHOVNPaQ43tNucrLUV38KPpgjsm1Ge3mm5P0Y4ZnA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.187 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.88.194]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4bxZ3V1z9wz13N1Z; Wed, 6 Aug 2025 10:28:38 +0800 (CST) Received: from dggpemf500011.china.huawei.com (unknown [7.185.36.131]) by mail.maildlp.com (Postfix) with ESMTPS id 0C3F3140146; Wed, 6 Aug 2025 10:31:53 +0800 (CST) Received: from [10.67.109.254] (10.67.109.254) by dggpemf500011.china.huawei.com (7.185.36.131) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Wed, 6 Aug 2025 10:31:51 +0800 Message-ID: <36bd2bb2-31c8-e38f-e420-407742ccc3cc@huawei.com> Date: Wed, 6 Aug 2025 10:31:34 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH -next v7 1/7] arm64: ptrace: Replace interrupts_enabled() with regs_irqs_disabled() Content-Language: en-US To: Ada Couprie Diaz CC: , , , , , , , , , , , , , , , , , , References: <20250729015456.3411143-1-ruanjinjie@huawei.com> <20250729015456.3411143-2-ruanjinjie@huawei.com> From: Jinjie Ruan In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: kwepems500002.china.huawei.com (7.221.188.17) To dggpemf500011.china.huawei.com (7.185.36.131) On 2025/8/5 23:05, Ada Couprie Diaz wrote: > On 29/07/2025 02:54, Jinjie Ruan wrote: > >> The generic entry code expects architecture code to provide >> regs_irqs_disabled(regs) function, but arm64 does not have this and >> provides inerrupts_enabled(regs), which has the opposite polarity. > Nit: "interrupts_enabled(regs)" Good catch! thank you for the review. >> In preparation for moving arm64 over to the generic entry code, >> relace arm64's interrupts_enabled() with regs_irqs_disabled() and >> update its callers under arch/arm64. >> >> For the moment, a definition of interrupts_enabled() is provided for >> the GICv3 driver. Once arch/arm implement regs_irqs_disabled(), this >> can be removed. >> >> Delete the fast_interrupts_enabled() macro as it is unused and we >> don't want any new users to show up. >> >> No functional changes. >> >> Acked-by: Mark Rutland >> Suggested-by: Mark Rutland >> Signed-off-by: Jinjie Ruan >> --- > Otherwise looks good to me ! > Reviewed-by: Ada Couprie Diaz >