From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 36A092652A2 for ; Tue, 18 Nov 2025 01:57:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.15 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763431066; cv=none; b=soEwhjIjYQSF0KIo83hWI5gC09NrJ724tjZBBmU4itwm1dgam2+4igg5YLPMzz8lV1ObfcQ9xqT07a9fQYhe7ez19/bIymAgeKgvGjADjY2RxDqDkJ5511xDrK7Gi3HtyuttD/3J3sfnTutxFKVihtIJhXBjjJkJtkBC6wHibyk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763431066; c=relaxed/simple; bh=DpFVic7YWH0BlyrxXOW+sZkVF+M4c4M+n6n4Zsdt30A=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lLWBfFdBNSq5ylyY3ja0oMzw5yKRe1cCMlnvTjV6OzuNRPzUP8/QZoNZsPwindS86uR/fWmNQUXs38YPDAjiIWGhktgzH7A3QLju1g5/KKgZb6W6qjCjEFRUnc4sKvu1HNvKfiOomF5LJsWEbIOEt1wV96Vg3S6oBZhnvOo4xms= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=PqJqQSjb; arc=none smtp.client-ip=198.175.65.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="PqJqQSjb" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1763431065; x=1794967065; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=DpFVic7YWH0BlyrxXOW+sZkVF+M4c4M+n6n4Zsdt30A=; b=PqJqQSjbmV569OagjQ47FRzz/S2HniVKChkWloIpHQIZscjICUDh7NOS uC6WGJdmyHXI+DdVVW6QKeGWgiZ5lldNYzPgIbiE2jaNVWjt+Bwt/Ynry EsT2D518IDRZlDZiH3xe58/ylfo1VCXtp5X/ynd+buC2DYUf/Qt/hieEw ROaJWgujFr9OB1gXpRIF+Ofakks1rT6YFqHZghOuAScnnWEnB+U3pTeaV cyIURhTxpK/sbSvYrPqq+6+5+Vr0N7IYxQBN6kHjAju0HnfPLH+nWOFQD 9AA9FHVR9BjcCraTm7vPRg2F1mElcUu9EqnCl4MuavMFDLA/hnSx4lt0T g==; X-CSE-ConnectionGUID: +YfPcJy4Rs+WTzzYt3jCmA== X-CSE-MsgGUID: g9Rt6pPMSIeSg8zI+Mal6Q== X-IronPort-AV: E=McAfee;i="6800,10657,11616"; a="69063085" X-IronPort-AV: E=Sophos;i="6.19,313,1754982000"; d="scan'208";a="69063085" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2025 17:57:44 -0800 X-CSE-ConnectionGUID: jIA0VwtlQ3KMU8Dpvzdhrg== X-CSE-MsgGUID: N/78ki0ASgW9u23TTCj00A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.19,313,1754982000"; d="scan'208";a="190288095" Received: from allen-sbox.sh.intel.com (HELO [10.239.159.30]) ([10.239.159.30]) by fmviesa007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2025 17:57:39 -0800 Message-ID: <36cd3953-80fe-4605-ad2d-881440f92f3c@linux.intel.com> Date: Tue, 18 Nov 2025 09:53:26 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] iommu/vt-d: Fix unused invalidation hint in qi_desc_iotlb To: Aashish Sharma , Vineeth Pillai , Dmytro Maluka , David Woodhouse , Joerg Roedel , Tina Zhang Cc: Robin Murphy , iommu@lists.linux.dev, linux-kernel@vger.kernel.org, Aashish Sharma References: <20251009010903.1323979-1-aashish@aashishsharma.net> Content-Language: en-US From: Baolu Lu In-Reply-To: <20251009010903.1323979-1-aashish@aashishsharma.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/9/25 09:09, Aashish Sharma wrote: > Invalidation hint (ih) in the function 'qi_desc_iotlb' is > initialized to zero and never used. It is embedded in the 0th bit > of the 'addr' parameter. Get the correct 'ih' value from there. > > Fixes: f701c9f36bcb ("iommu/vt-d: Factor out invalidation descriptor composition") > Signed-off-by: Aashish Sharma > --- > drivers/iommu/intel/iommu.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Queued for v6.19-rc1. Thanks!