From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f180.google.com (mail-oi1-f180.google.com [209.85.167.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CEEB63921E0 for ; Sat, 1 Aug 2026 14:49:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785595781; cv=none; b=b6d2ut4EeVapdbObRo1eTw9VifIoHBt8QmSGDzzksSPVUzmoqbU0cdJ8bnL2SnoyRcviE26cKEBxlkAZvS+uJormDGvFC+bDASfBTJUIdmJhQPnpH301UXvtN4QIi4lGWqx6m47e16V94uudOfOGJHJDWXhul0QbnjdLC+P7SnA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785595781; c=relaxed/simple; bh=28Y+sWkH9P3E/k3LwvQBJI9J+bYooDRpslXmWz9AndU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=K/6aek5kqx4G0qh99dqHY1fRIbwdjh38j3JV9naKRtDjr3rE+izpzQJoViSjck/tIVdgbOzbpPVQTi2pIwfNkUAcFrz+s6lKrRp5fBeY0bw2A+eH3BO/493ux9FldTtnteILvmlZT24Ie/PDdTvB4DKFqVnmPv88XvkqlDUqEtY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=DiF1QBFI; arc=none smtp.client-ip=209.85.167.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="DiF1QBFI" Received: by mail-oi1-f180.google.com with SMTP id 5614622812f47-497d6c2d000so1151995b6e.0 for ; Sat, 01 Aug 2026 07:49:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1785595777; x=1786200577; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=MMZw+Q+C27X+NpDBF0JL+cOPjhTz7PFEJuuJRyBNMQw=; b=DiF1QBFI7u65suCEcA1RHz+bv5OsGO/IRZY/EANBp/QOKo9nMr4ScIBU4ClqKYz4a6 9Uqx3xeRjccR9NWsX4VzJvzqcMPUbMbb2qfM3SDfQs0I8AGileefiawI6DuAHmS07A4/ noEzuHXUqANnq+wy6BV4JHS0UcdEv7eZKB5rCY80M5daGVKGMIzunC1iOaof91daShKe QKaHPweltilhH0gltM7r+gFkTdZ2r/ItaAVFO77oVLNalB53EN4b04sppuvoB59Q/wKK 8pW/B+Hx90fe1kYviIw8a53eVRtVQyuKMENsCKrq0Qfx85BEL/04/n7lz/3hXOhVUthF oEng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785595777; x=1786200577; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=MMZw+Q+C27X+NpDBF0JL+cOPjhTz7PFEJuuJRyBNMQw=; b=mhHeTMabYuig0aWfYkxnsZqM901j4+Cu6iC0Zyh/rYtbVTDG4Kr9aUohmkGV2WpJh4 GhycxVIF93MhIsNw4uXQLnjiOQoACg6GZDB8D3q8FfuVC/+UYJdxignOX4iFpuvtKab+ isSPybXBtrevd+kHEhoDT8cKETs69YBwAxz25h9RHJ554CbJ2YvhSfgQg/w42EfUL7GH pf4YpgUN72FofoPXU5GK/FeNdpvwScAZzznOw+42cGUNHbXh6nHBKgeHWnL7YFdfbnu8 ydF1dYPCM8kscyx/U1V//JHtvK6mjBQmrj+zJDR3wvMO2Qc9JUNjhiN4ytks7u7kIZBY 647w== X-Forwarded-Encrypted: i=1; AHgh+Rqi/Xiw1QFp+o5ddzC5m4SuD8QCLkazqRUbXne3HtpQU1PbLSDolTJSDl7VIx7WsbAfgXkB9UWRKEq3b5A=@vger.kernel.org X-Gm-Message-State: AOJu0YxulJtSAkTWjDlSgF5MCwtQUaiqt2bDnOLOFc8O8XhTB744uHVL 9KXl1K7AAczAfCuEReLH+5mIF5Jip/y8g8QlheKSuQVUFrjYOWVxnkxzmDqSE9YaWm2EaUH6Fj9 qA3NMwp0= X-Gm-Gg: AR+sD1397GcVTFatZMM3Zi98YYI9zYJhCADeonGC0nu8N3V+u5Cm1iO8WK3QCxDAlpx 0lX5rZk8dGrPxybjpMmn/LQ0B6L+WXCe+W5qc/GKmkOl2drKkWpAba29DDtIj8zq8XHlPbUa2PG hhAJfV6+D2Wmi3hgPVYIp8+xEK2Xeyr9uv4baGZf5Q8HP2EUYvqSXNYKJWs/bxA6QcvcUUhMivd Uj7TwVQMdw6IFUNSDGqIyAekKXywACiksVvaTsca0BfmF1DanEvBaleo5JHCeNzpkkext0yL6zp i9zOBRoao2hyaOIv2WXChv5nZRsqzL0CtmEOeXLCCe0BlDWFMKEBecSBfSGwPjJhNvs9TmXM/2y wqUtUn6apve4CI3vkp/kw95PFWX1X6q6fh2sNWLa5AkIpPyEbDQcnS8Zsce9HcV53Z8/euuVwhX uV4/NBpx7YeAlrDdrINFfCF/0Inq9+Ht1tgWLPNGjpTlhDK7D4NXa38Kq2oGBE/uO7mKzbv0XTc 3mzl/8dN1xhcMvbRlPEknOHtFtq4Cx48yzLD0E= X-Received: by 2002:a05:6808:d46:b0:4a4:a930:1f76 with SMTP id 5614622812f47-4af5e20b693mr6486505b6e.11.1785595777592; Sat, 01 Aug 2026 07:49:37 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:359b:17f1:d4f9:4949? ([2600:8803:e7e4:500:359b:17f1:d4f9:4949]) by smtp.gmail.com with ESMTPSA id 5614622812f47-4af58e9568asm2968074b6e.9.2026.08.01.07.49.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 01 Aug 2026 07:49:35 -0700 (PDT) Message-ID: <36ce2fd3-9a98-4212-8de3-c17fc368b196@baylibre.com> Date: Sat, 1 Aug 2026 09:49:33 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/3] iio: adc: bcm_iproc_adc: Introduce local device pointer To: mdshahid03@gmail.com, Jonathan Cameron , Andy Shevchenko Cc: Joshua Crofts , Broadcom internal kernel list , linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?Q?Nuno_S=C3=A1?= , Ray Jui , Scott Branden References: <20260801090953.61603-1-mdshahid03@gmail.com> <20260801090953.61603-3-mdshahid03@gmail.com> Content-Language: en-US From: David Lechner In-Reply-To: <20260801090953.61603-3-mdshahid03@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 8/1/26 4:09 AM, mdshahid03@gmail.com wrote: > From: Mohammad Shahid > > Introduce a local 'struct device *dev' variable in iproc_adc_probe() > and use it instead of repeatedly referencing '&pdev->dev'. > > This simplifies the code and makes subsequent error handling changes > less verbose. > > No functional change intended. > > Signed-off-by: Mohammad Shahid > --- > drivers/iio/adc/bcm_iproc_adc.c | 17 +++++++++-------- > 1 file changed, 9 insertions(+), 8 deletions(-) > > diff --git a/drivers/iio/adc/bcm_iproc_adc.c b/drivers/iio/adc/bcm_iproc_adc.c > index 7c2e2770cd61..4acd9c3f089b 100644 > --- a/drivers/iio/adc/bcm_iproc_adc.c > +++ b/drivers/iio/adc/bcm_iproc_adc.c > @@ -506,9 +506,10 @@ static int iproc_adc_probe(struct platform_device *pdev) > { > struct iproc_adc_priv *adc_priv; > struct iio_dev *indio_dev = NULL; > + struct device *dev = &pdev->dev; > int ret; > > - indio_dev = devm_iio_device_alloc(&pdev->dev, > + indio_dev = devm_iio_device_alloc(dev, > sizeof(*adc_priv)); > if (!indio_dev) > return -ENOMEM; > @@ -523,14 +524,14 @@ static int iproc_adc_probe(struct platform_device *pdev) > adc_priv->regmap = syscon_regmap_lookup_by_phandle(pdev->dev.of_node, > "adc-syscon"); > if (IS_ERR(adc_priv->regmap)) { > - dev_err(&pdev->dev, "failed to get handle for tsc syscon\n"); > + dev_err(dev, "failed to get handle for tsc syscon\n"); > ret = PTR_ERR(adc_priv->regmap); > return ret; > } > > - adc_priv->adc_clk = devm_clk_get(&pdev->dev, "tsc_clk"); > + adc_priv->adc_clk = devm_clk_get(dev, "tsc_clk"); > if (IS_ERR(adc_priv->adc_clk)) { > - dev_err(&pdev->dev, > + dev_err(dev, > "failed getting clock tsc_clk\n"); > ret = PTR_ERR(adc_priv->adc_clk); > return ret; I imagine some, if not all, of these will fit on one line now without going over 80 chars.