From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 232CE42DA26 for ; Mon, 20 Jul 2026 14:31:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784557863; cv=none; b=DeaMrhoT3LETuaI8GNndyh7nDWHqcwFSQccqOxoLFafQRJ4BqDIi1WWDBoFh5XaTzA/tjFP6XMcibg/dP0AYm3mS2cm2+DDlTtpSK2vHTlIWvWMbiFQeZ6vH8OSk3yLohzfbm9/hWFX715E5XbW0I6aT7RlXL9c/5b6Xr2u5f9U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784557863; c=relaxed/simple; bh=vbhllwkJKS2kil/R5LTnvXYoP33iPPfzuqtzbUnjeiM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WeDD5LqMNj1Uxhca6J6tSGSWBTTHtNavCWyTvNr1daJ/UEz/yez1+btU1g1PWwYjwbrOdSt0mMaiIG+5dkLHMj1Wp06YdewCGiRqqY9JvEH+hPgNv4sBQwog6Z/CQlJKVbSrTl1MKN1IAcKXa8M+s2Zoz4QiGWUlAxf/xNurWkE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=P7VTQNBX; arc=none smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="P7VTQNBX" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-38e08baf860so7749324a91.2 for ; Mon, 20 Jul 2026 07:31:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784557861; x=1785162661; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:sender:from:to:cc :subject:date:message-id:reply-to:content-type; bh=mDXO9+srSRe7fkjvMx55IDU4MpBVZEizdIVmw+G2XFQ=; b=P7VTQNBXQyeLgaI6OHgytlQSYans8ONksDe4aYzds97pFJy8VBRjO6AqFSIlu7sT+l JS1ZtK16khxDspN3vl5KFiAolFoGb0il4e3enszZtldo0kumY30jaf5dYLhwLRRidQbp FrrwwDTOMHg9gmB8iVkQVbppbvhJXa5w6UdzafxNdzq2jixLguKqUKPdRrfomk5gfHt4 +808auzjARQX3GR2azvDnwul6WC61ZmOtavqf9P0+1orJGdJufUDC26TXAOIuRS8eqyG y2UF0Hf/1uDM91mlc3U4DxT03Co6tm6ueeDTvT+Xg4Ore1hURAIzwdWWzWXt62csHtg7 qQ+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784557861; x=1785162661; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:sender:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=mDXO9+srSRe7fkjvMx55IDU4MpBVZEizdIVmw+G2XFQ=; b=HKIwwFqde8veBiThmUuDRdsSu6MS7GPjmlcdcA8soSn0KEH+E6Q8Z485X2Zs9TUmzw qsapgIAUwBIlLxrQ/Bioc8QiN/iGalM06eKpvGlgtBaWDmj+ibNY6TLWCJMcLqjVk1ZH QoStTmk4uHpb1cia7X8fyqFcZl7qRuPZQ5Ixv3mGCUtuOu1mpzz81bh7cO3ujZzynSyB trVhdqLf2oI/AgnZkeiBaTaWI2ov3J3w+VeQj2IuTQdj1cQXBg1nNUCdXdIseUn1A7Hb wuzqIQPuNpypA0vfU4CV/hyfIxOU6155/CW9lUBxFVOmLodR/EJ77xlBr5yz+0bcLXgh OHFQ== X-Forwarded-Encrypted: i=1; AHgh+Rp8S21pk//nJRU2uTTXoOJpGWmab5zWv1dj7b6gQiNorSRlombklrOvoQ/8x5ljZCN/Wupu2WMH7HOgjHQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyyKL8K01LTYoNLBIL2gS3+or2/3YCcjjal20UKCZqYPBzVeI4v OMlloJuq56gANV/D5ojuTFyp5w13Ze/2KB+jhhviUQEQ+BAdWpFoGd/K X-Gm-Gg: AR+sD128p0ZT6VYcWkZN6F3R7+6+ztXM9Pa93ISIJeE+sBgg2h/JWvR2MelrXyHLeV2 7begIXFWVMBmwD3V6DzBvY9+BBeauUXoPkPNmQS8K6+Gs8r/3ROVe9/aa0DnmAHEXPdzoQlLsrE LDBLBhJEm7EVAc0orWcRgO7P7dVEJhblWlJvedHJ1aEX00RVmYLumGXCnkYnlVx823pU+xsD3vl uA07avQrgfRj0C2jeN7BX25aOCQ2AZ/hE0vhL7Wuik21XnQfllArTo90qH/puzNjFkXHoUEZMOq 67JYUJ18ARdT8YMX1dqIAF0X33anoQ74oXqozlMChr96TPGTixJ9j+5X5glaFsWydjKCuN8YFs8 NPJPXv4yXa0iY0JNeN+7+eq5g5S+WaoMY58PqUBOgt0ipiUAe8qpTq9dNnrGwUqKNdUcc2YUvJI GkP0LwWWZm7z0cC70= X-Received: by 2002:a17:90b:58cb:b0:381:5bd6:eb19 with SMTP id 98e67ed59e1d1-38e4b47765dmr14796190a91.18.1784557861277; Mon, 20 Jul 2026 07:31:01 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13ce2cbb69bsm27542922c88.11.2026.07.20.07.31.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 07:31:00 -0700 (PDT) Sender: Guenter Roeck Date: Mon, 20 Jul 2026 07:30:59 -0700 From: Guenter Roeck To: Pengpeng Hou Cc: Sanman Pradhan , Arnd Bergmann , Runyu Xiao , linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] hwmon: occ: validate poll response sensor blocks Message-ID: <36ce8f76-4bc1-481f-a5f1-e9335fc66af3@roeck-us.net> References: <20260720115826.14813-1-pengpeng@iscas.ac.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260720115826.14813-1-pengpeng@iscas.ac.cn> On Mon, Jul 20, 2026 at 07:58:26PM +0800, Pengpeng Hou wrote: > The OCC poll response parser walks a counted list of sensor data blocks. > It used the static backing-array capacity as the parse boundary, but a > transport response makes only data_length bytes current and valid. A > truncated response can therefore make the parser consume a block header or > block extent outside the current response. > > Use data_length as the parent boundary, prove the fixed poll header and > each current block header before reading them, and prove the complete block > before advancing. Keep parsed sensor metadata local until the complete > response has passed validation, then publish it. Propagate > malformed-response errors before publishing the OCC as active. > > Fixes: aa195fe49b03 ("hwmon (occ): Parse OCC poll response") > Signed-off-by: Pengpeng Hou The issues reported by Sashiko are pre-existing issues worth looking into, but not as part of this patch. Applied. Thanks, Guenter