From mboxrd@z Thu Jan  1 00:00:00 1970
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752215AbeAPODg (ORCPT <rfc822;ralf@linux-mips.org> + 1 other);
        Tue, 16 Jan 2018 09:03:36 -0500
Received: from lelnx193.ext.ti.com ([198.47.27.77]:46609 "EHLO
        lelnx193.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752188AbeAPODe (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 16 Jan 2018 09:03:34 -0500
Subject: Re: [PATCH] ARM: davinci_all_defconfig: set CONFIG_DAVINCI_WATCHDOG=y
To: Adam Ford <aford173@gmail.com>
CC: David Lechner <david@lechnology.com>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>
References: <1516037371-3932-1-git-send-email-david@lechnology.com>
 <800a4c95-ca8d-6235-288a-222a38c04cf9@ti.com>
 <CAHCN7xLwpLJPOe27sfKKbsSq3C75ZVtV9B0hpp3KDtAnxpc1mA@mail.gmail.com>
From: Sekhar Nori <nsekhar@ti.com>
Message-ID: <36d2c0a8-e723-8f5d-3d1f-71c09ead54c5@ti.com>
Date: Tue, 16 Jan 2018 19:32:34 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <CAHCN7xLwpLJPOe27sfKKbsSq3C75ZVtV9B0hpp3KDtAnxpc1mA@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>

On Tuesday 16 January 2018 05:47 PM, Adam Ford wrote:
> On Mon, Jan 15, 2018 at 11:59 PM, Sekhar Nori <nsekhar@ti.com> wrote:
>> On Monday 15 January 2018 10:59 PM, David Lechner wrote:
>>> This changes CONFIG_DAVINCI_WATCHDOG from a module to a compiled-in
>>> option. Since the reset function has been moved out of the mach code in
>>> commit 0808d3260456 ("ARM: davinci: remove watchdog reset") and into the
>>> watchdog driver, devices cannot reboot unless the watchdog driver is
>>> loaded, so make it a compiled-in option so that we can always reboot, even
>>> when modules are not loaded.
>>>
>>> Cc: Sekhar Nori <nsekhar@ti.com>
>>> Suggested-by: Adam Ford <aford173@gmail.com>
>>> Signed-off-by: David Lechner <david@lechnology.com>
>>
>> Hmm, we already depend on modules to load correctly for a lot of
>> functionality. Why should reboot be an exception? In general, unless the
>> driver is needed for loading rootfile system, I would keep it as a module.
> 
> I would argue that his patch corrects a regression introduced by the
> patch series.  Before the series, 'reboot' worked properly without the
> watchdog being loaded as a module.  With this patch series 'reboot'
> stops functioning which I would argue is a regression.  Making the
> watchdog part of the kernel fixes the broken reboot regression.  I
> would request it be accepted.

Okay, thats a convincing argument. We are going to shift to watchdog
driver for reboot only with v4.17, so will add it to my queue.

Thanks,
Sekhar