From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 621C7C77B70 for ; Fri, 14 Apr 2023 10:41:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230175AbjDNKlK (ORCPT ); Fri, 14 Apr 2023 06:41:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47700 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229793AbjDNKlH (ORCPT ); Fri, 14 Apr 2023 06:41:07 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F20FF3; Fri, 14 Apr 2023 03:41:01 -0700 (PDT) Received: from [192.168.1.90] (unknown [188.27.34.213]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by madras.collabora.co.uk (Postfix) with ESMTPSA id 0FEB26603222; Fri, 14 Apr 2023 11:40:59 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1681468859; bh=vfh35bWjaeukPfJ1DTroLll07PP0VwQUozLzA1ckpqQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Li6V/wHS/HhegSta0kxWzRHlEOSFjcQkRDODVv9z0+kKynYwrL9opHtf4hreYsCyj VHLjGoyaG1QlFRN+H3YSS/ZdnJCI6pI8+dqEe9qsWhlukkwrFQFPen5yQ7TdikUg1M 5Llpj7+1ot+gXzM3nE33sSnv5bJgjzAMnDYYFyEXf03I0BNChmtO/qJIVT/ctp8MGX 5OWce8AkA2UiWtskG2YFlK7OInKvUY14+cjPFdX3wmFBnsTPXoEIT10dxtoIC4eH3l uSPSBVEmSLGPo/2Qv+XASr4KeakEU6UhJwUInK7oUTAhIXIMUJKKqjOdcNMUcHLoy8 3fsnq4Fafo7DQ== Message-ID: <36d8050b-0636-2b30-f3fc-7f7d96bec253@collabora.com> Date: Fri, 14 Apr 2023 13:40:55 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 3/3] arm64: dts: rockchip: Add vdd_cpu_big regulators to rk3588-rock-5b Content-Language: en-US To: Krzysztof Kozlowski , Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , Christopher Obbard , Michael Riesch , Sebastian Reichel , Shreeya Patel Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@collabora.com References: <20230414093411.113787-1-cristian.ciocaltea@collabora.com> <20230414093411.113787-4-cristian.ciocaltea@collabora.com> <0cbafc31-9b46-54df-f569-810a8781743c@linaro.org> From: Cristian Ciocaltea In-Reply-To: <0cbafc31-9b46-54df-f569-810a8781743c@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/14/23 13:27, Krzysztof Kozlowski wrote: > On 14/04/2023 11:34, Cristian Ciocaltea wrote: >> The RK8602 and RK8603 voltage regulators on the Rock 5B board provide >> the power lines vdd_cpu_big0 and vdd_cpu_big1, respectively. >> >> Add the necessary device tree nodes and bind them to the corresponding >> CPU big core nodes. >> >> Signed-off-by: Cristian Ciocaltea >> --- >> .../boot/dts/rockchip/rk3588-rock-5b.dts | 56 +++++++++++++++++++ >> 1 file changed, 56 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts >> index 8cc97d146a73..3e4aee8f70c1 100644 >> --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts >> +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts >> @@ -53,6 +53,62 @@ vcc5v0_sys: vcc5v0-sys-regulator { >> }; >> }; >> >> +&cpu_b0 { >> + cpu-supply = <&vdd_cpu_big0_s0>; >> +}; >> + >> +&cpu_b1 { >> + cpu-supply = <&vdd_cpu_big0_s0>; >> +}; >> + >> +&cpu_b2 { >> + cpu-supply = <&vdd_cpu_big1_s0>; >> +}; >> + >> +&cpu_b3 { >> + cpu-supply = <&vdd_cpu_big1_s0>; >> +}; >> + >> +&i2c0 { >> + pinctrl-names = "default"; >> + pinctrl-0 = <&i2c0m2_xfer>; >> + status = "okay"; >> + >> + vdd_cpu_big0_s0: regulator@42 { >> + compatible = "rockchip,rk8602"; > > Looking at your next node, this is surprising... Double check if you > have correct compatibles everywhere. > >> + reg = <0x42>; >> + fcs,suspend-voltage-selector = <1>; > > Does not look like you tested the DTS against bindings. Please run `make > dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst > for instructions). > >> + regulator-name = "vdd_cpu_big0_s0"; >> + regulator-always-on; >> + regulator-boot-on; >> + regulator-min-microvolt = <550000>; >> + regulator-max-microvolt = <1050000>; >> + regulator-ramp-delay = <2300>; >> + vin-supply = <&vcc5v0_sys>; >> + >> + regulator-state-mem { >> + regulator-off-in-suspend; >> + }; >> + }; >> + >> + vdd_cpu_big1_s0: regulator@43 { >> + compatible = "rockchip,rk8603", "rockchip,rk8602"; >> + reg = <0x43>; >> + fcs,suspend-voltage-selector = <1>; > > Does not look like you tested the DTS against bindings. Please run `make > dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst > for instructions). I mentioned in the cover letter that the support for the RK860X regulators has been recently merged via [1]. The patches in this series have been verified on next-20230413. [1] https://lore.kernel.org/lkml/20230406194158.963352-1-cristian.ciocaltea@collabora.com/ Thanks, Cristian