From: "Li.Xiubo@freescale.com" <Li.Xiubo@freescale.com>
To: "Li.Xiubo@freescale.com" <Li.Xiubo@freescale.com>,
"broonie@kernel.org" <broonie@kernel.org>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"guangyu.chen@freescale.com" <guangyu.chen@freescale.com>,
"shawn.guo@linaro.org" <shawn.guo@linaro.org>
Cc: "perex@perex.cz" <perex@perex.cz>,
"tiwai@suse.de" <tiwai@suse.de>,
"Fabio.Estevam@freescale.com" <Fabio.Estevam@freescale.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Mark Brown <broonie@linaro.org>
Subject: RE: [PATCH 2/2] ASoC: fsl: Make Freescale SAI/ESAI/SPDIF to be visible in Kconfig
Date: Thu, 20 Feb 2014 02:06:20 +0000 [thread overview]
Message-ID: <36d9c0a870604fbe87b129e95fea9da1@BY2PR03MB505.namprd03.prod.outlook.com> (raw)
In-Reply-To: <1392086825-15737-2-git-send-email-Li.Xiubo@freescale.com>
Hi Mark,
I'm not very sure of this patch, maybe should we add one menu
in Kconfig for all visible CPU DAIs firstly like for code drivers?
Thanks,
--
Best Regards,
Xiubo
> Subject: [PATCH 2/2] ASoC: fsl: Make Freescale SAI/ESAI/SPDIF to be visible in
> Kconfig
>
> For simple card since the whole idea is to support any CODEC and
> any CPU DAI with the same driver, we should probably just make sure
> that all the individual CODEC and CPU DAI drivers can be enabled in
> Kconfig. That way we don't have to have specific Kconfig entries for
> boards and loose some of the benefit of the generic card.
>
> This will make the Freescale SAI/ESAI/SPDIF device be visible in
> Kconfig.
>
> Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
> Cc: Nicolin Chen <Guangyu.Chen@freescale.com>
> Cc: Mark Brown <broonie@linaro.org>
> ---
> sound/soc/fsl/Kconfig | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
> index d0914c0..f397144 100644
> --- a/sound/soc/fsl/Kconfig
> +++ b/sound/soc/fsl/Kconfig
> @@ -1,5 +1,5 @@
> config SND_SOC_FSL_SAI
> - tristate
> + tristate "ALSA SoC support for the Freescale SAI device"
> select REGMAP_MMIO
> select SND_SOC_GENERIC_DMAENGINE_PCM
>
> @@ -7,11 +7,11 @@ config SND_SOC_FSL_SSI
> tristate
>
> config SND_SOC_FSL_SPDIF
> - tristate
> + tristate "ALSA SoC support for the Freescale SPDIF device"
> select REGMAP_MMIO
>
> config SND_SOC_FSL_ESAI
> - tristate
> + tristate "ALSA SoC support for the Freescale ESAI device"
> select REGMAP_MMIO
>
> config SND_SOC_FSL_UTILS
> --
> 1.8.4
>
next prev parent reply other threads:[~2014-02-20 2:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-11 2:47 [PATCH 1/2] ASoC: fsl: make sure the regmap-mmio is actually enabled Xiubo Li
2014-02-11 2:47 ` [PATCH 2/2] ASoC: fsl: Make Freescale SAI/ESAI/SPDIF to be visible in Kconfig Xiubo Li
2014-02-20 2:06 ` Li.Xiubo [this message]
2014-02-20 2:44 ` Mark Brown
2014-02-20 3:07 ` Nicolin Chen
2014-03-21 6:46 ` Li.Xiubo
2014-02-20 8:44 ` Li.Xiubo
2014-02-11 11:20 ` [PATCH 1/2] ASoC: fsl: make sure the regmap-mmio is actually enabled Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36d9c0a870604fbe87b129e95fea9da1@BY2PR03MB505.namprd03.prod.outlook.com \
--to=li.xiubo@freescale.com \
--cc=Fabio.Estevam@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=broonie@linaro.org \
--cc=guangyu.chen@freescale.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=shawn.guo@linaro.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®