From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AF8BC433E6 for ; Fri, 22 Jan 2021 15:15:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0B47E23AAC for ; Fri, 22 Jan 2021 15:15:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729119AbhAVPPT (ORCPT ); Fri, 22 Jan 2021 10:15:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58914 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728796AbhAVPB3 (ORCPT ); Fri, 22 Jan 2021 10:01:29 -0500 Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D8585C061786; Fri, 22 Jan 2021 07:00:48 -0800 (PST) Received: by mail-lj1-x235.google.com with SMTP id a25so5706185ljn.0; Fri, 22 Jan 2021 07:00:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=6GrCTWs9NpgE1Px7KRrjvWHXnrcw5duvcL0Gwzimd2w=; b=Slaj1/41gm8rh3MOfTkdZwL4K/4GdtHj/pHos4/CrTfmr2lzcgkGJJq8+yaGop18bg CdhzlaU/z2dN0CKqrswH9260qc83ArCv1duN0XVhG/G84pUWb10pllTEjc6BaiLq828M ECgffjibkhV8eGXSOyTSZAhZGxDxayz636nhTxIeGm684QNnElS88LYZeAhTHV1zdjXQ GHCwWYU4T2ZbxpABAfbgIUns2dEd/yVju/YTabGaBgQC6n/rrXy94qVpp6VOS2IAMwRa vXVzn+4zcjyyDsoskufSF66gS2Z6G1V7X9UZ7fzthhA7f9eQjxfmf50fqiiAfKxIkjP+ qbnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=6GrCTWs9NpgE1Px7KRrjvWHXnrcw5duvcL0Gwzimd2w=; b=h5UkbwPLAMg7aEgEb7nDCFAbQebWVl/GP49i6J2FEMmTgLrjewfRTj1SPTStTKzIje U/Iv1V+YV4O1FYLa7+xpIUE73PBxp26lZJWCuptFsRS6HjDOguT3hgXFXH72bl4fIus1 EfRDwEOaohDdtS+5mhupKZvAfojg75l7yTakH1GqZtmPkqf58SLANF6TzLZuXjVjQW8C VmGcPvp2HZSOrWJpCUIkRxcbOebIcaXTsfLKUTTtBpVCStLrA2R5+Bz/e1dx+CkJF7ci Tk9bFRjteqKBoYWTi0NtistTNI+OrdkoiBy+XLnHhzAYxXx2Dicfl0HZrEfup5GorYbS RWxg== X-Gm-Message-State: AOAM532X2eNUBAlGj/RBX2gVyjjJBpyBGBFBtFYB0ugu5dZpwjlU9bDb sBJoryysVbbtGJU3jH+FDt1yNP5g3ts= X-Google-Smtp-Source: ABdhPJx9mKv9rqJmvUdmog+2xB5v2ILlYxLdsXX+YdCOhP2lmSIgXrd+cxPEZW+e4LMvXo6ELDZW0Q== X-Received: by 2002:a2e:97d7:: with SMTP id m23mr2446905ljj.456.1611327646209; Fri, 22 Jan 2021 07:00:46 -0800 (PST) Received: from [192.168.2.145] (109-252-192-57.dynamic.spd-mgts.ru. [109.252.192.57]) by smtp.googlemail.com with ESMTPSA id d1sm973726ljl.72.2021.01.22.07.00.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Jan 2021 07:00:45 -0800 (PST) Subject: Re: [PATCH] memory: tegra: Remove calls to dev_pm_opp_set_clkname() To: Viresh Kumar , Krzysztof Kozlowski , Thierry Reding , Jonathan Hunter Cc: Vincent Guittot , linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org References: <1430e70777fdcf1c946ca2fef296f439762a4f21.1611295029.git.viresh.kumar@linaro.org> From: Dmitry Osipenko Message-ID: <36db9831-0d68-2502-ad64-5aab05b16974@gmail.com> Date: Fri, 22 Jan 2021 18:00:44 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.2 MIME-Version: 1.0 In-Reply-To: <1430e70777fdcf1c946ca2fef296f439762a4f21.1611295029.git.viresh.kumar@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 22.01.2021 09:00, Viresh Kumar пишет: > There is no point calling dev_pm_opp_set_clkname() with the "name" > parameter set to NULL, this is already done by the OPP core at setup > time and should work as it is. > > Signed-off-by: Viresh Kumar > --- > Dmitry, am I missing something obvious here ? The dev_pm_opp_set_clkname() ensures that the OPP table has a clk assigned to the table. The _allocate_opp_table() ignores all clk_get() errors except the -EPROBE_DEFER. The opp_table->clk must be not a PTR_ERR for these memory drivers. On the other hand, the memory drivers also do the devm_clk_get() themselves, hence technically clk_get() of _allocate_opp_table() shouldn't fail. But I'll need to take a closer look at the clk core, to check whether clk_get() could fail for the implicit _allocate_opp_table(). Tegra124-emc driver also has dev_pm_opp_set_clkname(), BTW.