From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB057C433F5 for ; Fri, 3 Sep 2021 07:40:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C151D60E0B for ; Fri, 3 Sep 2021 07:40:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347991AbhICHls (ORCPT ); Fri, 3 Sep 2021 03:41:48 -0400 Received: from mga11.intel.com ([192.55.52.93]:7815 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234753AbhICHlq (ORCPT ); Fri, 3 Sep 2021 03:41:46 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10095"; a="216215452" X-IronPort-AV: E=Sophos;i="5.85,264,1624345200"; d="scan'208";a="216215452" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Sep 2021 00:40:47 -0700 X-IronPort-AV: E=Sophos;i="5.85,264,1624345200"; d="scan'208";a="533772099" Received: from xingzhen-mobl.ccr.corp.intel.com (HELO [10.238.4.90]) ([10.238.4.90]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Sep 2021 00:40:44 -0700 Subject: Re: [xfs] bad77c375e: stress-ng.fallocate.ops_per_sec -10.0% regression To: kernel test robot , Dave Chinner Cc: "Darrick J. Wong" , Chandan Babu R , Brian Foster , Allison Henderson , LKML , lkp@lists.01.org, lkp@intel.com, ying.huang@intel.com, feng.tang@intel.com References: <20210902072704.GC8267@xsang-OptiPlex-9020> From: Xing Zhengjun Message-ID: <36dc5f38-f8ec-591a-8efa-b3bd607ac06e@linux.intel.com> Date: Fri, 3 Sep 2021 15:40:39 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210902072704.GC8267@xsang-OptiPlex-9020> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dave, Do you have time to look at this? Thanks. On 9/2/2021 3:27 PM, kernel test robot wrote: > > > Greeting, > > FYI, we noticed a -10.0% regression of stress-ng.fallocate.ops_per_sec due to commit: > > > commit: bad77c375e8de6c776c848e443f7dc2d0d909be5 ("xfs: CIL checkpoint flushes caches unconditionally") > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master > > > in testcase: stress-ng > on test machine: 96 threads 2 sockets Intel(R) Xeon(R) Gold 6252 CPU @ 2.10GHz with 512G memory > with following parameters: > > nr_threads: 10% > disk: 1HDD > testtime: 60s > fs: xfs > class: filesystem > test: fallocate > cpufreq_governor: performance > ucode: 0x5003006 > > > In addition to that, the commit also has significant impact on the following tests: > > > > If you fix the issue, kindly add following tag > Reported-by: kernel test robot > > > Details are as below: > --------------------------------------------------------------------------------------------------> > > > To reproduce: > > git clone https://github.com/intel/lkp-tests.git > cd lkp-tests > bin/lkp install job.yaml # job file is attached in this email > bin/lkp split-job --compatible job.yaml # generate the yaml file for lkp run > bin/lkp run generated-yaml-file > > ========================================================================================= > class/compiler/cpufreq_governor/disk/fs/kconfig/nr_threads/rootfs/tbox_group/test/testcase/testtime/ucode: > filesystem/gcc-9/performance/1HDD/xfs/x86_64-rhel-8.3/10%/debian-10.4-x86_64-20200603.cgz/lkp-csl-2sp7/fallocate/stress-ng/60s/0x5003006 > > commit: > 0431d926b3 ("xfs: async blkdev cache flush") > bad77c375e ("xfs: CIL checkpoint flushes caches unconditionally") > > 0431d926b399d74f bad77c375e8de6c776c848e443f > ---------------- --------------------------- > %stddev %change %stddev > \ | \ > 618.67 -10.0% 556.67 ± 2% stress-ng.fallocate.ops > 10.31 -10.0% 9.28 ± 2% stress-ng.fallocate.ops_per_sec > 111618 -5.7% 105270 stress-ng.time.voluntary_context_switches > 502.67 ± 2% +52.0% 763.83 ± 47% interrupts.CPU44.CAL:Function_call_interrupts > 2.10 ± 2% -25.1% 1.57 iostat.cpu.iowait > 2.16 ± 2% -0.5 1.62 mpstat.cpu.all.iowait% > 0.09 ± 11% +45.0% 0.14 ± 34% perf-sched.sch_delay.avg.ms.worker_thread.kthread.ret_from_fork > 151.00 ± 19% +20.2% 181.50 ± 7% perf-sched.wait_and_delay.count.smpboot_thread_fn.kthread.ret_from_fork > 6749 +6.4% 7178 perf-stat.i.context-switches > 6640 +6.4% 7063 perf-stat.ps.context-switches > 353877 -1.4% 348924 proc-vmstat.pgfree > 39122 -15.1% 33221 proc-vmstat.pgpgout > 1225 ± 14% -9.0% 1115 turbostat.Bzy_MHz > 86.82 ± 17% -10.4% 77.83 turbostat.PkgWatt > 602.83 -15.1% 511.83 vmstat.io.bo > 6953 +6.1% 7376 vmstat.system.cs > 1.33 ± 6% +0.4 1.70 ± 13% perf-profile.calltrace.cycles-pp.perf_mux_hrtimer_handler.__hrtimer_run_queues.hrtimer_interrupt.__sysvec_apic_timer_interrupt.sysvec_apic_timer_interrupt > 0.08 ± 22% +0.1 0.17 ± 23% perf-profile.children.cycles-pp.wait_for_completion > 0.07 ± 17% +0.1 0.19 ± 64% perf-profile.children.cycles-pp.submit_bio > 0.07 ± 17% +0.1 0.19 ± 64% perf-profile.children.cycles-pp.submit_bio_noacct > 1.40 ± 8% +0.3 1.74 ± 12% perf-profile.children.cycles-pp.perf_mux_hrtimer_handler > > > > stress-ng.fallocate.ops_per_sec > > 12 +----------------------------------------------------------------------+ > | | > 10 |.+.++.+.+.+ +.+.+.++.+.+.++.+.+.+.++.+.+.++.+.+.++.+.+.+.++.+.+.++.+.| > | O : : O O OO O O O OO | > | OO O :O : O O O O | > 8 |-+ O : : O O OO O O O O O O OO O | > | : : | > 6 |-+ : : | > | :: | > 4 |-+ :: | > | :: | > | :: | > 2 |-+ : | > | : | > 0 +----------------------------------------------------------------------+ > > > [*] bisect-good sample > [O] bisect-bad sample > > > > > Disclaimer: > Results have been estimated based on internal Intel analysis and are provided > for informational purposes only. Any difference in system hardware or software > design or configuration may affect actual performance. > > > --- > 0DAY/LKP+ Test Infrastructure Open Source Technology Center > https://lists.01.org/hyperkitty/list/lkp@lists.01.org Intel Corporation > > Thanks, > Oliver Sang > -- Zhengjun Xing