From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f179.google.com (mail-oi1-f179.google.com [209.85.167.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6DDCA2233A for ; Sat, 18 Apr 2026 16:24:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776529454; cv=none; b=dMG2+APUfkNFh5Irn2+YpJmno+DR8sv5g7C6dt4UFR2M0IhBvWChMpHhVxFa9yzvIvoZQz/p9scDbKgPXSKGyhTl+6cIrxkimx2zZ004ZYwM+bRHW+1rnOUlap79XAOl3LS06xTHG802zfKzRoNL6WKe1P7nFq763r++yu7ZgIo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776529454; c=relaxed/simple; bh=r3v0eu8jyNJghFoZb8nIZSTQlFmhjMLEDWwjRApN++s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=upD5SSj9dShi+LGhEFT4Iisxb9KFQ2nlB3PDuUlOW1oL8aNUpiLxB3RkaykUL1E5PKi6gOM5772kBP5H7jZeNnVgDbpUGloYNep3DovVguThfjNyvfnaGaCeqXlxgLNF3G+izeAqrJlPBJLdv4pviAA8xihLlkb8dktwkcFm3F8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b=RyqVfkKb; arc=none smtp.client-ip=209.85.167.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b="RyqVfkKb" Received: by mail-oi1-f179.google.com with SMTP id 5614622812f47-463a0e14abfso886353b6e.2 for ; Sat, 18 Apr 2026 09:24:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20251104.gappssmtp.com; s=20251104; t=1776529452; x=1777134252; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=I6Sv7AAI94WVTWDfs27d7TPLTcwxc8wbnSfHQgFK/To=; b=RyqVfkKbe/TDV1byPQrW3gdtJdmFYgQlxR2peus+0qYWEFoouOa4dQo+aX1MreP80V HeGpQHj/5Yb8ofu1iEQuPLQD5sMGaP+Nfq/6VmQf3GB/wpvAtYxc7yqyNLPuYzc0pqHs vVjNYv1tNxgJlyS+ashbt2frv7LlGtJnk4hlGoJpjN0+hZ0kD7whpnpKaKgNqXuU84z/ USwZXUjtefAz+V/HlO8CN/5H1QSm9g5IpBnEhbjkkSSThtJfaAjHpZTecZANYSD5eero 5aLGJpMtlsLrsAW+y/ly4FFCAwQsTIfo6R7XJUGMmED8L7tFlTF3YShtMfhP/HH+YBrQ GFuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776529452; x=1777134252; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=I6Sv7AAI94WVTWDfs27d7TPLTcwxc8wbnSfHQgFK/To=; b=YiMeDLnZ67x3eDf1mFLgJvcdVpEHROG8QYiOul8+Vv5v5T/xl1KlNV+sd8bX1M+fe9 knOfdM7JKowj+fkVCriYDPQoUl3yW0o8hjYqUMjSd2S5zYd7IG+439/bqWWCjo0nwStj lLqqtmCKTdPxukgc7xkRQqjqolhIS8kAwc5si+gLBOatg0BD+e3+OeBdHvAyo25TtWcW 1xFQ+qxk0yJivC6lJu0M3Zr5buKY9jhUDRlP8c7NFwdUyrf5okniPm7Ny/YUaLGooYdg aEwNm8MsCwvc800uujl2Xcnz+eE1+dwf2yVzqOwQbWYyVwsbPeJZ03VUxUrra+/Ka+NJ qSag== X-Forwarded-Encrypted: i=1; AFNElJ/06gDLoG9As/N0dzLYsDK1fu4wb0IYbrbYVXcrwh0zl8p6AlUutj0K15BcY1OVXVot2ni+eelcm9AnKiM=@vger.kernel.org X-Gm-Message-State: AOJu0Yygm5CVknRbxDDSVAS2AMyrIsVd9K9bI39mnJn74IWcQlJ/HlFr f/bycYIWxG+q05YfYONSi4XPNmoM6CfSBe8kyhnx0vS3/gksYYM3cAIxn0mmevwjUqQ= X-Gm-Gg: AeBDievs6/rWgRSDcwxNcV6xwokWHzJzLuspH18b18SP0eEKyUq4zRQV/HIhfBp1kZp FsLGEYYUnE/cbaNdKw1UOFt7vj5iU9ei9VyBhAH3+uneh9d74jLp9EMQq291BQ77yzLmBp/sehT uo1bNJw1NHLWIdjQaJl00uKXFmFt7M5shq2eJMULHzJejBlV/ilp6YA23lqEyhRe4MR1uV0+Dto 7tA6bQkR3O4i7aOKzEcLskufX8pQV4z2cLWgl4eIQR+uE289LH3GvT9X3j2q7OnlzQHgkhjHLxP Xvg2nlRYT3W5CM87T0R1QCJ36qfFISCP1Gc7D+RrukUpAesxkm1vJCThQQYJsmAw9hHKQb1sPFy PvkVQbgZUMO1UbwzvGvgiXrOBfvAXZ6NPqSaLQWpHCLKfUNB4PuXM3H7vcXdwKlMizMgcPMEmGC pciqC38etzN4RmrKB3wQ0M2US/jvFKGLtgVdolCwuM2t2H3Ti7X0rcIR+ditu7+YsfE8UEH8E7h MmiCv5qzFFY+yRDYBLWVXM= X-Received: by 2002:a05:6808:13d3:b0:46a:7718:c525 with SMTP id 5614622812f47-4799ca3e611mr4248868b6e.32.1776529452361; Sat, 18 Apr 2026 09:24:12 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:b1f8:aabe:74d7:21ba? ([2600:8803:e7e4:500:b1f8:aabe:74d7:21ba]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-42b930afa63sm4097296fac.5.2026.04.18.09.24.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 18 Apr 2026 09:24:11 -0700 (PDT) Message-ID: <36e3611d-642e-42de-9a56-cf81c3e06832@baylibre.com> Date: Sat, 18 Apr 2026 11:24:10 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 0/5] Update APDS990x ALS to support device trees To: Svyatoslav Ryhel , Jonathan Cameron , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Arnd Bergmann , Greg Kroah-Hartman , Randy Dunlap Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260418144716.132936-1-clamor95@gmail.com> Content-Language: en-US From: David Lechner In-Reply-To: <20260418144716.132936-1-clamor95@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 4/18/26 9:47 AM, Svyatoslav Ryhel wrote: > Document Avago APDS9900/9901 ALS/Proximity sensor in schema and modernize > its driver to support OF bindings. > > Svyatoslav Ryhel (5): > dt-bindings: iio: light: Document Avago APDS9900/9901 ALS/Proximity > sensor > misc: apds990x: Use more device managed approach in the probe > misc: apds990x: Drop Vled supply > misc: apds990x: Convert to use OF bindings > misc: apds990x: Drop IRQF_TRIGGER_LOW trigger > > .../bindings/iio/light/avago,apds9900.yaml | 83 ++++++++ > drivers/misc/apds990x.c | 197 +++++++++--------- As mentioned in my reply to the dt-bindings patch, there is already an IIO driver that looks like it could be compatible. I'm guessing that this misc driver pre-dates the IIO subsystem. I would have a look at it instead (drivers/iio/light/tsl2772.c). > include/linux/platform_data/apds990x.h | 65 ------ > 3 files changed, 187 insertions(+), 158 deletions(-) > create mode 100644 Documentation/devicetree/bindings/iio/light/avago,apds9900.yaml > delete mode 100644 include/linux/platform_data/apds990x.h >