From: "Paul Drynoff" <pauldrynoff@gmail.com>
To: "Pekka Enberg" <penberg@cs.helsinki.fi>
Cc: "Linus Torvalds" <torvalds@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kmalloc man page before 2.6.17
Date: Fri, 26 May 2006 11:58:06 +0400 [thread overview]
Message-ID: <36e6b2150605260058h5c1fbc0cla686a37d5bf3e34e@mail.gmail.com> (raw)
In-Reply-To: <84144f020605260017i4682c409vc4a004d016c31270@mail.gmail.com>
Actually, this is not full duplication:
__do_kmalloc(size_t size, gfp_t flags,
void *caller)
and
void *kmalloc(size_t size, gfp_t gfp)
they have different amount of arguments and different arguments names.
But as I see include/linux/slab.h is better place. See patch.
It will be great to create another entry for flags of "kmalloc* family
functions,
so we can avoid duplication of this in __do_kmalloc and kmalloc
comments, but I don't know is it possible with scripts/kernel-doc.
Signed-off-by: Paul Drynoff <pauldrynoff@gmail.com>
---
Index: linux-2.6.17-rc4/mm/slab.c
===================================================================
--- linux-2.6.17-rc4.orig/mm/slab.c
+++ linux-2.6.17-rc4/mm/slab.c
@@ -3244,7 +3244,7 @@ EXPORT_SYMBOL(kmalloc_node);
#endif
/**
- * kmalloc - allocate memory
+ * __do_kmalloc - allocate memory
* @size: how many bytes of memory are required.
* @flags: the type of memory to allocate.
* @caller: function caller for debug tracking of the caller
Index: linux-2.6.17-rc4/include/linux/slab.h
===================================================================
--- linux-2.6.17-rc4.orig/include/linux/slab.h
+++ linux-2.6.17-rc4/include/linux/slab.h
@@ -87,6 +87,27 @@ extern void *__kmalloc_track_caller(size
__kmalloc_track_caller(size, flags, __builtin_return_address(0))
#endif
+/**
+ * kmalloc - allocate memory
+ * @size: how many bytes of memory are required.
+ * @gfp: the type of memory to allocate.
+ *
+ * kmalloc is the normal method of allocating memory
+ * in the kernel.
+ *
+ * The @gfp argument may be one of:
+ *
+ * %GFP_USER - Allocate memory on behalf of user. May sleep.
+ *
+ * %GFP_KERNEL - Allocate normal kernel ram. May sleep.
+ *
+ * %GFP_ATOMIC - Allocation will not sleep. Use inside interrupt handlers.
+ *
+ * Additionally, the %GFP_DMA flag may be set to indicate the memory
+ * must be suitable for DMA. This can mean different things on different
+ * platforms. For example, on i386, it means that the memory must come
+ * from the first 16MB.
+ */
static inline void *kmalloc(size_t size, gfp_t flags)
{
if (__builtin_constant_p(size)) {
next prev parent reply other threads:[~2006-05-26 7:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-26 7:07 Paul Drynoff
2006-05-26 7:17 ` Pekka Enberg
2006-05-26 7:58 ` Paul Drynoff [this message]
2006-05-26 8:03 ` Pekka J Enberg
2006-05-26 8:20 ` Paul Drynoff
2006-05-26 9:42 ` Andrey Panin
2006-05-26 9:48 ` Jesper Juhl
2006-05-26 10:44 ` Paul Drynoff
2006-05-26 13:23 ` Paulo Marques
2006-05-26 14:17 ` Christoph Lameter
2006-05-26 14:55 ` Paul Drynoff
2006-05-26 15:03 ` Christoph Lameter
2006-05-26 19:55 ` Luca
2006-05-27 10:28 ` Martin Waitz
2006-05-26 10:47 ` Paul Drynoff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36e6b2150605260058h5c1fbc0cla686a37d5bf3e34e@mail.gmail.com \
--to=pauldrynoff@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®