From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 671E71C9DC8; Wed, 16 Oct 2024 10:40:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729075204; cv=none; b=qCOOapYtT5XYqFVCdt3UR+hk4FELPwRsvaBsUGs+CUDSdBmgcAUj3xncVTxsq8TEtYv0Ko5wdp6Q57Jwi9NNrDG8LhTeVqQWbm/GMpAbhr8usNQ3kY1vkawYxxNOnx9i5O/dM1qoOwk6W4HHzQSKh/01SFK+5F106CjLSkuLXEE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729075204; c=relaxed/simple; bh=dtUNeLW0XzuJcUmXw9cAyk4KOVcrQm3s/E+y1ypOjU4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=d4NdJt9O9i7TaYeVtSiBMfJNMFsEvmCOEhVEtM5cS4phuFCrAmuxANa1E321Y+nCt6PQwoDLDB0V63qciDlXSPrQtNg9AgnqUC2vKwl10baMAw7WEjztNiyYCVhkexBi7OFu9wQxenbBFQb+6Dova0/M0m/wy+HtjfCdeNOqGLc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=XJCJEqUp; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="XJCJEqUp" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1729075200; bh=dtUNeLW0XzuJcUmXw9cAyk4KOVcrQm3s/E+y1ypOjU4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=XJCJEqUp2gz+e267eyy2CmnJQAuvblWZTF9vz+9NFpDF6kSiO7hpBOQGG9vzgGukC 1QlnGCS7jl9ghgoUjGwkQ+2AUho0/KBaucd7TBvEAiYuvjscpxtpL3V+hdo+pucaLG +16kZTGtFY6zfuUqGFo1jZv244i1ZBdBbdKKP3lHMyGWfuvuXoX036V6v+75dUxzFR 2m9hoVhSIf6p6PvC/4PZXSzeVHGjKkoJGCXMbPV+GhUz0IbTUQsqS25Tt6gqkabxCl IwfzZWNkpRrXhdSWw2+dJe3jEmXmp3PVnQdwwwrN7JdTQkADCoZt7MfMo7XP+UVFxz VLFAHoGG8N3zg== Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by bali.collaboradmins.com (Postfix) with ESMTPSA id B64D917E139E; Wed, 16 Oct 2024 12:39:59 +0200 (CEST) Message-ID: <36e86177-a220-494d-8b25-55ce62cf054d@collabora.com> Date: Wed, 16 Oct 2024 12:39:59 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] arm64: dts: mediatek: mt8188: Add ethernet node To: =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , Richard Cochran Cc: kernel@collabora.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, netdev@vger.kernel.org, Jianguo Zhang , Macpaul Lin , Hsuan-Yu Lin References: <20241015-genio700-eth-v1-0-16a1c9738cf4@collabora.com> <20241015-genio700-eth-v1-1-16a1c9738cf4@collabora.com> From: AngeloGioacchino Del Regno Content-Language: en-US In-Reply-To: <20241015-genio700-eth-v1-1-16a1c9738cf4@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Il 15/10/24 20:15, Nícolas F. R. A. Prado ha scritto: > Describe the ethernet present on the MT8188. > > Signed-off-by: Jianguo Zhang > Signed-off-by: Macpaul Lin > Signed-off-by: Hsuan-Yu Lin > [Cleaned up to pass dtbs_check, follow DTS style guidelines, removed > hardcoded mac address and split between mt8188 and genio700 commits] > Signed-off-by: Nícolas F. R. A. Prado > --- > arch/arm64/boot/dts/mediatek/mt8188.dtsi | 95 ++++++++++++++++++++++++++++++++ > 1 file changed, 95 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8188.dtsi b/arch/arm64/boot/dts/mediatek/mt8188.dtsi > index b493207a1b688dba51bf5e0e469349263f54ca94..9e3981d6d5cfc8201d8caef256de1299aa8199e3 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8188.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8188.dtsi > @@ -1647,6 +1647,101 @@ spi5: spi@11019000 { > status = "disabled"; > }; > > + eth: ethernet@11021000 { > + compatible = "mediatek,mt8188-gmac", "mediatek,mt8195-gmac", > + "snps,dwmac-5.10a"; > + reg = <0 0x11021000 0 0x4000>; > + interrupts = ; > + interrupt-names = "macirq"; > + clocks = <&pericfg_ao CLK_PERI_AO_ETHERNET>, > + <&pericfg_ao CLK_PERI_AO_ETHERNET_BUS>, > + <&topckgen CLK_TOP_SNPS_ETH_250M>, > + <&topckgen CLK_TOP_SNPS_ETH_62P4M_PTP>, > + <&topckgen CLK_TOP_SNPS_ETH_50M_RMII>, > + <&pericfg_ao CLK_PERI_AO_ETHERNET_MAC>; clock-names = "axi", "apb", "mac_main", "ptp_ref", "rmii_internal", "mac_cg"; Since we can compress clock-names, we should just do that :-) > + clock-names = "axi", > + "apb", > + "mac_main", > + "ptp_ref", > + "rmii_internal", > + "mac_cg"; > + assigned-clocks = <&topckgen CLK_TOP_SNPS_ETH_250M>, > + <&topckgen CLK_TOP_SNPS_ETH_62P4M_PTP>, > + <&topckgen CLK_TOP_SNPS_ETH_50M_RMII>; > + assigned-clock-parents = <&topckgen CLK_TOP_ETHPLL_D2>, > + <&topckgen CLK_TOP_ETHPLL_D8>, > + <&topckgen CLK_TOP_ETHPLL_D10>; > + power-domains = <&spm MT8188_POWER_DOMAIN_ETHER>; > + mediatek,pericfg = <&infracfg_ao>; > + snps,axi-config = <&stmmac_axi_setup>; > + snps,mtl-rx-config = <&mtl_rx_setup>; > + snps,mtl-tx-config = <&mtl_tx_setup>; > + snps,txpbl = <16>; > + snps,rxpbl = <16>; > + snps,clk-csr = <0>; > + status = "disabled"; Well, the MDIO bus is part of the IP anyway, so I think we can just put it here. eth_mdio: mdio { compatible = "snps,dwmac-mdio"; #address-cells = <1>; #size-cells = <0>; }; > + > + stmmac_axi_setup: stmmac-axi-config { Please reorder: snps,blen = <0 0 0 0 16 8 4>; snps,rd_osr_lmt = <0x7>; snps,wr_osr_lmt = <0x7>; Cheers, Angelo